Page MenuHomePhabricator

[lib][web][native] Update createPendingThread usages
ClosedPublic

Authored by inka on Fri, Sep 6, 3:48 AM.
Tags
None
Referenced Files
F2709032: D13253.diff
Sun, Sep 15, 5:38 PM
Unknown Object (File)
Sat, Sep 14, 5:30 PM
Unknown Object (File)
Sat, Sep 14, 1:32 PM
Unknown Object (File)
Sat, Sep 14, 12:02 PM
Unknown Object (File)
Fri, Sep 13, 7:47 PM
Unknown Object (File)
Fri, Sep 13, 4:43 AM
Unknown Object (File)
Thu, Sep 12, 9:41 PM
Unknown Object (File)
Wed, Sep 11, 6:53 AM
Subscribers

Details

Summary

issue: ENG-8974
I went through all places where createPendingThread is used and checked what needs to be done for them. Some places still need to be updated, but they are related to useExistingThreadInfoFinder, which is a different task.

Test Plan
  1. Tested that ComposeThreadButton creates a thick thread now. It's the button used on iOS for creating a new chat from the chat tab
  2. composeThread in ChatThreadList is the same as ComposeThreadButton, but for Android instead of iOS. Assuming it works since iOS works
  3. Checked that Top/bar which uses useThreadInfoForPossiblyPendingThread correctly shows the name of the user the ucrrent user is not friends with. Checked that it correctly shows the name of a chat the user is a member of
  4. createPendingPersonalThread is used in
    • createPendingThreadItem used to create an item in the thread list, but only for personal chats with users the current user has not yet messaged ever. Checked that their names are shown correctly in those items.
    • useUserProfileThreadInfo used to display profile info of users the user doesn't yet know. Thested that their name and friendship buttons are shown correctly

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lib/shared/thread-utils.js
1491–1493 ↗(On Diff #43910)

This makes thick sidebars be created in thick threads. Checked it works
There is only one problem - when I create the sidebar on native I don't get notified about it on web. I will investigate this

inka requested review of this revision.Fri, Sep 6, 4:19 AM
tomek requested changes to this revision.Fri, Sep 6, 7:38 AM
tomek added inline comments.
lib/shared/thread-utils.js
588 ↗(On Diff #43910)

Should this use a flag?

This revision now requires changes to proceed.Fri, Sep 6, 7:38 AM
lib/shared/thread-utils.js
1491–1493 ↗(On Diff #43910)

The issue is resolved by D13259

This revision is now accepted and ready to land.Thu, Sep 12, 7:41 AM