Page MenuHomePhabricator
Differential D13335

[lib][web][native] Refactor usingOlmViaTunnelbrokerForDMs
ClosedPublic
Actions

Authored by inka on Sep 13 2024, 6:58 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 1, 1:26 PM
Unknown Object (File)
Tue, Apr 1, 9:16 AM
Unknown Object (File)
Tue, Apr 1, 3:16 AM
Unknown Object (File)
Mon, Mar 31, 4:27 PM
Unknown Object (File)
Sun, Mar 30, 5:10 AM
Unknown Object (File)
Thu, Mar 27, 11:47 AM
Unknown Object (File)
Mon, Mar 24, 9:36 PM
Unknown Object (File)
Thu, Mar 20, 8:59 PM
View All 61 Files
Subscribers
ashoat

Details

Reviewers
tomek
kamil
Commits
rCOMMaed77d4733bd: [lib][web][native] Refactor usingOlmViaTunnelbrokerForDMs
Summary

issue: ENG-9263
We want to allow thick threads for dev and staff

Test Plan

flow, tested that creating thick threads works on native

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka created this revision.Sep 13 2024, 6:58 AM
Herald added a subscriber: ashoat. · View Herald TranscriptSep 13 2024, 6:58 AM
inka added a parent revision: D13333: [lib] update threadLabel to handle thick threads.Sep 13 2024, 6:58 AM
inka added a child revision: D13320: [web][native] Update UI to not display GENESIS over thick threads.Sep 13 2024, 7:19 AM
Harbormaster completed remote builds in B31614: Diff 44174.Sep 13 2024, 7:19 AM
inka requested review of this revision.Sep 13 2024, 7:19 AM
tomek accepted this revision.Sep 13 2024, 7:24 AM
This revision is now accepted and ready to land.Sep 13 2024, 7:24 AM
tomek added inline comments.Sep 13 2024, 8:06 AM
lib/hooks/flag-hooks.js
9–12 ↗(On Diff #44174)

Maybe it's better to use useStaffCanSee.

Closed by commit rCOMMaed77d4733bd: [lib][web][native] Refactor usingOlmViaTunnelbrokerForDMs (authored by inka). · Explain WhySep 13 2024, 8:59 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMMaed77d4733bd: [lib][web][native] Refactor usingOlmViaTunnelbrokerForDMs.
inka added inline comments.Sep 13 2024, 9:02 AM
lib/hooks/flag-hooks.js
9–12 ↗(On Diff #44174)

That is a native specific flag

Revision Contents
Changeset List

Diff 44186

View Options

lib/hooks/flag-hooks.js

Show All 40 Linesfunction DMOpsQueueHandler(): React.Node {
const threadInfos = useSelector(threadInfoSelector); const threadInfos = useSelector(threadInfoSelector);
const threadIDs = React.useMemo( const threadIDs = React.useMemo(
() => new Set(Object.keys(threadInfos)), () => new Set(Object.keys(threadInfos)),
[threadInfos], [threadInfos],
); );
const prevThreadIDsRef = React.useRef<$ReadOnlySet<string>>(new Set()); const prevThreadIDsRef = React.useRef<$ReadOnlySet<string>>(new Set());
const queuedOperations = useSelector( const queuedOperations = useSelector(
state => state.queuedDMOperations.operations, state => state.queuedDMOperations.threadQueue,
); );
const processDMOperation = useProcessDMOperation(); const processDMOperation = useProcessDMOperation();
React.useEffect(() => { React.useEffect(() => {
const prevThreadIDs = prevThreadIDsRef.current; const prevThreadIDs = prevThreadIDsRef.current;
prevThreadIDsRef.current = threadIDs; prevThreadIDsRef.current = threadIDs;
Show All 30 Lines
View Options

lib/shared/thread-actions-utils.js

Show All 40 Linesfunction DMOpsQueueHandler(): React.Node {
const threadInfos = useSelector(threadInfoSelector); const threadInfos = useSelector(threadInfoSelector);
const threadIDs = React.useMemo( const threadIDs = React.useMemo(
() => new Set(Object.keys(threadInfos)), () => new Set(Object.keys(threadInfos)),
[threadInfos], [threadInfos],
); );
const prevThreadIDsRef = React.useRef<$ReadOnlySet<string>>(new Set()); const prevThreadIDsRef = React.useRef<$ReadOnlySet<string>>(new Set());
const queuedOperations = useSelector( const queuedOperations = useSelector(
state => state.queuedDMOperations.operations, state => state.queuedDMOperations.threadQueue,
); );
const processDMOperation = useProcessDMOperation(); const processDMOperation = useProcessDMOperation();
React.useEffect(() => { React.useEffect(() => {
const prevThreadIDs = prevThreadIDsRef.current; const prevThreadIDs = prevThreadIDsRef.current;
prevThreadIDsRef.current = threadIDs; prevThreadIDsRef.current = threadIDs;
Show All 30 Lines
View Options

lib/shared/thread-utils.js

Show All 40 Linesfunction DMOpsQueueHandler(): React.Node {
const threadInfos = useSelector(threadInfoSelector); const threadInfos = useSelector(threadInfoSelector);
const threadIDs = React.useMemo( const threadIDs = React.useMemo(
() => new Set(Object.keys(threadInfos)), () => new Set(Object.keys(threadInfos)),
[threadInfos], [threadInfos],
); );
const prevThreadIDsRef = React.useRef<$ReadOnlySet<string>>(new Set()); const prevThreadIDsRef = React.useRef<$ReadOnlySet<string>>(new Set());
const queuedOperations = useSelector( const queuedOperations = useSelector(
state => state.queuedDMOperations.operations, state => state.queuedDMOperations.threadQueue,
); );
const processDMOperation = useProcessDMOperation(); const processDMOperation = useProcessDMOperation();
React.useEffect(() => { React.useEffect(() => {
const prevThreadIDs = prevThreadIDsRef.current; const prevThreadIDs = prevThreadIDsRef.current;
prevThreadIDsRef.current = threadIDs; prevThreadIDsRef.current = threadIDs;
Show All 30 Lines
View Options

lib/utils/services-utils.js

Show All 40 Linesfunction DMOpsQueueHandler(): React.Node {
const threadInfos = useSelector(threadInfoSelector); const threadInfos = useSelector(threadInfoSelector);
const threadIDs = React.useMemo( const threadIDs = React.useMemo(
() => new Set(Object.keys(threadInfos)), () => new Set(Object.keys(threadInfos)),
[threadInfos], [threadInfos],
); );
const prevThreadIDsRef = React.useRef<$ReadOnlySet<string>>(new Set()); const prevThreadIDsRef = React.useRef<$ReadOnlySet<string>>(new Set());
const queuedOperations = useSelector( const queuedOperations = useSelector(
state => state.queuedDMOperations.operations, state => state.queuedDMOperations.threadQueue,
); );
const processDMOperation = useProcessDMOperation(); const processDMOperation = useProcessDMOperation();
React.useEffect(() => { React.useEffect(() => {
const prevThreadIDs = prevThreadIDsRef.current; const prevThreadIDs = prevThreadIDsRef.current;
prevThreadIDsRef.current = threadIDs; prevThreadIDsRef.current = threadIDs;
Show All 30 Lines
View Options

native/chat/chat-thread-list.react.js

Loading...
View Options

native/chat/compose-thread-button.react.js

Loading...
View Options

native/chat/message-list-container.react.js

Loading...
View Options

native/input/input-state-container.react.js

Loading...
View Options

web/chat/thread-list-provider.js

Loading...
View Options

web/input/input-state-container.react.js

Loading...
View Options

web/utils/thread-utils.js

Loading...