Page MenuHomePhabricator
Feed All Stories

Today

will requested review of D12551: [identity] Downgrades search trace error.
Sun, Jun 23, 8:41 PM
will requested review of D12550: [terraform] Change alarm names to reflect staging or production environment.
Sun, Jun 23, 8:22 PM

Yesterday

bartek accepted D12537: [lib] introduce setting Tunnelbroker device token action.
Sat, Jun 22, 7:09 AM

Fri, Jun 21

bartek accepted D12529: [terraform] Allow all ip addresses to access self-host internet gateway.
Fri, Jun 21, 11:21 PM
bartek accepted D12528: [terraform] run mariadb in public db group.
Fri, Jun 21, 11:20 PM
bartek added inline comments to D12524: [lib] implement sending message to Tunnelbroker.
Fri, Jun 21, 11:19 PM
bartek accepted D12523: [Tunnelbroker] handle `SetDeviceToken` message.
Fri, Jun 21, 11:11 PM
bartek accepted D12526: [Identity] remove Tunnelbroker data on device removal.
Fri, Jun 21, 11:04 PM
bartek added a comment to D12525: [proto][Tunnelbroker] add RPC to delete device data from Tunnelbroker.

What about undelivered_messages? Are they considered a "device data" too?

Fri, Jun 21, 11:02 PM
bartek accepted D12519: [Tunnelbroker] implement getting device token.
Fri, Jun 21, 10:55 PM
bartek accepted D12518: [Tunnelbroker] implement removing device token.
Fri, Jun 21, 10:55 PM
bartek accepted D12547: remove reserved wallet registration RPC.

Why did we introduce it initially? 🤨

Fri, Jun 21, 10:54 PM
bartek accepted D12544: [identity] fix reserved username workflow for wallet users.

Looks good. Left some nits

Fri, Jun 21, 10:51 PM
bartek accepted D12515: [identity] fix wallet account deletion bug.
Fri, Jun 21, 10:41 PM
bartek added inline comments to D12520: [Tunnelbroker] implement setting device token.
Fri, Jun 21, 10:36 PM
bartek added inline comments to D12520: [Tunnelbroker] implement setting device token.
Fri, Jun 21, 10:32 PM
bartek accepted D12517: [Tunnelbroker] define device tokens table in rust.

Simple change to imports and adding undelivered_messages:: made it look much better

Fri, Jun 21, 10:15 PM
bartek accepted D12516: [terraform] create DDB table for device tokens.
Fri, Jun 21, 10:13 PM
varun added a comment to D12546: [web] inform password users that they need to log in from native to claim username.

i'll try to shorten the message so it fits on one line. looks a little janky rn

Fri, Jun 21, 5:15 PM
varun attached a referenced file: F2068619: Screenshot 2024-06-21 at 5.17.30 PM.png.
Fri, Jun 21, 5:14 PM
varun updated the test plan for D12546: [web] inform password users that they need to log in from native to claim username.
Fri, Jun 21, 5:14 PM
varun attached a referenced file: F2068589: Screenshot 2024-06-21 at 8.13.05 PM.png.
Fri, Jun 21, 5:13 PM
varun updated the test plan for D12545: [web] handle case where user needs to log in from native first.
Fri, Jun 21, 5:13 PM
varun requested review of D12549: [web] fix uncaught exception when user cancels SIWE.
Fri, Jun 21, 5:13 PM
varun requested review of D12548: [web] fix uncaught exception bug.
Fri, Jun 21, 5:10 PM
varun requested review of D12547: remove reserved wallet registration RPC.
Fri, Jun 21, 5:07 PM
varun requested review of D12546: [web] inform password users that they need to log in from native to claim username.
Fri, Jun 21, 5:02 PM
varun requested review of D12545: [web] handle case where user needs to log in from native first.
Fri, Jun 21, 5:00 PM
varun requested review of D12544: [identity] fix reserved username workflow for wallet users.
Fri, Jun 21, 4:53 PM
varun added a comment to D12501: [lib] mark prekeys as published after uploading to identity.

What if a user is successfully registered/logged in to Identity but for some reason markPrekeysAsPublished fails? Wondering, if shouldn't catch and ignore errors here and make sure later PrekeysHandler re-uploads the same keys and marks as published (since marking as published is used only for rotation).

I think existing logic should handle this because it uploads not published keys and marks as published (not sure about native but logic should match).

It might be strange if a user sees that registration fails, but after attempting sees that the user already exists because registration worked but marking keys as published failed.

Curious for @marcin's perspective.

Accepting to unblock and I don't have a strong opinion on which approach is better, only pointing out something worth considering.

Fri, Jun 21, 4:23 PM
varun closed D12479: [web][native] olm api method to mark prekeys as published.
Fri, Jun 21, 4:20 PM
varun committed rCOMM8b786f1788c0: [web][native] olm api method to mark prekeys as published (authored by varun).
[web][native] olm api method to mark prekeys as published
Fri, Jun 21, 4:20 PM
Harbormaster failed remote builds in B29881: Diff 41624 for D12543: [keyserver] Use `threadIsWithBlockedUserOnlyWithoutAdminRoleCheck` instead of `threadFrozenDueToBlock` in `checkThreadsFrozen`!
Fri, Jun 21, 2:52 PM
atul published D12543: [keyserver] Use `threadIsWithBlockedUserOnlyWithoutAdminRoleCheck` instead of `threadFrozenDueToBlock` in `checkThreadsFrozen` for review.
Fri, Jun 21, 2:39 PM
ginsu added a comment to D12534: [web] introduce RemoveTagButton.

I can see in invite links modal, that when an error appears we change the size of the modal to add the additional needed space

Fri, Jun 21, 1:42 PM
ginsu added inline comments to D12542: [native] fix error handling in TagFarcasterChannelByName.
Fri, Jun 21, 1:38 PM
ginsu requested review of D12542: [native] fix error handling in TagFarcasterChannelByName.
Fri, Jun 21, 1:36 PM
ginsu updated the summary of D12541: [native] handle loading state in TagFarcasterChannelByName.
Fri, Jun 21, 12:29 PM
ginsu updated the diff for D12541: [native] handle loading state in TagFarcasterChannelByName.

update

Fri, Jun 21, 12:25 PM
ginsu requested review of D12541: [native] handle loading state in TagFarcasterChannelByName.
Fri, Jun 21, 11:53 AM
ginsu requested review of D12540: [native] fix indexing in tag channel button action sheet.
Fri, Jun 21, 11:44 AM
ginsu updated the summary of D12534: [web] introduce RemoveTagButton.
Fri, Jun 21, 11:26 AM
ginsu closed D12535: [lib/native] introduce useCreateFarcasterChannelTag.
Fri, Jun 21, 11:23 AM
ginsu committed rCOMMed338cd1770c: [lib/native] introduce useCreateFarcasterChannelTag (authored by ginsu).
[lib/native] introduce useCreateFarcasterChannelTag
Fri, Jun 21, 11:23 AM
ginsu updated the diff for D12535: [lib/native] introduce useCreateFarcasterChannelTag.

rebase before landing

Fri, Jun 21, 11:22 AM
ginsu added a comment to D12535: [lib/native] introduce useCreateFarcasterChannelTag.

Removed from stack so I can land as is. Confirmed that this is safe + does not cause any merge conflicts when rebasing

Fri, Jun 21, 11:21 AM
ginsu updated the summary of D12535: [lib/native] introduce useCreateFarcasterChannelTag.
Fri, Jun 21, 11:21 AM
ginsu closed D12533: [native] fix button container height in RemoveTagButton.
Fri, Jun 21, 11:20 AM
ginsu committed rCOMMf772adbc5483: [native] fix button container height in RemoveTagButton (authored by ginsu).
[native] fix button container height in RemoveTagButton
Fri, Jun 21, 11:20 AM
ginsu closed D12532: [lib/native] introduce useRemoveFarcasterChannelTag.
Fri, Jun 21, 11:20 AM
ginsu committed rCOMMd58a4b0c065e: [lib/native] introduce useRemoveFarcasterChannelTag (authored by ginsu).
[lib/native] introduce useRemoveFarcasterChannelTag
Fri, Jun 21, 11:19 AM
ginsu updated the diff for D12533: [native] fix button container height in RemoveTagButton.

rebase before landing

Fri, Jun 21, 11:19 AM
ginsu updated the diff for D12532: [lib/native] introduce useRemoveFarcasterChannelTag.

rebase before landing

Fri, Jun 21, 11:18 AM
ginsu added a comment to D12532: [lib/native] introduce useRemoveFarcasterChannelTag.

Removed from stack so I can land as is. Confirmed that this is safe + does not cause any merge conflicts when rebasing

Fri, Jun 21, 11:17 AM
ginsu updated the summary of D12532: [lib/native] introduce useRemoveFarcasterChannelTag.
Fri, Jun 21, 11:17 AM
ginsu added inline comments to D12532: [lib/native] introduce useRemoveFarcasterChannelTag.
Fri, Jun 21, 11:17 AM
ginsu closed D12500: [native/web] fix manage farcaster channel tag permission migration.
Fri, Jun 21, 9:59 AM
ginsu closed D12503: [keyserver/lib/native] flip the switch for farcaster channel tagging.
Fri, Jun 21, 9:59 AM
ginsu committed rCOMMb8a0c977b46b: [keyserver/lib/native] flip the switch for farcaster channel tagging (authored by ginsu).
[keyserver/lib/native] flip the switch for farcaster channel tagging
Fri, Jun 21, 9:59 AM
ginsu committed rCOMM8fc5e88db124: [native/web] fix manage farcaster channel tag permission migration (authored by ginsu).
[native/web] fix manage farcaster channel tag permission migration
Fri, Jun 21, 9:59 AM
ginsu closed D12499: [lib] remove updateThreadStoreThreadInfos util function.
Fri, Jun 21, 9:59 AM
ginsu closed D12498: [lib/native] lift createUpdateDBOpsForThreadStoreThreadInfos into lib.
Fri, Jun 21, 9:59 AM
ginsu committed rCOMM0462bf7cc9b0: [lib/native] lift createUpdateDBOpsForThreadStoreThreadInfos into lib (authored by ginsu).
[lib/native] lift createUpdateDBOpsForThreadStoreThreadInfos into lib
Fri, Jun 21, 9:59 AM
ginsu committed rCOMM32270fba0afa: [lib] remove updateThreadStoreThreadInfos util function (authored by ginsu).
[lib] remove updateThreadStoreThreadInfos util function
Fri, Jun 21, 9:59 AM
ginsu closed D12497: [web/native] make redux persist migration 77 no-op.
Fri, Jun 21, 9:59 AM
ginsu committed rCOMM8b04f656613e: [web/native] make redux persist migration 77 no-op (authored by ginsu).
[web/native] make redux persist migration 77 no-op
Fri, Jun 21, 9:59 AM
ginsu updated the diff for D12503: [keyserver/lib/native] flip the switch for farcaster channel tagging.

rebase before landing

Fri, Jun 21, 9:35 AM
ginsu updated the diff for D12500: [native/web] fix manage farcaster channel tag permission migration.

rebase before landing

Fri, Jun 21, 9:35 AM
ginsu updated the test plan for D12500: [native/web] fix manage farcaster channel tag permission migration.
Fri, Jun 21, 9:34 AM
ginsu updated the diff for D12499: [lib] remove updateThreadStoreThreadInfos util function.

rebase before landing

Fri, Jun 21, 9:27 AM
ginsu updated the diff for D12498: [lib/native] lift createUpdateDBOpsForThreadStoreThreadInfos into lib.

rebase before landing

Fri, Jun 21, 9:25 AM
ginsu updated the diff for D12497: [web/native] make redux persist migration 77 no-op.

rebase before landing

Fri, Jun 21, 9:24 AM
inka added inline comments to D12488: [lib] Introduce thickThreadTypes and ThickThreadType.
Fri, Jun 21, 5:56 AM
marcin updated the diff for D12427: Move android rescinds and badge updates to lib.

Address Ashoat requests

Fri, Jun 21, 5:48 AM
kamil added a comment to D12427: Move android rescinds and badge updates to lib.

You forgot to address @ashoat's comments

Fri, Jun 21, 5:30 AM
inka added inline comments to D12513: [lib] Discard keyserver usernames for processServerRequestsActionType.
Fri, Jun 21, 5:14 AM
inka added inline comments to D12514: [lib] Discard keyserver usernames for updateUserAvatarActionTypes.
Fri, Jun 21, 5:08 AM
marcin added inline comments to D8566: Upload/download large notification payload from the keyserver/Android NSE if its size exceeds FCM limits.
Fri, Jun 21, 4:46 AM
inka accepted D12538: [lib] introduce Tunnelbroker device token handler.
Fri, Jun 21, 4:46 AM
marcin updated the diff for D12539: Utilise subscription from ThickMemberInfo when building a notif.

Fix android bug

Fri, Jun 21, 4:44 AM
marcin added inline comments to D12397: Move notification creaction and encryption to lib except for APNs noifs..
Fri, Jun 21, 4:37 AM
marcin requested review of D12539: Utilise subscription from ThickMemberInfo when building a notif.
Fri, Jun 21, 4:25 AM
marcin added inline comments to D8566: Upload/download large notification payload from the keyserver/Android NSE if its size exceeds FCM limits.
Fri, Jun 21, 4:25 AM
kamil accepted D12508: [backup] Use authenticated service trait.
Fri, Jun 21, 4:03 AM
kamil added a comment to D12507: [comm-lib][reports] Extract 'authenticated' service trait.

Overall looks good but might be good to get a review from someone with more experience in Rust (cc. @varun)

Fri, Jun 21, 4:02 AM
kamil resigned from D12530: [web] introduce TagFarcasterChannelModal.
Fri, Jun 21, 3:51 AM
kamil accepted D12501: [lib] mark prekeys as published after uploading to identity.

What if a user is successfully registered/logged in to Identity but for some reason markPrekeysAsPublished fails? Wondering, if shouldn't catch and ignore errors here and make sure later PrekeysHandler re-uploads the same keys and marks as published (since marking as published is used only for rotation).

Fri, Jun 21, 3:51 AM
kamil resigned from D12459: [keysever/lib/native] extend joinThread to handle auto join functionality.
Fri, Jun 21, 3:36 AM
kamil accepted D12514: [lib] Discard keyserver usernames for updateUserAvatarActionTypes.
Fri, Jun 21, 3:34 AM
kamil accepted D12513: [lib] Discard keyserver usernames for processServerRequestsActionType.
Fri, Jun 21, 3:28 AM
inka accepted D12537: [lib] introduce setting Tunnelbroker device token action.
Fri, Jun 21, 3:28 AM
inka accepted D12536: [lib][web][native] set local Tunnelbroker device token on client.
Fri, Jun 21, 3:27 AM
kamil accepted D12512: [lib] Discard keyserver usernames for incremental state sync and processUpdatesActionType.
Fri, Jun 21, 3:26 AM
kamil accepted D12510: [lib] Discard keyserver usernames for full state sync.
Fri, Jun 21, 3:25 AM
kamil accepted D12509: [lib] Discard keyserver usernames for keyserverAuthActionTypes.
Fri, Jun 21, 3:24 AM
kamil published D12538: [lib] introduce Tunnelbroker device token handler for review.
Fri, Jun 21, 2:48 AM
kamil published D12537: [lib] introduce setting Tunnelbroker device token action for review.
Fri, Jun 21, 2:47 AM
kamil published D12536: [lib][web][native] set local Tunnelbroker device token on client for review.
Fri, Jun 21, 2:47 AM
inka accepted D12527: [lib][web][native] add Tunnelbroker device token to redux.
Fri, Jun 21, 2:35 AM
kamil accepted D12397: Move notification creaction and encryption to lib except for APNs noifs..

Thanks!

Fri, Jun 21, 1:31 AM