Page MenuHomePhabricator
Feed All Stories

Today

will accepted D11799: [lib] Search for users in thread list search.

Looks good to me

Fri, Apr 26, 7:51 PM
ashoat accepted D11780: [keyserver] Fix sending a user cookie when olm session creation failed.
Fri, Apr 26, 6:08 PM
tomek requested review of D11823: [lib][native][web] Show a message when a user is already a part of a community.
Fri, Apr 26, 1:41 PM
atul requested review of D11822: [lib] Narrow `canToggleMessagePin` and `useCanToggleMessagePin` types.
Fri, Apr 26, 1:36 PM
varun planned changes to D11811: [web][native] mark keys as published before uploading to identity service.
Fri, Apr 26, 1:33 PM
ginsu requested review of D11821: [lib] introduce useDeleteFarcasterChannelTag.
Fri, Apr 26, 1:30 PM
atul requested review of D11820: [web] Replace `canToggleMessagePin` with `useCanToggleMessagePin` in `useMessageTogglePinAction`.
Fri, Apr 26, 1:26 PM
atul requested review of D11819: [lib] Introduce `useCanToggleMessagePin` and consume in `native/Message`.
Fri, Apr 26, 1:22 PM
atul requested review of D11818: [lib] Replace `threadHasPermission` with `useThreadHasPermission` in `useCanCreateReactionFromMessage`.
Fri, Apr 26, 1:16 PM
atul requested review of D11817: [lib] Replace `threadHasPermission` with `useThreadHasPermission` in `useCanCreateSidebarFromMessage`.
Fri, Apr 26, 1:10 PM
atul requested review of D11816: [lib] Replace `threadHasPermission` with `useThreadHasPermission` in `useCanEditMessage`.
Fri, Apr 26, 1:07 PM
ginsu requested review of D11815: [lib] introduce deleteFarcasterChannelTagActionTypes.
Fri, Apr 26, 1:03 PM
varun updated the test plan for D11810: [keyserver] mark prekeys and OTKs as published right before calling identity service.
Fri, Apr 26, 12:59 PM
ginsu requested review of D11814: [keyserver/lib] introduce delete_farcaster_channel_tag endpoint.
Fri, Apr 26, 12:58 PM
varun updated the test plan for D11810: [keyserver] mark prekeys and OTKs as published right before calling identity service.
Fri, Apr 26, 12:52 PM
ginsu requested review of D11813: [keyserver] introduce deleteFarcasterChannelTag.
Fri, Apr 26, 12:51 PM
tomek requested review of D11812: [lib][native][web] Display a message when accepting an invite link times out.
Fri, Apr 26, 12:46 PM
varun requested review of D11811: [web][native] mark keys as published before uploading to identity service.
Fri, Apr 26, 12:40 PM
varun requested review of D11810: [keyserver] mark prekeys and OTKs as published right before calling identity service.
Fri, Apr 26, 12:35 PM
ginsu requested review of D11809: [native] show error message for tag farcaster channel errors.
Fri, Apr 26, 12:27 PM
ginsu requested review of D11808: [keysever/lib/native] introduce gate for tagging farcaster channel work.
Fri, Apr 26, 12:16 PM
ginsu added inline comments to D11793: [native] introduce tag farcaster button.
Fri, Apr 26, 12:13 PM
atul closed D11792: [lib] Turn `canPromoteSidebar` to `useCanPromoteSidebar` hook.
Fri, Apr 26, 12:13 PM
atul committed rCOMM64ad347fd686: [lib] Turn `canPromoteSidebar` to `useCanPromoteSidebar` hook (authored by atul).
[lib] Turn `canPromoteSidebar` to `useCanPromoteSidebar` hook
Fri, Apr 26, 12:12 PM
atul updated the diff for D11792: [lib] Turn `canPromoteSidebar` to `useCanPromoteSidebar` hook.

consolidate conditional

Fri, Apr 26, 12:08 PM
ginsu added inline comments to D11793: [native] introduce tag farcaster button.
Fri, Apr 26, 12:01 PM
ginsu updated the diff for D11793: [native] introduce tag farcaster button.

update createCreateOrUpdateActionPromise to return the response

Fri, Apr 26, 12:00 PM
ginsu requested review of D11773: [keyserver] introduce create_or_update_farcaster_channel_tag endpoint.

In D11808, we gate the entire endpoint and this should address the concerns regarding exposing the endpoint w/o permissions +ensuring that nobody will ever have a blob holder on their client

Fri, Apr 26, 11:59 AM
ashoat requested review of D11807: [native] Fix pending state in ExistingEthereumAccount for identity auth.
Fri, Apr 26, 11:57 AM
ginsu updated the summary of D11773: [keyserver] introduce create_or_update_farcaster_channel_tag endpoint.
Fri, Apr 26, 11:56 AM
ashoat closed D11801: [native] Don't auto-capitalize password entry in PasswordSelection.
Fri, Apr 26, 11:55 AM
ashoat committed rCOMMa234956433a8: [native] Don't auto-capitalize password entry in PasswordSelection (authored by ashoat).
[native] Don't auto-capitalize password entry in PasswordSelection
Fri, Apr 26, 11:55 AM
ashoat requested review of D11806: [lib][native][web] Rename LogInExtraInfo to LegacyLogInExtraInfo.
Fri, Apr 26, 11:52 AM
atul added inline comments to D11792: [lib] Turn `canPromoteSidebar` to `useCanPromoteSidebar` hook.
Fri, Apr 26, 11:47 AM
ashoat requested review of D11805: [lib][native][web] Rename some legacy login types.
Fri, Apr 26, 11:46 AM
atul closed D11791: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `ThreadSettings`.
Fri, Apr 26, 11:46 AM
atul closed D11790: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `TextMessage`.
Fri, Apr 26, 11:46 AM
atul committed rCOMM136bd75e5a11: [native] Replace `threadHasPermission` with `useThreadHasPermission` in… (authored by atul).
[native] Replace `threadHasPermission` with `useThreadHasPermission` in…
Fri, Apr 26, 11:46 AM
tomek updated the test plan for D11800: [lib] Properly handle hashing in progress.
Fri, Apr 26, 11:46 AM
atul committed rCOMMee863bd9130e: [native] Replace `threadHasPermission` with `useThreadHasPermission` in… (authored by atul).
[native] Replace `threadHasPermission` with `useThreadHasPermission` in…
Fri, Apr 26, 11:46 AM
atul closed D11789: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `ChatInputBar`.
Fri, Apr 26, 11:46 AM
atul closed D11788: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `Entry`.
Fri, Apr 26, 11:46 AM
atul committed rCOMM44f0eb5b7bb2: [native] Replace `threadHasPermission` with `useThreadHasPermission` in… (authored by atul).
[native] Replace `threadHasPermission` with `useThreadHasPermission` in…
Fri, Apr 26, 11:46 AM
atul committed rCOMM35ac66da12dd: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `Entry` (authored by atul).
[native] Replace `threadHasPermission` with `useThreadHasPermission` in `Entry`
Fri, Apr 26, 11:46 AM
atul closed D11786: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `ViewInviteLinksScreen`.
Fri, Apr 26, 11:46 AM
atul closed D11787: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `CommunityActionsButton`.
Fri, Apr 26, 11:46 AM
atul committed rCOMMbdb7d7e4f575: [native] Replace `threadHasPermission` with `useThreadHasPermission` in… (authored by atul).
[native] Replace `threadHasPermission` with `useThreadHasPermission` in…
Fri, Apr 26, 11:46 AM
atul committed rCOMM70c6da8e1aab: [native] Replace `threadHasPermission` with `useThreadHasPermission` in… (authored by atul).
[native] Replace `threadHasPermission` with `useThreadHasPermission` in…
Fri, Apr 26, 11:46 AM
atul closed D11754: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `ThreadSettings`.
Fri, Apr 26, 11:46 AM
atul committed rCOMM5c7f9868ce1a: [native] Replace `threadHasPermission` with `useThreadHasPermission` in… (authored by atul).
[native] Replace `threadHasPermission` with `useThreadHasPermission` in…
Fri, Apr 26, 11:45 AM
ashoat requested review of D11804: [lib] Fix payload of KEYSERVER_AUTH_STARTED action.
Fri, Apr 26, 11:43 AM
atul updated the diff for D11791: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `ThreadSettings`.

land

Fri, Apr 26, 11:43 AM
atul updated the diff for D11790: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `TextMessage`.

land

Fri, Apr 26, 11:43 AM
atul updated the diff for D11789: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `ChatInputBar`.

land

Fri, Apr 26, 11:43 AM
ashoat requested review of D11803: [lib][native] Rename keyserverRegister to legacyKeyserverRegister.
Fri, Apr 26, 11:42 AM
ashoat requested review of D11802: [lib][native][web] Rename siweAuth to legacySiweAuth.
Fri, Apr 26, 11:40 AM
ashoat added a comment to D11764: [lib][native][web] Rename useLogIn to useLegacyLogIn.
In D11764#338319, @inka wrote:

Should we rename siweAuthActionTypes to legacySiweAuthActionTypes and keyserverRegisterActionTypes to legacyKeyserverRegisterActionTypes?

Good call. I'll do those in separate diffs

Fri, Apr 26, 11:32 AM
varun closed D11796: [identity] delete all token data on user account deletion.
Fri, Apr 26, 11:31 AM
varun committed rCOMMb08ab7a0087b: [identity] delete all token data on user account deletion (authored by varun).
[identity] delete all token data on user account deletion
Fri, Apr 26, 11:31 AM
varun closed D11795: [identity] move access token table db methods to separate module.
Fri, Apr 26, 11:31 AM
varun committed rCOMM0ef563d1f949: [identity] move access token table db methods to separate module (authored by varun).
[identity] move access token table db methods to separate module
Fri, Apr 26, 11:31 AM
atul updated the diff for D11788: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `Entry`.

land

Fri, Apr 26, 11:07 AM
atul updated the diff for D11787: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `CommunityActionsButton`.

land

Fri, Apr 26, 11:06 AM
atul updated the diff for D11786: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `ViewInviteLinksScreen`.

land

Fri, Apr 26, 11:06 AM
atul updated the diff for D11754: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `ThreadSettings`.

land

Fri, Apr 26, 10:55 AM
ginsu accepted D11801: [native] Don't auto-capitalize password entry in PasswordSelection.
Fri, Apr 26, 10:15 AM
inka accepted D11785: [native] introduce TagFarcasterChannelParams.
Fri, Apr 26, 8:32 AM
inka accepted D11784: [native] update selectedChannel state to be a FarcasterChannel type.
Fri, Apr 26, 8:30 AM
ashoat closed D11769: [lib] Don't set dataLoaded on authoritative keyserver auth.
Fri, Apr 26, 8:18 AM
ashoat committed rCOMM6c22f9210dab: [lib] Don't set dataLoaded on authoritative keyserver auth (authored by ashoat).
[lib] Don't set dataLoaded on authoritative keyserver auth
Fri, Apr 26, 8:18 AM
ashoat closed D11768: [lib][native][web] Introduce useWalletLogIn hook.
Fri, Apr 26, 8:18 AM
ashoat closed D11767: [native] Use useRegistrationServerCall in FullscreenSIWEPanel for identity registration.
Fri, Apr 26, 8:18 AM
ashoat committed rCOMM84670804db33: [lib][native][web] Introduce useWalletLogIn hook (authored by ashoat).
[lib][native][web] Introduce useWalletLogIn hook
Fri, Apr 26, 8:18 AM
ashoat committed rCOMMce4b2c8e917d: [native] Use useRegistrationServerCall in FullscreenSIWEPanel for identity… (authored by ashoat).
[native] Use useRegistrationServerCall in FullscreenSIWEPanel for identity…
Fri, Apr 26, 8:18 AM
ashoat closed D11766: [lib][native] Defer saving user credentials until successful auth.
Fri, Apr 26, 8:18 AM
ashoat closed D11765: [lib][native][web] Introduce usePasswordLogIn hook.
Fri, Apr 26, 8:18 AM
ashoat closed D11764: [lib][native][web] Rename useLogIn to useLegacyLogIn.
Fri, Apr 26, 8:18 AM
ashoat committed rCOMM424ea6f92e58: [lib][native] Defer saving user credentials until successful auth (authored by ashoat).
[lib][native] Defer saving user credentials until successful auth
Fri, Apr 26, 8:18 AM
ashoat committed rCOMMb1dff3d63e23: [lib][native][web] Introduce usePasswordLogIn hook (authored by ashoat).
[lib][native][web] Introduce usePasswordLogIn hook
Fri, Apr 26, 8:18 AM
ashoat committed rCOMM60e5ad1f8f90: [lib][native][web] Rename useLogIn to useLegacyLogIn (authored by ashoat).
[lib][native][web] Rename useLogIn to useLegacyLogIn
Fri, Apr 26, 8:18 AM
ashoat closed D11762: [lib] Don't try authing to authoritative keyserver from KeyserverConnectionHandler.
Fri, Apr 26, 8:18 AM
ashoat closed D11763: [native] Auth with authoritative keyserver directly from registration flow.
Fri, Apr 26, 8:18 AM
ashoat committed rCOMMb6892dc7ad72: [lib] Don't try authing to authoritative keyserver from… (authored by ashoat).
[lib] Don't try authing to authoritative keyserver from…
Fri, Apr 26, 8:18 AM
ashoat committed rCOMM6853e9c0f6dd: [native] Auth with authoritative keyserver directly from registration flow (authored by ashoat).
[native] Auth with authoritative keyserver directly from registration flow
Fri, Apr 26, 8:18 AM
ashoat closed D11761: [lib] Extract useRawKeyserverAuth.
Fri, Apr 26, 8:18 AM
ashoat committed rCOMMd8130c105d12: [lib] Extract useRawKeyserverAuth (authored by ashoat).
[lib] Extract useRawKeyserverAuth
Fri, Apr 26, 8:18 AM
ashoat updated the diff for D11768: [lib][native][web] Introduce useWalletLogIn hook.

Use the name walletLogIn for the result of useWalletLogIn(), and rename attemptIdentityWalletLogIn to attemptWalletLogIn

Fri, Apr 26, 8:15 AM
ashoat requested review of D11801: [native] Don't auto-capitalize password entry in PasswordSelection.
Fri, Apr 26, 8:14 AM
ashoat updated the diff for D11765: [lib][native][web] Introduce usePasswordLogIn hook.

waiting_for_identity_login_in_redux -> identity_login_dispatched

Fri, Apr 26, 8:10 AM
ashoat added inline comments to D11767: [native] Use useRegistrationServerCall in FullscreenSIWEPanel for identity registration.
Fri, Apr 26, 8:06 AM
ashoat added a comment to D11764: [lib][native][web] Rename useLogIn to useLegacyLogIn.
In D11764#338319, @inka wrote:

Should we rename siweAuthActionTypes to legacySiweAuthActionTypes and keyserverRegisterActionTypes to legacyKeyserverRegisterActionTypes?

Fri, Apr 26, 8:04 AM
ashoat updated the diff for D11763: [native] Auth with authoritative keyserver directly from registration flow.

waiting_for_identity_registration_in_redux -> identity_registration_dispatched
waiting_for_authoritative_keyserver_registration_in_redux -> authoritative_keyserver_registration_dispatched

Fri, Apr 26, 8:04 AM
ashoat closed D11794: [native] Don't refetch nonce after SIWE is complete.
Fri, Apr 26, 7:59 AM
ashoat committed rCOMMaa57bc6d30c8: [native] Don't refetch nonce after SIWE is complete (authored by ashoat).
[native] Don't refetch nonce after SIWE is complete
Fri, Apr 26, 7:59 AM
ashoat updated the diff for D11794: [native] Don't refetch nonce after SIWE is complete.

doneRef -> nonceNotNeededRef

Fri, Apr 26, 7:59 AM
tomek updated the summary of D11800: [lib] Properly handle hashing in progress.
Fri, Apr 26, 7:27 AM
tomek updated the diff for D11800: [lib] Properly handle hashing in progress.

Handle syncing with non-auth keyservers

Fri, Apr 26, 7:26 AM
marcin accepted D11731: [lib/web/native] implement sending confirmation of processed message.
Fri, Apr 26, 7:20 AM
marcin accepted D11729: [native/web] rename `decryptSequential` -> `decryptSequentialAndPersist`.
Fri, Apr 26, 7:16 AM
marcin accepted D11728: [web] decrypt and persist plaintext in SQL transaction.
Fri, Apr 26, 7:15 AM