Page MenuHomePhabricator
Feed All Stories

Today

michal accepted D11127: Enable SQLite database to hold two olm accounts: content and notifs.
Mon, Mar 4, 3:32 AM
michal added a comment to D11230: [lib][native] Introduce supportingMultipleKeyservers constant.

is there an existing task tracking implementing backup restore for corrupt database recovery, for both native and web? I want to add a comment referencing this code in SQLiteDataHandler, to make sure it's updated as part of that task.

Mon, Mar 4, 3:17 AM
tomek accepted D11217: [lib][native] Try session recovery on web too for policy acknowledgment crash loop.
Mon, Mar 4, 2:51 AM
tomek accepted D11216: [lib][native] Use unified keyserver session recovery in native/socket.react.js.
Mon, Mar 4, 2:49 AM
tomek accepted D11215: [lib][native][web] Use unified keyserver session recovery in lib/socket/socket.react.js.
Mon, Mar 4, 2:43 AM
tomek accepted D11214: [lib] Deprecate resetUserStateActionType.
Mon, Mar 4, 2:38 AM
marcin accepted D11219: [lib][native][web] Refactor useInitialNotificationsEncryptedMessage to get Olm session creator from context.
Mon, Mar 4, 2:10 AM
marcin added a comment to D11168: [SQLite] add table for messages to device.

Are we going to backup this table? If so then we should add it to NativeSQLiteConnectionManager so that logs are capture for this table. If not then we should update createMainCompaction method so that removeDeviceSpecificDataSQL script removes data from this table after backup is created.

Mon, Mar 4, 2:04 AM
tomek accepted D11213: [native] Use unified keyserver session recovery in LoggedOutModal.
Mon, Mar 4, 1:58 AM
tomek accepted D11212: [lib] Replace sessionRecoveryInProgress with actionSessionRecovery.

Just to make sure: sessionRecoveryInProgress isn't persisted, right?

Mon, Mar 4, 1:47 AM
tomek accepted D11211: [lib] Deprecate recoveryActionSources.sqliteOpFailure.

I think that the practice of keeping commented-out types has a big advantage of reducing confusion when searching older revisions while it doesn't have any significant disadvantages.

Mon, Mar 4, 1:29 AM
tomek accepted D11210: [lib][native] Separate out recoveryActionSources.
Mon, Mar 4, 1:25 AM
tomek requested changes to D11209: [lib] Update `threadHasAdminRole` to consider `specialField`.

However, if there is no specialRole field encountered, we will assume we're dealing with a Server/"legacy" type and fallback to sketchy string search.

What is the scenario when this can happen?

Mon, Mar 4, 1:07 AM
tomek accepted D11208: [lib] Deprecate `useRoleDeletableAndEditableStatus` and determine `is[Editable/Deletable]` directly in `RoleActionsMenu`.

We should reintroduce the util (probably as a simple function) if we would need to decide if we can edit / delete a role in some other places.

Mon, Mar 4, 1:05 AM
tomek accepted D11206: [web] Compute `existingRole` instead of `existingRoleID` in `RoleActionsMenu`.
Mon, Mar 4, 12:59 AM
tomek requested changes to D11205: [lib][native] Introduce `useRoleNamesToSpecialRole` to remove `"Admins"` string check in `RolePanelEntry`.

I don't understand the reason behind this diff and the task from the summary doesn't have any description. Why can't we simply check RoleInfo and its specialRole field?

Mon, Mar 4, 12:57 AM
tomek accepted D11194: [identity] separate allow origin lists for staging and prod.
Mon, Mar 4, 12:48 AM

Yesterday

ashoat requested review of D11224: [lib][native] Deprecate DispatchRecoveryAttempt in favor of DispatchActionPromise.
Sun, Mar 3, 11:30 PM
will requested review of D11231: [identity] Replace elastic crate in identity.
Sun, Mar 3, 10:59 PM
ashoat requested review of D11230: [lib][native] Introduce supportingMultipleKeyservers constant.
Sun, Mar 3, 10:18 PM
ashoat requested review of D11229: [lib][web] Update condition for Redux state reset in SET_NEW_SESSION reducers.
Sun, Mar 3, 10:14 PM
ashoat requested review of D11228: [lib] Introduce relyingOnAuthoritativeKeyserver constant.
Sun, Mar 3, 10:10 PM
ashoat requested review of D11227: [native] Use useKeyserverRecoveryLogIn from SQLiteDataHandler.
Sun, Mar 3, 10:06 PM
ashoat requested review of D11226: [lib] Extract useKeyserverRecoveryLogIn.
Sun, Mar 3, 10:02 PM
ashoat requested review of D11225: [lib] Make resolveKeyserverSessionInvalidation generic.
Sun, Mar 3, 9:58 PM
ashoat requested review of D11223: [lib][native] Make cancellation work for keyserver session recovery.
Sun, Mar 3, 9:49 PM
ashoat requested review of D11222: [lib] Don't cancel an auth that the keyserver completes.
Sun, Mar 3, 9:45 PM
ashoat requested review of D11221: [lib] Factor out CANCELLED_ERROR into keyserver-conn-types.js.
Sun, Mar 3, 9:42 PM
ashoat requested review of D11220: [lib][native] Initialize notif Olm channel during keyserver session recovery.
Sun, Mar 3, 9:37 PM
ashoat requested review of D11219: [lib][native][web] Refactor useInitialNotificationsEncryptedMessage to get Olm session creator from context.
Sun, Mar 3, 9:33 PM
ashoat requested review of D11218: [lib] Initiate a keyserver session recovery when keyserver socket sends not_logged_in.
Sun, Mar 3, 9:29 PM
ashoat requested review of D11217: [lib][native] Try session recovery on web too for policy acknowledgment crash loop.
Sun, Mar 3, 9:25 PM
ashoat requested review of D11216: [lib][native] Use unified keyserver session recovery in native/socket.react.js.
Sun, Mar 3, 9:21 PM
ashoat requested review of D11215: [lib][native][web] Use unified keyserver session recovery in lib/socket/socket.react.js.
Sun, Mar 3, 9:17 PM
ashoat requested review of D11214: [lib] Deprecate resetUserStateActionType.
Sun, Mar 3, 9:13 PM
ashoat requested review of D11213: [native] Use unified keyserver session recovery in LoggedOutModal.
Sun, Mar 3, 9:08 PM
ashoat requested review of D11212: [lib] Replace sessionRecoveryInProgress with actionSessionRecovery.
Sun, Mar 3, 9:04 PM
ashoat requested review of D11211: [lib] Deprecate recoveryActionSources.sqliteOpFailure.
Sun, Mar 3, 9:00 PM
ashoat requested review of D11210: [lib][native] Separate out recoveryActionSources.
Sun, Mar 3, 8:56 PM
ashoat updated the diff for D10972: [lib] Clear sessionRecoveryInProgress during auth / deauth.

Rebase

Sun, Mar 3, 8:37 PM
ashoat updated the diff for D10970: [lib] Dispatch SET_NEW_SESSION when session recovery fails.

Rebase

Sun, Mar 3, 8:36 PM
ashoat updated the diff for D10954: [lib] Move CallKeyserverEndpoint session recovery to KeyserverConnectionHandler.

Rebase

Sun, Mar 3, 8:34 PM
ashoat updated the diff for D10952: [lib] Let keyserver session recovery code handle calling setNewSession.

Add detail to code comment about removing boundSetNewSession call once usingCommServicesAccessToken is true

Sun, Mar 3, 8:34 PM
ashoat updated the diff for D10972: [lib] Clear sessionRecoveryInProgress during auth / deauth.

Rebase

Sun, Mar 3, 5:48 PM
ashoat updated the diff for D10970: [lib] Dispatch SET_NEW_SESSION when session recovery fails.

Rebase

Sun, Mar 3, 5:48 PM
ashoat updated the diff for D10954: [lib] Move CallKeyserverEndpoint session recovery to KeyserverConnectionHandler.

Use urlPrefixSelector

Sun, Mar 3, 5:45 PM
ashoat added inline comments to D10954: [lib] Move CallKeyserverEndpoint session recovery to KeyserverConnectionHandler.
Sun, Mar 3, 5:42 PM

Sat, Mar 2

ashoat added a reverting change for rCOMM12a56bc91fcf: [native] Temporary changes for staff release: rCOMM025145fc8b16: Revert "[native] Temporary changes for staff release".
Sat, Mar 2, 8:54 AM
ashoat committed rCOMM025145fc8b16: Revert "[native] Temporary changes for staff release" (authored by ashoat).
Revert "[native] Temporary changes for staff release"
Sat, Mar 2, 8:54 AM
ashoat committed rCOMM931f4db6dcd0: [native] codeVersion -> 328 (authored by ashoat).
[native] codeVersion -> 328
Sat, Mar 2, 8:54 AM
ashoat committed rCOMM12a56bc91fcf: [native] Temporary changes for staff release (authored by ashoat).
[native] Temporary changes for staff release
Sat, Mar 2, 8:54 AM
ashoat committed rCOMM6543d8e4a340: [native] codeVersion -> 327 (authored by ashoat).
[native] codeVersion -> 327
Sat, Mar 2, 8:54 AM
ashoat added a reverting change for rCOMMfaf2ec8553c9: [native] Test changesNotSentForReview: true AGAIN: rCOMM3a5a2fd4f65c: Revert "[native] Test changesNotSentForReview: true AGAIN".
Sat, Mar 2, 8:51 AM
ashoat committed rCOMM3a5a2fd4f65c: Revert "[native] Test changesNotSentForReview: true AGAIN" (authored by ashoat).
Revert "[native] Test changesNotSentForReview: true AGAIN"
Sat, Mar 2, 8:51 AM

Fri, Mar 1

ashoat added a reverting change for rCOMMde0269169bf1: [native] Temporary changes for staff release: rCOMMa4757d294275: Revert "[native] Temporary changes for staff release".
Fri, Mar 1, 4:49 PM
ashoat committed rCOMMa4757d294275: Revert "[native] Temporary changes for staff release" (authored by ashoat).
Revert "[native] Temporary changes for staff release"
Fri, Mar 1, 4:49 PM
ashoat committed rCOMMfdc793a55aac: [native] codeVersion -> 326 (authored by ashoat).
[native] codeVersion -> 326
Fri, Mar 1, 4:49 PM
ashoat committed rCOMMde0269169bf1: [native] Temporary changes for staff release (authored by ashoat).
[native] Temporary changes for staff release
Fri, Mar 1, 4:49 PM
ashoat committed rCOMM744eacc14c73: [native] codeVersion -> 325 (authored by ashoat).
[native] codeVersion -> 325
Fri, Mar 1, 4:49 PM
ashoat committed rCOMM4aa27479c942: [web][keyserver] codeVersion -> 73 (authored by ashoat).
[web][keyserver] codeVersion -> 73
Fri, Mar 1, 4:45 PM
ashoat accepted D11204: [web][native][keyserver] Flip the switch to enable `specialRole` field.

Just going to accept this to move it off my queue, but in our 1:1 @atul mentioned he still wanted to do some additional testing before landing

Fri, Mar 1, 3:14 PM
ashoat accepted D11207: [web] fix regression in error handling.
Fri, Mar 1, 3:08 PM
ashoat added inline comments to D11204: [web][native][keyserver] Flip the switch to enable `specialRole` field.
Fri, Mar 1, 1:32 PM
atul published D11209: [lib] Update `threadHasAdminRole` to consider `specialField` for review.
Fri, Mar 1, 1:19 PM
atul requested review of D11208: [lib] Deprecate `useRoleDeletableAndEditableStatus` and determine `is[Editable/Deletable]` directly in `RoleActionsMenu`.
Fri, Mar 1, 1:13 PM
will accepted D11193: [terraform] expose remote environment type to identity service as env var.

Looks good to me. Might want to adjust the diff title and test plan but that's really it.

Fri, Mar 1, 12:53 PM
varun requested review of D11207: [web] fix regression in error handling.
Fri, Mar 1, 12:53 PM
varun requested review of D11193: [terraform] expose remote environment type to identity service as env var.

@will can you give this one more pass? it's changed quite a bit

Fri, Mar 1, 12:39 PM
atul requested review of D11206: [web] Compute `existingRole` instead of `existingRoleID` in `RoleActionsMenu`.
Fri, Mar 1, 12:35 PM
varun updated the diff for D11194: [identity] separate allow origin lists for staging and prod.

address feedback

Fri, Mar 1, 12:31 PM
varun added inline comments to D11194: [identity] separate allow origin lists for staging and prod.
Fri, Mar 1, 12:31 PM
varun updated the diff for D11193: [terraform] expose remote environment type to identity service as env var.

make the allow origin list more configurable

Fri, Mar 1, 12:27 PM
atul published D11205: [lib][native] Introduce `useRoleNamesToSpecialRole` to remove `"Admins"` string check in `RolePanelEntry` for review.
Fri, Mar 1, 12:06 PM
atul updated the summary of D11204: [web][native][keyserver] Flip the switch to enable `specialRole` field.
Fri, Mar 1, 11:42 AM
atul requested review of D11204: [web][native][keyserver] Flip the switch to enable `specialRole` field.
Fri, Mar 1, 11:06 AM
marcin updated the diff for D11047: Add getter and setter for integers, getter for all keys and function to remove subset of keys to MMKV.

Refactor to match changes in parent differential

Fri, Mar 1, 9:14 AM
marcin updated the diff for D11046: Introduce MMKV to Android app.
  1. Refactor to match new iOS logic.
  2. Address Bartek and Tomek comments.
Fri, Mar 1, 9:13 AM
varun closed D11201: [keyserver][native] treat valid eth address as invalid username in non-siwe registration.
Fri, Mar 1, 8:18 AM
varun committed rCOMM71ffd4946c97: [keyserver][native] treat valid eth address as invalid username in non-siwe… (authored by varun).
[keyserver][native] treat valid eth address as invalid username in non-siwe…
Fri, Mar 1, 8:18 AM
Harbormaster failed remote builds in B27247: Diff 37722 for D11045: Introduce MMKV to iOS app and NSE!
Fri, Mar 1, 8:04 AM
tomek closed D11203: [keyserver] Delete ALTER TABLE statement for deleted table.
Fri, Mar 1, 8:02 AM
tomek committed rCOMMf6955bb91350: [keyserver] Delete ALTER TABLE statement for deleted table (authored by tomek).
[keyserver] Delete ALTER TABLE statement for deleted table
Fri, Mar 1, 8:02 AM
marcin accepted D11203: [keyserver] Delete ALTER TABLE statement for deleted table.
Fri, Mar 1, 7:59 AM
marcin updated the diff for D11047: Add getter and setter for integers, getter for all keys and function to remove subset of keys to MMKV.

Update iOS code to fix reentrancy issues with the NSE

Fri, Mar 1, 7:53 AM
marcin updated the diff for D11045: Introduce MMKV to iOS app and NSE.

Fix reentrancy issues with MMKV in the NSE.

Fri, Mar 1, 7:53 AM
tomek requested review of D11203: [keyserver] Delete ALTER TABLE statement for deleted table.
Fri, Mar 1, 7:51 AM
marcin planned changes to D11045: Introduce MMKV to iOS app and NSE.

This differential is incorrect. The reason is that in case user logs out the main app will update encryption key in secure store, but the NSE will the old encryption key in a static variable. The NSE is not guaranteed to be restarted for each notif so this is a concern. To mitigate this we need to fetch encryption key each time we call initialize provided we are running in the NSE. Unfortunately it is not enough. MMKV is implemented in such a way that there is a global dictionary mapping from mmkv id to MMKV* instance. When we call mmkvWithID the library first checks if an instance is in the dictionary and returns it in case it is. Each MMKV* instance keeps cryptKey as an instance variable. Therefore even if we fetch new encryption key in running NSE process we will still get MMKV* instance with outdated encryption key. To fully solve the issue we should rotate both encryption key and mmkv id. I will update the diff shortly.

Fri, Mar 1, 7:25 AM
marcin accepted D11175: [SQLite] implement tests `MessageToDevice` queries.
Fri, Mar 1, 2:31 AM
marcin accepted D11172: [SQLite] implement removing `MessageToDevice` items.
Fri, Mar 1, 2:25 AM
marcin requested changes to D11171: [SQLite] implement getting `MessageToDevice` items.
Fri, Mar 1, 2:22 AM
marcin accepted D11170: [SQLite] implement adding `MessageToDevice` to table.
Fri, Mar 1, 2:17 AM
marcin accepted D11169: [SQLite] add `MessageToDevice` entity.
Fri, Mar 1, 2:15 AM
marcin added inline comments to D11168: [SQLite] add table for messages to device.
Fri, Mar 1, 2:14 AM
kamil published D11175: [SQLite] implement tests `MessageToDevice` queries for review.
Fri, Mar 1, 12:25 AM
kamil published D11174: [SQLite] add Emscripten bindings to `MessageToDevice` queries for review.
Fri, Mar 1, 12:25 AM
kamil published D11172: [SQLite] implement removing `MessageToDevice` items for review.
Fri, Mar 1, 12:25 AM
kamil published D11171: [SQLite] implement getting `MessageToDevice` items for review.
Fri, Mar 1, 12:24 AM
kamil published D11170: [SQLite] implement adding `MessageToDevice` to table for review.
Fri, Mar 1, 12:24 AM
kamil published D11169: [SQLite] add `MessageToDevice` entity for review.
Fri, Mar 1, 12:24 AM
kamil published D11168: [SQLite] add table for messages to device for review.
Fri, Mar 1, 12:24 AM