Page MenuHomePhabricator
Feed All Stories

All Stories
Use Results
Edit Query

Today

tomek accepted D14495: [lib] Fix highestTimestamp assignment in useGetLastUpdatedTimes.
Mon, Mar 24, 9:16 AM
tomek accepted D14494: [lib] Only use threadInfo.creationTime for lastUpdatedTime if no messages.
Mon, Mar 24, 9:09 AM
tomek accepted D14493: [lib] Fix bug in ChatThreadItemLoaderCache for simultaneous loadMostRecent calls.
Mon, Mar 24, 9:02 AM
ashoat requested review of D14495: [lib] Fix highestTimestamp assignment in useGetLastUpdatedTimes.
Mon, Mar 24, 8:38 AM
ashoat requested review of D14494: [lib] Only use threadInfo.creationTime for lastUpdatedTime if no messages.
Mon, Mar 24, 8:29 AM
ashoat requested review of D14493: [lib] Fix bug in ChatThreadItemLoaderCache for simultaneous loadMostRecent calls.
Mon, Mar 24, 7:43 AM
bartek closed D14489: [lib][native] Add keyserverDeviceID to LatestBackupInfo.
Mon, Mar 24, 6:55 AM
bartek committed rCOMM598630cb095b: [lib][native] Add keyserverDeviceID to LatestBackupInfo (authored by bartek).
[lib][native] Add keyserverDeviceID to LatestBackupInfo
Mon, Mar 24, 6:55 AM
bartek closed D14467: [backup] Return keyserver device ID in latest backup info endpoint.
Mon, Mar 24, 6:55 AM
bartek closed D14466: [grpc-clients] Add helpers for services grpc client.
Mon, Mar 24, 6:55 AM
bartek committed rCOMMbefb888d494e: [backup] Return keyserver device ID in latest backup info endpoint (authored by bartek).
[backup] Return keyserver device ID in latest backup info endpoint
Mon, Mar 24, 6:55 AM
bartek committed rCOMM17fde856cadc: [grpc-clients] Add helpers for services grpc client (authored by bartek).
[grpc-clients] Add helpers for services grpc client
Mon, Mar 24, 6:55 AM
bartek closed D14465: [identity] Support service-to-service token in auth RPCs.
Mon, Mar 24, 6:55 AM
bartek committed rCOMMa241d420bbb6: [identity] Support service-to-service token in auth RPCs (authored by bartek).
[identity] Support service-to-service token in auth RPCs
Mon, Mar 24, 6:55 AM
bartek published D14492: [protos][identity] Remove primary device info from GetKeyserverKeys for review.
Mon, Mar 24, 6:32 AM
Harbormaster failed remote builds in B33816: Diff 47527 for D14467: [backup] Return keyserver device ID in latest backup info endpoint!
Mon, Mar 24, 6:20 AM
bartek updated the diff for D14467: [backup] Return keyserver device ID in latest backup info endpoint.

Add serde rename directive

Mon, Mar 24, 6:08 AM
bartek added inline comments to D14467: [backup] Return keyserver device ID in latest backup info endpoint.
Mon, Mar 24, 6:07 AM
bartek added inline comments to D14465: [identity] Support service-to-service token in auth RPCs.
Mon, Mar 24, 6:04 AM
bartek published D14490: [identity] Support tuples in device list verification for review.
Mon, Mar 24, 4:53 AM
bartek published D14491: [native] Add keyserver to device list during restore for review.
Mon, Mar 24, 4:42 AM
kamil accepted D14489: [lib][native] Add keyserverDeviceID to LatestBackupInfo.
Mon, Mar 24, 3:59 AM
kamil accepted D14467: [backup] Return keyserver device ID in latest backup info endpoint.
Mon, Mar 24, 3:56 AM
kamil accepted D14466: [grpc-clients] Add helpers for services grpc client.
Mon, Mar 24, 3:47 AM
bartek published D14489: [lib][native] Add keyserverDeviceID to LatestBackupInfo for review.
Mon, Mar 24, 3:41 AM
kamil accepted D14465: [identity] Support service-to-service token in auth RPCs.
Mon, Mar 24, 3:13 AM

Yesterday

bartek added inline comments to D14481: [native] Remove ffmpeg dependency.
Sun, Mar 23, 11:55 PM
bartek published D14467: [backup] Return keyserver device ID in latest backup info endpoint for review.
Sun, Mar 23, 11:51 PM
bartek published D14466: [grpc-clients] Add helpers for services grpc client for review.
Sun, Mar 23, 11:48 PM
bartek published D14465: [identity] Support service-to-service token in auth RPCs for review.
Sun, Mar 23, 11:48 PM
bartek accepted D14470: [ios] Implement getVideoInfo() function on iOS.
Sun, Mar 23, 11:48 PM
bartek accepted D14480: [native] Use transcodeVideo() from MediaModule instead of ffmpeg.

Looks much cleaner now

Sun, Mar 23, 11:45 PM
bartek requested changes to D14478: [android] Implement transcodeVideo() function on Android.

Requesting changes because of these null checks which might lead to crash

Sun, Mar 23, 11:40 PM
varun published D14488: [native] enable connect farcaster prompt, display prompt after nux tips have all been dismissed for review.
Sun, Mar 23, 9:25 AM
varun added a comment to D14444: [lib] launch connect farcaster prompt.

the hardware back button on android does close the bottom sheet, but doesn't trigger the component's onChange callback

Sun, Mar 23, 8:23 AM
ashoat accepted D14444: [lib] launch connect farcaster prompt.
Sun, Mar 23, 8:23 AM
varun updated the diff for D14444: [lib] launch connect farcaster prompt.

address feedback

Sun, Mar 23, 8:18 AM

Fri, Mar 21

ashoat closed D14486: [native] Script to bump native version.
Fri, Mar 21, 4:20 PM
ashoat committed rCOMM06bd90759920: [native] Script to bump native version (authored by ashoat).
[native] Script to bump native version
Fri, Mar 21, 4:20 PM
ashoat added inline comments to D14481: [native] Remove ffmpeg dependency.
Fri, Mar 21, 4:13 PM
ashoat updated the diff for D14486: [native] Script to bump native version.

One more comment update

Fri, Mar 21, 4:01 PM
ashoat updated the diff for D14486: [native] Script to bump native version.

Update comment

Fri, Mar 21, 3:59 PM
ashoat added a comment to D14486: [native] Script to bump native version.
  • don't we need to document it somewhere in some README?
Fri, Mar 21, 3:59 PM
ashoat added inline comments to D14471: [native] Use getVideoInfo from MediaModule instead of ffmpeg.
Fri, Mar 21, 10:08 AM
bartek accepted D14481: [native] Remove ffmpeg dependency.

Wondering how much smaller our binaries will be without ffmpeg 😀

Fri, Mar 21, 8:57 AM
bartek accepted D14479: [ios] Implement transcodeVideo() function on iOS.

Nice work!

Fri, Mar 21, 8:52 AM
bartek accepted D14487: [ci] Update mac runner image in github workflows.

If we want to be sure that it works before landing we can try making a PR to gh and run actions on the PR?

Fri, Mar 21, 8:32 AM
angelika requested review of D14487: [ci] Update mac runner image in github workflows.
Fri, Mar 21, 5:28 AM
tomek accepted D14486: [native] Script to bump native version.
Fri, Mar 21, 4:20 AM
bartek added inline comments to D14478: [android] Implement transcodeVideo() function on Android.
Fri, Mar 21, 2:19 AM
bartek accepted D14477: [native] Use generateThumbnail() from MediaModule instead of ffmpeg.
Fri, Mar 21, 2:00 AM
bartek accepted D14476: [ios] Implement generateThumbnail() function on iOS.
Fri, Mar 21, 1:57 AM
bartek accepted D14475: [android] Implement generateThumbnail() function on Android.
Fri, Mar 21, 1:56 AM
bartek accepted D14474: [native] Use hasMultipleFrames() from MediaModule instead of ffmpeg.
Fri, Mar 21, 1:53 AM
bartek accepted D14473: [ios] Implement hasMultipleFrames() function on iOS.
Fri, Mar 21, 1:52 AM
bartek accepted D14472: [android] Implement hasMultipleFrames() function on Android.
Fri, Mar 21, 1:51 AM
bartek accepted D14471: [native] Use getVideoInfo from MediaModule instead of ffmpeg.

Looking at this diff, the thing you did with format seems right

Fri, Mar 21, 1:50 AM
bartek added inline comments to D14470: [ios] Implement getVideoInfo() function on iOS.
Fri, Mar 21, 1:48 AM
bartek accepted D14469: [android] Implement getVideoInfo() function on Android.
Fri, Mar 21, 1:42 AM
bartek accepted D14468: [native] Add MediaModule expo module.
Fri, Mar 21, 1:40 AM
angelika accepted D14486: [native] Script to bump native version.

LGTM, but:

  • don't we need to document it somewhere in some README?
  • as far as I understand to update the version you bump the version in version.mjs first, then run the script, can't we automate the first step too?
  • you can also automate making commits too later?
Fri, Mar 21, 12:32 AM

Thu, Mar 20

ashoat requested review of D14486: [native] Script to bump native version.
Thu, Mar 20, 9:08 PM
ashoat committed rCOMMc1e6a12cab9e: Podfile updates for ffmpeg-kit-min-ios changes (authored by ashoat).
Podfile updates for ffmpeg-kit-min-ios changes
Thu, Mar 20, 8:57 PM
ashoat committed rCOMM61e73cd47c25: [terraform] Bump keyserver image to 1.0.158 (authored by ashoat).
[terraform] Bump keyserver image to 1.0.158
Thu, Mar 20, 8:25 PM
ashoat committed rCOMM5c3ef7ff9a58: Revert "[native] Temporary changes for staff release" (authored by ashoat).
Revert "[native] Temporary changes for staff release"
Thu, Mar 20, 7:38 PM
ashoat added a reverting change for rCOMMb558664e2a98: [native] Temporary changes for staff release: rCOMM5c3ef7ff9a58: Revert "[native] Temporary changes for staff release".
Thu, Mar 20, 7:38 PM
ashoat committed rCOMM1544209a3f33: [native] codeVersion -> 472 (authored by ashoat).
[native] codeVersion -> 472
Thu, Mar 20, 7:38 PM
ashoat committed rCOMMb558664e2a98: [native] Temporary changes for staff release (authored by ashoat).
[native] Temporary changes for staff release
Thu, Mar 20, 7:38 PM
ashoat committed rCOMM66dd9528c6b0: [native] codeVersion -> 471 (authored by ashoat).
[native] codeVersion -> 471
Thu, Mar 20, 7:38 PM
ashoat committed rCOMM4487b875a5af: [web][keyserver] codeVersion -> 158 (authored by ashoat).
[web][keyserver] codeVersion -> 158
Thu, Mar 20, 7:38 PM
ashoat committed rCOMM5a8d986f80ec: CLAUDE.md config for Claude Code (authored by ashoat).
CLAUDE.md config for Claude Code
Thu, Mar 20, 7:23 PM
kamil closed D11243: [CI] Clean on failure for Emscripten pipeline.
Thu, Mar 20, 6:24 AM
kamil committed rCOMM18922ade93a1: [CI] Clean on failure for Emscripten pipeline (authored by kamil).
[CI] Clean on failure for Emscripten pipeline
Thu, Mar 20, 6:24 AM
kamil closed D14483: [web] clear old Olm session before creating new one.
Thu, Mar 20, 6:21 AM
kamil closed D14482: [web] clear old `cryptoStore` before creating new one.
Thu, Mar 20, 6:21 AM
kamil committed rCOMM04a40fae36f0: [web] clear old Olm session before creating new one (authored by kamil).
[web] clear old Olm session before creating new one
Thu, Mar 20, 6:21 AM
kamil committed rCOMM941b4e92c37c: [web] clear old `cryptoStore` before creating new one (authored by kamil).
[web] clear old `cryptoStore` before creating new one
Thu, Mar 20, 6:21 AM
kamil closed D14485: [web][keyserver] log Olm memory usage changes.
Thu, Mar 20, 6:21 AM
kamil closed D14464: [keyserver] call `free()` on Olm objects in finally block.
Thu, Mar 20, 6:21 AM
kamil committed rCOMM993689cd4a3d: [web][keyserver] log Olm memory usage changes (authored by kamil).
[web][keyserver] log Olm memory usage changes
Thu, Mar 20, 6:21 AM
kamil committed rCOMM4765e9c616eb: [keyserver] call `free()` on Olm objects in finally block (authored by kamil).
[keyserver] call `free()` on Olm objects in finally block
Thu, Mar 20, 6:21 AM
kamil closed D14484: [dependencies] bump Olm version to `0.2.3`.
Thu, Mar 20, 6:21 AM
kamil committed rCOMMab05ac387435: [dependencies] bump Olm version to `0.2.3` (authored by kamil).
[dependencies] bump Olm version to `0.2.3`
Thu, Mar 20, 6:21 AM
kamil added inline comments to D11243: [CI] Clean on failure for Emscripten pipeline.
Thu, Mar 20, 6:01 AM
ashoat accepted D11243: [CI] Clean on failure for Emscripten pipeline.
Thu, Mar 20, 5:59 AM
kamil updated the diff for D14485: [web][keyserver] log Olm memory usage changes.

fix typos

Thu, Mar 20, 5:59 AM
angelika published D14481: [native] Remove ffmpeg dependency for review.
Thu, Mar 20, 5:57 AM
angelika published D14480: [native] Use transcodeVideo() from MediaModule instead of ffmpeg for review.
Thu, Mar 20, 5:57 AM
angelika published D14479: [ios] Implement transcodeVideo() function on iOS for review.
Thu, Mar 20, 5:57 AM
angelika published D14478: [android] Implement transcodeVideo() function on Android for review.
Thu, Mar 20, 5:57 AM
angelika published D14477: [native] Use generateThumbnail() from MediaModule instead of ffmpeg for review.
Thu, Mar 20, 5:57 AM
angelika published D14476: [ios] Implement generateThumbnail() function on iOS for review.
Thu, Mar 20, 5:56 AM
angelika published D14475: [android] Implement generateThumbnail() function on Android for review.
Thu, Mar 20, 5:56 AM
kamil added reviewers for D11243: [CI] Clean on failure for Emscripten pipeline: tomek, bartek.
Thu, Mar 20, 5:56 AM
angelika published D14474: [native] Use hasMultipleFrames() from MediaModule instead of ffmpeg for review.
Thu, Mar 20, 5:56 AM
kamil added a comment to D11243: [CI] Clean on failure for Emscripten pipeline.

Publishing this a potential fix for ENG-10380

Thu, Mar 20, 5:56 AM
angelika published D14473: [ios] Implement hasMultipleFrames() function on iOS for review.
Thu, Mar 20, 5:56 AM
angelika published D14472: [android] Implement hasMultipleFrames() function on Android for review.
Thu, Mar 20, 5:56 AM
angelika published D14471: [native] Use getVideoInfo from MediaModule instead of ffmpeg for review.
Thu, Mar 20, 5:55 AM
angelika published D14470: [ios] Implement getVideoInfo() function on iOS for review.
Thu, Mar 20, 5:55 AM
Next