Page MenuHomePhabricator
Feed All Stories

Today

ashoat added a comment to D9265: [lib/web/native] Add IntegrityStore.

Do you mean just blocking until all hashes are complete (like it is currently) or something smarter (e.g. we send a request to the server to delay the state check)?

Sat, Sep 23, 12:44 PM

Yesterday

ginsu requested review of D9271: [native] improve organization of user profiles work.
Fri, Sep 22, 2:22 PM
ginsu updated the summary of D9261: [native] introduce useNavigateToUserProfileBottomSheet hook.
Fri, Sep 22, 2:07 PM
ginsu planned changes to D9261: [native] introduce useNavigateToUserProfileBottomSheet hook.

changing stack order/will need to rebase

Fri, Sep 22, 1:43 PM
ginsu attached a referenced file: F770513: Screenshot 2023-09-22 at 4.34.33 PM.png.
Fri, Sep 22, 1:36 PM
ginsu updated the summary of D9252: [native] introduce UserProfileMessageButton.
Fri, Sep 22, 1:35 PM
rohan updated the diff for D9249: [lib] Extend RobotextParams to include parentThreadInfo.

Pass in null parameter from non-problematic call sites
(notifRobotextForMessageInfo and getMessageTitle)

Fri, Sep 22, 1:35 PM
rohan added inline comments to D9249: [lib] Extend RobotextParams to include parentThreadInfo.
Fri, Sep 22, 1:34 PM
ginsu attached a referenced file: F770483: Screenshot 2023-09-22 at 4.25.11 PM.png.
Fri, Sep 22, 1:33 PM
ginsu updated the summary of D9258: [native] introduce UserProfileRelationshipButton.
Fri, Sep 22, 1:33 PM
varun requested review of D9270: [native] update password client method and CommRustModule implementation.
Fri, Sep 22, 1:24 PM
ginsu attached a referenced file: F770478: Screenshot 2023-09-22 at 4.15.11 PM.png.
Fri, Sep 22, 1:23 PM
ginsu updated the test plan for D9258: [native] introduce UserProfileRelationshipButton.
Fri, Sep 22, 1:23 PM
varun requested review of D9269: [native] helper functions for resolving JS promises with void.
Fri, Sep 22, 1:23 PM
ginsu added inline comments to D9258: [native] introduce UserProfileRelationshipButton.
Fri, Sep 22, 1:22 PM
ginsu updated the diff for D9258: [native] introduce UserProfileRelationshipButton.

rebase

Fri, Sep 22, 1:17 PM
ginsu attached a referenced file: F770444: Screenshot 2023-09-22 at 4.15.11 PM.png.
Fri, Sep 22, 1:16 PM
ginsu updated the test plan for D9252: [native] introduce UserProfileMessageButton.
Fri, Sep 22, 1:15 PM
ginsu added inline comments to D9252: [native] introduce UserProfileMessageButton.
Fri, Sep 22, 1:14 PM
ginsu updated the diff for D9252: [native] introduce UserProfileMessageButton.

we should also not show message button if the user and/or viewer is blocked

Fri, Sep 22, 1:12 PM
varun closed D9264: [keyserver] use correct key for device ID.
Fri, Sep 22, 8:21 AM
varun committed rCOMM2b0757b8e34b: [keyserver] use correct key for device ID (authored by varun).
[keyserver] use correct key for device ID
Fri, Sep 22, 8:21 AM
rohan closed D9220: [keyserver] Encode the device id into the QR code.
Fri, Sep 22, 8:15 AM
rohan committed rCOMMefc194158d4f: [keyserver] Encode the device id into the QR code (authored by rohan).
[keyserver] Encode the device id into the QR code
Fri, Sep 22, 8:15 AM
michal accepted D9246: [native][web] Fix keyserver store tranform error.

Is my understanding correct that there is still a toplevel connection field in redux state? Should we remove it inside of this migration?

Fri, Sep 22, 8:13 AM
inka accepted D9254: [lib] Add unit tests for mention utils.
Fri, Sep 22, 7:55 AM
inka accepted D9218: [keyserver] Render raw chat mention in the notification text.
Fri, Sep 22, 7:49 AM
patryk updated the diff for D9057: [web] Add webMentionTypeaheadRegex tests.

Simplify test cases

Fri, Sep 22, 7:44 AM
inka accepted D9005: [lib] Introduce chat mention utilities for plain text.

Important context in D9007 - we just want to use the alt text for now

Fri, Sep 22, 7:43 AM
rohan closed D9202: [keyserver/web/native] Covert AES-256 key from Uint8Array representation to hex string representation.
Fri, Sep 22, 7:40 AM
rohan committed rCOMM9a08fd6f2883: [keyserver/web/native] Covert AES-256 key from Uint8Array representation to hex… (authored by rohan).
[keyserver/web/native] Covert AES-256 key from Uint8Array representation to hex…
Fri, Sep 22, 7:40 AM
rohan closed D9181: [keyserver] Generate an AES256 key (ephemeral) to encode.
Fri, Sep 22, 7:40 AM
rohan committed rCOMM1470feaff259: [keyserver] Generate an AES256 key (ephemeral) to encode (authored by rohan).
[keyserver] Generate an AES256 key (ephemeral) to encode
Fri, Sep 22, 7:40 AM
rohan added a comment to D9264: [keyserver] use correct key for device ID.

Sorry, could you actually rebase and use the renamed function getContentSigningKey (I just updated D9220)?

Fri, Sep 22, 7:35 AM
rohan updated the diff for D9220: [keyserver] Encode the device id into the QR code.

Rename getContentPublicKey -> getContentSigningKey and
contentPublicKey -> contentSigningKey

Fri, Sep 22, 7:34 AM
inka accepted D8944: [web] Modify mention typeahead regex.
Fri, Sep 22, 7:32 AM
inka added a comment to D9057: [web] Add webMentionTypeaheadRegex tests.

You could remove the text field and just do textPrefix + mentionText

Fri, Sep 22, 7:32 AM
rohan accepted D9264: [keyserver] use correct key for device ID.
Fri, Sep 22, 7:31 AM
patryk added a comment to D8944: [web] Modify mention typeahead regex.

D9057

Fri, Sep 22, 7:29 AM
kamil accepted D9224: [native] commCoreModule methods for getting, setting, and clearing the commServicesAccessToken.

Accepting to unblock, but please look at my comment about moving clearance code to DatabaseManager::clearSensitiveData()

Fri, Sep 22, 7:27 AM
inka accepted D8901: [lib] Add userStoreMentionSearchIndex selector.
Fri, Sep 22, 7:20 AM
tomek requested review of D9268: [lib] Move current user updates logic into a spec.
Fri, Sep 22, 6:56 AM
michal added a comment to D9265: [lib/web/native] Add IntegrityStore.

I also tested another idea: let's do all "batch hashing" (where we hash all items of a store) on the keyserver side. So during login the keyserver would send client all thread hashes. The client would only update the hashes during thread ops. That means we should optimise the keyserver-side calculations, so we should do the schema conversion on the client. I tested it and got:

  • Do the hashing (without conversion) on the keyserver during login => I got ~0.5s for 7300 threads
  • From previous testing: updating one hash with conversion on native should take about ~10ms, but it should be a few threads at most at one time
Fri, Sep 22, 6:49 AM
inka accepted D9057: [web] Add webMentionTypeaheadRegex tests.
Fri, Sep 22, 6:45 AM
inka accepted D8834: [lib] Introduce chat mention match and parse utilities.
Fri, Sep 22, 6:25 AM
michal requested review of D9267: [keyserver] Add new hashing to keyserver state check.
Fri, Sep 22, 6:20 AM
ashoat added a comment to D9265: [lib/web/native] Add IntegrityStore.

iOS emulator takes about 1ms per one thread and the speed should be O(n). In the case from the linear task where the state check took 53s, there was about 2000 threads, so logging in would take additional 2s

Fri, Sep 22, 5:48 AM
michal requested review of D9266: [lib/keyserver] Make Info generic mandatory in state sync specs.
Fri, Sep 22, 4:05 AM
michal requested review of D9265: [lib/web/native] Add IntegrityStore.
Fri, Sep 22, 4:03 AM
michal added a comment to D9256: [web/native] Add threadHashes to threadStore.

Alternative approach in D9265

Fri, Sep 22, 3:46 AM
michal added a comment to D9255: [native] Use threadInfo in setClientDBStoreActionType.

Alternative approach in D9265

Fri, Sep 22, 3:46 AM
tomek accepted D9253: [lib/keyserver] Improve state sync types.
Fri, Sep 22, 3:24 AM
michal planned changes to D9256: [web/native] Add threadHashes to threadStore.
Fri, Sep 22, 3:07 AM
michal planned changes to D9255: [native] Use threadInfo in setClientDBStoreActionType.
Fri, Sep 22, 3:07 AM
michal added a comment to D9262: [lib] Add `ThreadActivityStore` to Redux.

Yeah, you are correct. Basically if the value you would add previously put in website-responders is:

  • some default value than it should go to web/redux/default-state
  • value calculated on the keyserver than it should go in getInitialReduxStateResponder (+ some dummy default in default-state so flow doesn't complain)
Fri, Sep 22, 1:03 AM
varun requested review of D9264: [keyserver] use correct key for device ID.
Fri, Sep 22, 12:18 AM

Thu, Sep 21

ginsu updated the diff for D9258: [native] introduce UserProfileRelationshipButton.

fix icon

Thu, Sep 21, 8:43 PM
ashoat accepted D9262: [lib] Add `ThreadActivityStore` to Redux.
In D9262#272510, @atul wrote:

In the past, we would need to update websites-responders.js when adding a new field to Redux state. Now that Redux state for the web is fetched via an API call, is there a different place we should be updating?

Based on my reading of https://phab.comm.dev/D9145, the "new place" is web/redux/default-state.js which I did update in this diff.

Thu, Sep 21, 7:01 PM
atul added inline comments to D9262: [lib] Add `ThreadActivityStore` to Redux.
Thu, Sep 21, 2:37 PM
atul updated the diff for D9262: [lib] Add `ThreadActivityStore` to Redux.

fix

Thu, Sep 21, 2:33 PM
atul updated the diff for D9262: [lib] Add `ThreadActivityStore` to Redux.

address feedback

Thu, Sep 21, 2:30 PM
atul added a comment to D9262: [lib] Add `ThreadActivityStore` to Redux.

In the past, we would need to update websites-responders.js when adding a new field to Redux state. Now that Redux state for the web is fetched via an API call, is there a different place we should be updating?

Thu, Sep 21, 2:22 PM
ashoat requested changes to D9262: [lib] Add `ThreadActivityStore` to Redux.

In the past, we would need to update websites-responders.js when adding a new field to Redux state. Now that Redux state for the web is fetched via an API call, is there a different place we should be updating?

Thu, Sep 21, 2:14 PM
atul published D9262: [lib] Add `ThreadActivityStore` to Redux for review.
Thu, Sep 21, 1:58 PM
ginsu closed D9204: [lib] introduce threadInfosSelectorForThreadType selector.
Thu, Sep 21, 1:45 PM
ginsu committed rCOMM9e4fe445626b: [lib] introduce threadInfosSelectorForThreadType selector (authored by ginsu).
[lib] introduce threadInfosSelectorForThreadType selector
Thu, Sep 21, 1:45 PM
ginsu closed D9235: [lib] introduce createPendingPersonalThread function.
Thu, Sep 21, 1:45 PM
ginsu committed rCOMM37a9f269f73e: [lib] introduce createPendingPersonalThread function (authored by ginsu).
[lib] introduce createPendingPersonalThread function
Thu, Sep 21, 1:45 PM
ginsu updated the diff for D9204: [lib] introduce threadInfosSelectorForThreadType selector.

rebase before landing

Thu, Sep 21, 1:42 PM
ginsu updated the diff for D9235: [lib] introduce createPendingPersonalThread function.

rebase before landing

Thu, Sep 21, 1:41 PM
ginsu closed D9223: [nix] add logs to console while waiting for MariaDB to come up.
Thu, Sep 21, 1:37 PM
ginsu committed rCOMM0bdf8c8da1a4: [nix] add logs to console while waiting for MariaDB to come up (authored by ginsu).
[nix] add logs to console while waiting for MariaDB to come up
Thu, Sep 21, 1:37 PM
ashoat accepted D9223: [nix] add logs to console while waiting for MariaDB to come up.
Thu, Sep 21, 1:01 PM
ashoat accepted D9235: [lib] introduce createPendingPersonalThread function.
Thu, Sep 21, 1:00 PM
ginsu requested review of D9261: [native] introduce useNavigateToUserProfileBottomSheet hook.
Thu, Sep 21, 12:18 PM
varun accepted D9223: [nix] add logs to console while waiting for MariaDB to come up.
Thu, Sep 21, 12:01 PM
ginsu updated the summary of D9260: [native] improve BottomSheet component close function.
Thu, Sep 21, 12:00 PM
varun accepted D9220: [keyserver] Encode the device id into the QR code.

thank you! one comment inline

Thu, Sep 21, 11:57 AM
ginsu requested review of D9260: [native] improve BottomSheet component close function.
Thu, Sep 21, 11:45 AM
ginsu attached a referenced file: F769080: Screenshot 2023-09-21 at 2.03.59 PM.png.
Thu, Sep 21, 11:15 AM
ginsu attached a referenced file: F769081: Screenshot 2023-09-21 at 2.02.28 PM.png.
Thu, Sep 21, 11:15 AM
ginsu attached a referenced file: F769082: Screenshot 2023-09-21 at 2.04.07 PM.png.
Thu, Sep 21, 11:15 AM
ginsu attached a referenced file: F769112: Screen Recording 2023-09-21 at 2.10.10 PM.mov.
Thu, Sep 21, 11:15 AM
ginsu attached a referenced file: F769113: Screen Recording 2023-09-21 at 2.11.46 PM.mov.
Thu, Sep 21, 11:15 AM
ginsu attached a referenced file: F769117: Screenshot 2023-09-20 at 4.49.07 PM.png.
Thu, Sep 21, 11:15 AM
ginsu updated the test plan for D9258: [native] introduce UserProfileRelationshipButton.
Thu, Sep 21, 11:15 AM
ginsu updated subscribers of D9258: [native] introduce UserProfileRelationshipButton.
Thu, Sep 21, 11:14 AM
ginsu requested review of D9258: [native] introduce UserProfileRelationshipButton.
Thu, Sep 21, 11:14 AM
atul updated the diff for D9227: [patch] Patch `expo-modules-core` to unblock iOS build on macOS Sonoma.

rebase

Thu, Sep 21, 10:55 AM
ginsu requested review of D9235: [lib] introduce createPendingPersonalThread function.
Thu, Sep 21, 10:41 AM
rohan closed D9180: [keyserver] Print out a QR code to the terminal.
Thu, Sep 21, 10:21 AM
rohan committed rCOMM5842359feb58: [keyserver] Print out a QR code to the terminal (authored by rohan).
[keyserver] Print out a QR code to the terminal
Thu, Sep 21, 10:21 AM
ginsu updated the diff for D9223: [nix] add logs to console while waiting for MariaDB to come up.

simplify/address comments

Thu, Sep 21, 10:07 AM
ginsu closed D9203: [web] introduce AppearanceChangeModal.
Thu, Sep 21, 9:52 AM
ginsu committed rCOMM57caceed7b27: [web] introduce AppearanceChangeModal (authored by ginsu).
[web] introduce AppearanceChangeModal
Thu, Sep 21, 9:52 AM
ginsu closed D9120: [native] update UserProfileBottomSheet to get a userInfo from a userID.
Thu, Sep 21, 9:51 AM
ginsu committed rCOMM10935364caf9: [native] update UserProfileBottomSheet to get a userInfo from a userID (authored by ginsu).
[native] update UserProfileBottomSheet to get a userInfo from a userID
Thu, Sep 21, 9:51 AM
ashoat closed D9251: [keyserver] Remove unused exports in message-fetchers.js.
Thu, Sep 21, 9:02 AM
ashoat committed rCOMMa301a42f0654: [keyserver] Remove unused exports in message-fetchers.js (authored by ashoat).
[keyserver] Remove unused exports in message-fetchers.js
Thu, Sep 21, 9:01 AM
rohan added inline comments to D9249: [lib] Extend RobotextParams to include parentThreadInfo.
Thu, Sep 21, 8:54 AM