address feedback
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Jul 25 2024
Jul 25 2024
varun updated the diff for D12805: [lib] introduce new device list function to replace keyserver device.
will committed rCOMM200062e6eea2: [identity] downgrade no auth message error to warning (authored by will).
[identity] downgrade no auth message error to warning
will committed rCOMMf4fceed7f2ba: [terraform] Update terraform.tfvars.example and use json format (authored by will).
[terraform] Update terraform.tfvars.example and use json format
will committed rCOMMc8b96f13ef8f: [terraform] Making user created vpc false by default (authored by will).
[terraform] Making user created vpc false by default
will committed rCOMMfe8af3b57b72: [terraform] create separate lb security groups for landing and web (authored by will).
[terraform] create separate lb security groups for landing and web
will committed rCOMM45876077b05e: [terraform] up maximum deployment and minimum deployment percents (authored by will).
[terraform] up maximum deployment and minimum deployment percents
rebase
In D12623#357165, @bartek wrote:This was triggered recently and might've been a websocket health check or something related.
It's worth checking if clients aren't broken and they do send the message
will updated the diff for D12875: [terraform] create separate lb security groups for landing and web.
rebase
will committed rCOMM6b04b56d9534: [web] Fixes the emscripten CI build by allowing curl redirects (authored by will).
[web] Fixes the emscripten CI build by allowing curl redirects
Harbormaster failed remote builds in B30675: Diff 42780 for D12673: Utilities to idempotently create content and notif sessions!
Harbormaster failed remote builds in B30674: Diff 42778 for D12672: Implement utility functions to check if we have content or notif session with device!
- Use query to check notifications session for multiple devices at once and initilize crypto account in send utils instead of each time before encryption. it is huge performance improvement.
- Fix context cycle
will committed rCOMM3a325b4a239f: [lib] remove integrity store assertion and use sqlite (authored by will).
[lib] remove integrity store assertion and use sqlite
marcin updated the diff for D12672: Implement utility functions to check if we have content or notif session with device.
Add additional method to check for presence of notifications session for multiple devices with one db query
Harbormaster failed remote builds in B30673: Diff 42777 for D12875: [terraform] create separate lb security groups for landing and web!
will updated the diff for D12875: [terraform] create separate lb security groups for landing and web.
rebase
Harbormaster failed remote builds in B30668: Diff 42772 for D12875: [terraform] create separate lb security groups for landing and web!
Overall idea looks okay, I am afraid about performance but I don't think there is a better alternative for now.
will updated the diff for D12875: [terraform] create separate lb security groups for landing and web.
update descriptions for landing and webapp security groups
will added inline comments to D12875: [terraform] create separate lb security groups for landing and web.
kamil added inline comments to D12836: Patch localforage to support transactional multiple items retrieval/persistence.
I totally forgot that tfvars can be in JSON format 😅
In D12866#364118, @tomek wrote:Have you tested it on both platforms?
Rebase
Rebase
Address review
[CommCoreModule] remove `T[]` syntax
inka added inline comments to D12865: [keyserver][lib][web][native] use local search for thick threads.
Address review
[lib] improve naming in Tunnelbroker socket
kamil committed rCOMMc6013fa49f0d: [lib] remove unused Tunnelbroker message validators (authored by kamil).
[lib] remove unused Tunnelbroker message validators
kamil committed rCOMM46915f332915: [Tunnelbroker][lib] cleanup Device <-> Tunnelbroker message types (authored by kamil).
[Tunnelbroker][lib] cleanup Device <-> Tunnelbroker message types
In D12857#364153, @tomek wrote:I'd prefer to also validate on the JS side, but it isn't a strong opinion.
address review
kamil updated the diff for D12856: [Tunnelbroker][lib] cleanup Device <-> Tunnelbroker message types.
use deviceToTunnelbroker
inka added inline comments to D12865: [keyserver][lib][web][native] use local search for thick threads.
Thanks for fixing it!
Jul 24 2024
Jul 24 2024
review feedback and rebase
will requested review of D12875: [terraform] create separate lb security groups for landing and web.
will committed rCOMMbec3fcefbe5c: [terraform] move image config to aws_ecs and add custom image variable (authored by will).
[terraform] move image config to aws_ecs and add custom image variable
will committed rCOMMdb7d3c76c3e2: [terraform] Rename `aws_ecs` to `keyserver_cluster` and move shared security… (authored by will).
[terraform] Rename `aws_ecs` to `keyserver_cluster` and move shared security…
will committed rCOMMec09585a102e: [terraform] update variables.tf self-host descriptions (authored by will).
[terraform] update variables.tf self-host descriptions
will committed rCOMMbcf60c546342: [terraform] Actually use db_instance_class for mariadb (authored by will).
[terraform] Actually use db_instance_class for mariadb
will updated the diff for D12863: [terraform] move image config to aws_ecs and add custom image variable.
rebase
Rebase