Page MenuHomePhabricator
Differential D12860

[CommCoreModule] remove `T[]` syntax
ClosedPublic
Actions

Authored by kamil on Jul 23 2024, 8:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 15, 7:22 PM
Unknown Object (File)
Thu, Mar 6, 4:16 PM
Unknown Object (File)
Thu, Mar 6, 1:27 PM
Unknown Object (File)
Feb 21 2025, 3:33 AM
Unknown Object (File)
Feb 21 2025, 3:33 AM
Unknown Object (File)
Feb 21 2025, 3:32 AM
Unknown Object (File)
Feb 21 2025, 3:32 AM
Unknown Object (File)
Jan 21 2025, 11:06 PM
View All 61 Files
Subscribers
ashoat

Details

Reviewers
tomek
inka
Commits
rCOMMf9ee4c4783ab: [CommCoreModule] remove `T[]` syntax
Summary

Addresses: https://phab.comm.dev/D12853#inline-74580

Test Plan
  1. Flow
  2. codegen-jsi cause no changes

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
native/
schema/
10 lines

Diff 42768

View Options

native/schema/CommCoreModuleSchema.js

Show First 20 Lines • Show All 42 Lines • ▼ Show 20 Lines
import { setNativeCredentials } from './native-credentials.js'; import { setNativeCredentials } from './native-credentials.js';
import { PanelButton, Panel } from './panel-components.react.js'; import { PanelButton, Panel } from './panel-components.react.js';
import { authoritativeKeyserverID } from '../authoritative-keyserver.js'; import { authoritativeKeyserverID } from '../authoritative-keyserver.js';
import SWMansionIcon from '../components/swmansion-icon.react.js'; import SWMansionIcon from '../components/swmansion-icon.react.js';
import { useSelector } from '../redux/redux-utils.js'; import { useSelector } from '../redux/redux-utils.js';
import { nativeLegacyLogInExtraInfoSelector } from '../selectors/account-selectors.js'; import { nativeLegacyLogInExtraInfoSelector } from '../selectors/account-selectors.js';
import type { KeyPressEvent } from '../types/react-native.js'; import type { KeyPressEvent } from '../types/react-native.js';
import { import {
AppOutOfDateAlertDetails, appOutOfDateAlertDetails,
UsernameReservedAlertDetails, usernameReservedAlertDetails,
UsernameTakenAlertDetails, usernameTakenAlertDetails,
UnknownErrorAlertDetails, unknownErrorAlertDetails,
} from '../utils/alert-messages.js'; } from '../utils/alert-messages.js';
import Alert from '../utils/alert.js'; import Alert from '../utils/alert.js';
import { type StateContainer } from '../utils/state-container.js'; import { type StateContainer } from '../utils/state-container.js';
type WritableLegacyRegisterState = { type WritableLegacyRegisterState = {
usernameInputText: string, usernameInputText: string,
passwordInputText: string, passwordInputText: string,
confirmPasswordInputText: string, confirmPasswordInputText: string,
▲ Show 20 Lines • Show All 310 Lines • ▼ Show 20 Lines try {
await setNativeCredentials({ await setNativeCredentials({
username: result.currentUserInfo.username, username: result.currentUserInfo.username,
password: this.props.legacyRegisterState.state.passwordInputText, password: this.props.legacyRegisterState.state.passwordInputText,
}); });
return result; return result;
} catch (e) { } catch (e) {
if (e.message === 'username_reserved') { if (e.message === 'username_reserved') {
Alert.alert( Alert.alert(
UsernameReservedAlertDetails.title, usernameReservedAlertDetails.title,
UsernameReservedAlertDetails.message, usernameReservedAlertDetails.message,
[{ text: 'OK', onPress: this.onUsernameAlertAcknowledged }], [{ text: 'OK', onPress: this.onUsernameAlertAcknowledged }],
{ cancelable: false }, { cancelable: false },
); );
} else if (e.message === 'username_taken') { } else if (e.message === 'username_taken') {
Alert.alert( Alert.alert(
UsernameTakenAlertDetails.title, usernameTakenAlertDetails.title,
UsernameTakenAlertDetails.message, usernameTakenAlertDetails.message,
[{ text: 'OK', onPress: this.onUsernameAlertAcknowledged }], [{ text: 'OK', onPress: this.onUsernameAlertAcknowledged }],
{ cancelable: false }, { cancelable: false },
); );
} else if (e.message === 'client_version_unsupported') { } else if (e.message === 'client_version_unsupported') {
Alert.alert( Alert.alert(
AppOutOfDateAlertDetails.title, appOutOfDateAlertDetails.title,
AppOutOfDateAlertDetails.message, appOutOfDateAlertDetails.message,
[{ text: 'OK', onPress: this.onAppOutOfDateAlertAcknowledged }], [{ text: 'OK', onPress: this.onAppOutOfDateAlertAcknowledged }],
{ cancelable: false }, { cancelable: false },
); );
} else { } else {
Alert.alert( Alert.alert(
UnknownErrorAlertDetails.title, unknownErrorAlertDetails.title,
UnknownErrorAlertDetails.message, unknownErrorAlertDetails.message,
[{ text: 'OK', onPress: this.onUnknownErrorAlertAcknowledged }], [{ text: 'OK', onPress: this.onUnknownErrorAlertAcknowledged }],
{ cancelable: false }, { cancelable: false },
); );
} }
throw e; throw e;
} }
} }
▲ Show 20 Lines • Show All 110 Lines • Show Last 20 Lines