[lib] introduce new device list function to replace keyserver device
ClosedPublic
Actions

Authored by varun on Jul 19 2024, 12:52 PM.

Details

Reviewers

bartek
ashoat

Commits

rCOMMc65be4f84cff: [lib] introduce new device list function to replace keyserver device

Summary

we want to be able to replace an existing keyserver with a new one

Depends on D12734

Test Plan

later in the diff stack I successfully replace my existing keyserver device with a new one

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Jul 19 2024, 12:52 PM

Herald added a subscriber: tomek. · View Herald TranscriptJul 19 2024, 12:52 PM

Harbormaster completed remote builds in B30515: Diff 42550.Jul 19 2024, 1:09 PM

varun requested review of this revision.Jul 19 2024, 1:09 PM

varun added a child revision: D12809: [lib] add new selector and function to get own user's keyserver device ID.Jul 19 2024, 2:18 PM

bartek requested changes to this revision.Jul 22 2024, 1:36 AM

bartek added inline comments.

lib/shared/device-list-utils.js
236–240 ↗	(On Diff #42550)	What if the old device is not on the list, but the new one is not? I think we should continue adding it in that case. Otherwise, this function would return successfully without the device list being updated

This revision now requires changes to proceed.Jul 22 2024, 1:36 AM

address feedback

Harbormaster completed remote builds in B30681: Diff 42792.Jul 25 2024, 8:53 PM

bartek accepted this revision.Jul 26 2024, 1:56 AM

This revision is now accepted and ready to land.Jul 26 2024, 1:56 AM

Closed by commit rCOMMc65be4f84cff: [lib] introduce new device list function to replace keyserver device (authored by varun). · Explain WhyAug 22 2024, 9:24 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMMc65be4f84cff: [lib] introduce new device list function to replace keyserver device.

Revision Contents
Changeset List

Path

Size

lib/

shared/

device-list-utils.js

30 lines

Diff 43575

View Options

lib/shared/device-list-utils.js

	Show All 25 Lines
	import type { ClientDBMessageInfo } from 'lib/types/message-types.js';			import type { ClientDBMessageInfo } from 'lib/types/message-types.js';
	import { cookieTypes } from 'lib/types/session-types.js';			import { cookieTypes } from 'lib/types/session-types.js';
	import { defaultConnectionInfo } from 'lib/types/socket-types.js';			import { defaultConnectionInfo } from 'lib/types/socket-types.js';
	import { defaultGlobalThemeInfo } from 'lib/types/theme-types.js';			import { defaultGlobalThemeInfo } from 'lib/types/theme-types.js';
	import type { ClientDBThreadInfo } from 'lib/types/thread-types.js';			import type { ClientDBThreadInfo } from 'lib/types/thread-types.js';
	import { getConfig } from 'lib/utils/config.js';			import { getConfig } from 'lib/utils/config.js';
	import { parseCookies } from 'lib/utils/cookie-utils.js';			import { parseCookies } from 'lib/utils/cookie-utils.js';
	import { isDev } from 'lib/utils/dev-utils.js';			import { isDev } from 'lib/utils/dev-utils.js';
	import { wipeKeyserverStore } from 'lib/utils/keyserver-store-utils.js';
	import {			import {
	generateIDSchemaMigrationOpsForDrafts,			generateIDSchemaMigrationOpsForDrafts,
	convertDraftStoreToNewIDSchema,			convertDraftStoreToNewIDSchema,
	} from 'lib/utils/migration-utils.js';			} from 'lib/utils/migration-utils.js';
	import { entries } from 'lib/utils/objects.js';			import { entries } from 'lib/utils/objects.js';
	import { resetUserSpecificState } from 'lib/utils/reducers-utils.js';
	import {			import {
	convertClientDBThreadInfoToRawThreadInfo,			convertClientDBThreadInfoToRawThreadInfo,
	convertRawThreadInfoToClientDBThreadInfo,			convertRawThreadInfoToClientDBThreadInfo,
	} from 'lib/utils/thread-ops-utils.js';			} from 'lib/utils/thread-ops-utils.js';

	import commReduxStorageEngine from './comm-redux-storage-engine.js';			import commReduxStorageEngine from './comm-redux-storage-engine.js';
	import { defaultWebState } from './default-state.js';			import {
				handleReduxMigrationFailure,
				persistWhitelist,
				} from './handle-redux-migration-failure.js';
	import { rootKey, rootKeyPrefix } from './persist-constants.js';			import { rootKey, rootKeyPrefix } from './persist-constants.js';
	import type { AppState } from './redux-setup.js';			import type { AppState } from './redux-setup.js';
	import { nonUserSpecificFieldsWeb } from './redux-setup.js';
	import { authoritativeKeyserverID } from '../authoritative-keyserver.js';			import { authoritativeKeyserverID } from '../authoritative-keyserver.js';
	import { getCommSharedWorker } from '../shared-worker/shared-worker-provider.js';			import { getCommSharedWorker } from '../shared-worker/shared-worker-provider.js';
	import { getOlmWasmPath } from '../shared-worker/utils/constants.js';			import { getOlmWasmPath } from '../shared-worker/utils/constants.js';
	import { isSQLiteSupported } from '../shared-worker/utils/db-utils.js';			import { isSQLiteSupported } from '../shared-worker/utils/db-utils.js';
	import { workerRequestMessageTypes } from '../types/worker-types.js';			import { workerRequestMessageTypes } from '../types/worker-types.js';

	declare var keyserverURL: string;			declare var keyserverURL: string;

	const persistWhitelist = [
	'enabledApps',
	'alertStore',
	'commServicesAccessToken',
	'keyserverStore',
	'globalThemeInfo',
	'customServer',
	'messageStore',
	];

	function handleReduxMigrationFailure(oldState: AppState): AppState {
	const persistedNonUserSpecificFields = nonUserSpecificFieldsWeb.filter(
	field => persistWhitelist.includes(field) \|\| field === '_persist',
	);
	const stateAfterReset = resetUserSpecificState(
	oldState,
	defaultWebState,
	persistedNonUserSpecificFields,
	);
	return {
	...stateAfterReset,
	keyserverStore: wipeKeyserverStore(stateAfterReset.keyserverStore),
	};
	}

	const migrations = {			const migrations = {
	[1]: async (state: any) => {			[1]: async (state: any) => {
	const {			const {
	primaryIdentityPublicKey,			primaryIdentityPublicKey,
	...stateWithoutPrimaryIdentityPublicKey			...stateWithoutPrimaryIdentityPublicKey
	} = state;			} = state;
	return {			return {
	...stateWithoutPrimaryIdentityPublicKey,			...stateWithoutPrimaryIdentityPublicKey,
	▲ Show 20 Lines • Show All 453 Lines • Show Last 20 Lines

[lib] introduce new device list function to replace keyserver deviceClosedPublicActions