Page MenuHomePhabricator
Differential D13125

[native] add ability to remove devices from linked devices bottom sheet
Needs RevisionPublic
Actions

Authored by varun on Tue, Aug 20, 10:11 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Sep 9, 5:39 AM
Unknown Object (File)
Sat, Sep 7, 2:18 PM
Unknown Object (File)
Sat, Sep 7, 2:17 PM
Unknown Object (File)
Tue, Sep 3, 11:59 PM
Unknown Object (File)
Mon, Sep 2, 7:06 PM
Unknown Object (File)
Sat, Aug 31, 3:48 PM
Unknown Object (File)
Thu, Aug 29, 7:12 PM
Unknown Object (File)
Wed, Aug 28, 1:46 PM
View All 25 Files
Subscribers
ashoat
tomek

Details

Reviewers
ashoat
tomek
bartek
Summary

Depends on D13038

Test Plan

successfully removed secondary devices

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Tue, Aug 20, 10:11 AM
varun held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptTue, Aug 20, 10:11 AM
varun edited the summary of this revision. (Show Details)Tue, Aug 20, 10:14 AM
varun added a parent revision: D13038: [lib] rename PrimaryDeviceLogout -> DeviceLogout.
Harbormaster completed remote builds in B31185: Diff 43525.Tue, Aug 20, 10:29 AM
varun updated this revision to Diff 43842.Mon, Sep 2, 7:18 PM

publish

varun published this revision for review.Mon, Sep 2, 7:19 PM
varun added reviewers: ashoat, tomek, bartek.
varun planned changes to this revision.Mon, Sep 2, 7:22 PM
varun edited the summary of this revision. (Show Details)
varun edited the test plan for this revision. (Show Details)
Harbormaster completed remote builds in B31396: Diff 43842.Mon, Sep 2, 7:39 PM
varun updated this revision to Diff 43944.Fri, Sep 6, 10:43 AM
varun edited the summary of this revision. (Show Details)

clean up

varun added a child revision: D13262: [native] only display remove device button if current device is primary device.Fri, Sep 6, 10:46 AM
Harbormaster completed remote builds in B31466: Diff 43944.Fri, Sep 6, 11:01 AM
bartek requested changes to this revision.Mon, Sep 9, 12:35 AM

Besides that one thing, device removal logic looks good

native/profile/linked-devices-bottom-sheet.react.js
94

We should broadcast the update also to own devices, except the one being removed:
https://github.com/CommE2E/comm/blob/8e5753f4104cf74a5256d7429c8948422695a9d8/lib/tunnelbroker/use-peer-to-peer-message-handler.js#L117

This revision now requires changes to proceed.Mon, Sep 9, 12:35 AM

Revision Contents
Changeset List

PathSize
native/
navigation/
3 lines
profile/
134 lines
5 lines

Diff 43944

View Options

native/navigation/route-names.js

Loading...
View Options

native/profile/linked-devices-bottom-sheet.react.js

Loading...
View Options

native/profile/linked-devices-list-item.react.js

Loading...