Page MenuHomePhabricator

[native] Get rid of bottomSheetPaddingTop in ConnectFarcasterBottomSheet
ClosedPublic

Authored by ashoat on Mon, Nov 4, 1:55 PM.
Tags
None
Referenced Files
F3332114: D13871.id45643.diff
Wed, Nov 20, 10:55 PM
F3323333: D13871.id.diff
Wed, Nov 20, 3:36 AM
Unknown Object (File)
Tue, Nov 19, 7:53 PM
Unknown Object (File)
Sat, Nov 16, 11:28 AM
Unknown Object (File)
Fri, Nov 15, 11:38 AM
Unknown Object (File)
Fri, Nov 15, 3:18 AM
Unknown Object (File)
Wed, Nov 13, 5:01 PM
Unknown Object (File)
Wed, Nov 13, 10:02 AM
Subscribers

Details

Summary

This padding was hardcoded by Ginsu to add additional space at the bottom of the BottomSheet. It is obviated by my work to consider BottomSheetHandle when setting snapPoints.

The padding was extra large because Ginsu measured the height of the button incorrectly. Once I adjusted the height of button, the padding is approximately the same as what it was before.

Depends on D13870

Test Plan

In combination with the rest of the stack, I tested each individual use of our BottomSheet component to make sure that the bottom padding was reasonable. In most cases it was unchanged; in other cases, it was changed to be more consistent with the other BottomSheets in our codebase. In all cases, there was enough padding for the "home pill" at the bottom of the screen

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable