Differential D13035

[lib] rename getForeignPeerDevices -> getForeignPeerDeviceIDs
ClosedPublic
Actions

Authored by varun on Aug 9 2024, 6:32 PM.

Details

Reviewers

ashoat

Commits

rCOMM4679fd50c9c8: [lib] rename getForeignPeerDevices -> getForeignPeerDeviceIDs

Summary

we only return the device IDs from this function, so renaming to make that more clear

Addressing feedback left in D12809

Depends on D12809

Test Plan

rename, so just ran flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Aug 9 2024, 6:32 PM

Herald added a subscriber: tomek. · View Herald TranscriptAug 9 2024, 6:32 PM

Harbormaster completed remote builds in B31022: Diff 43274.Aug 9 2024, 6:49 PM

varun requested review of this revision.Aug 9 2024, 6:49 PM

Thanks for doing this!

This revision is now accepted and ready to land.Aug 10 2024, 9:45 PM

Closed by commit rCOMM4679fd50c9c8: [lib] rename getForeignPeerDevices -> getForeignPeerDeviceIDs. · Explain WhyAug 22 2024, 4:24 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM4679fd50c9c8: [lib] rename getForeignPeerDevices -> getForeignPeerDeviceIDs.

Revision Contents
Changeset List

Path

Size

lib/

actions/

user-actions.js

4 lines

selectors/

user-selectors.js

36 lines

tunnelbroker/

use-peer-to-peer-message-handler.js

4 lines

native/

profile/

secondary-device-qr-code-scanner.react.js

4 lines

Diff 43577

View Options

lib/actions/user-actions.js

View Options

lib/selectors/user-selectors.js

View Options

lib/tunnelbroker/use-peer-to-peer-message-handler.js

View Options

native/profile/secondary-device-qr-code-scanner.react.js

[lib] rename getForeignPeerDevices -> getForeignPeerDeviceIDsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 43577

lib/actions/user-actions.js

lib/selectors/user-selectors.js

lib/tunnelbroker/use-peer-to-peer-message-handler.js

native/profile/secondary-device-qr-code-scanner.react.js

[lib] rename getForeignPeerDevices -> getForeignPeerDeviceIDs
ClosedPublic
Actions

Revision Contents
Changeset List