Page MenuHomePhabricator

[lib] introduce new device list function to replace keyserver device
ClosedPublic

Authored by varun on Jul 19 2024, 12:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 25, 2:38 AM
Unknown Object (File)
Fri, Oct 25, 2:38 AM
Unknown Object (File)
Fri, Oct 25, 2:38 AM
Unknown Object (File)
Mon, Oct 21, 10:25 PM
Unknown Object (File)
Oct 3 2024, 3:27 AM
Unknown Object (File)
Sep 28 2024, 6:54 PM
Unknown Object (File)
Sep 25 2024, 1:31 AM
Unknown Object (File)
Sep 25 2024, 1:31 AM
Subscribers

Details

Summary

we want to be able to replace an existing keyserver with a new one

Depends on D12734

Test Plan

later in the diff stack I successfully replace my existing keyserver device with a new one

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun requested review of this revision.Jul 19 2024, 1:09 PM
bartek requested changes to this revision.Jul 22 2024, 1:36 AM
bartek added inline comments.
lib/shared/device-list-utils.js
236–240 ↗(On Diff #42550)

What if the old device is not on the list, but the new one is not?
I think we should continue adding it in that case.

Otherwise, this function would return successfully without the device list being updated

This revision now requires changes to proceed.Jul 22 2024, 1:36 AM
This revision is now accepted and ready to land.Jul 26 2024, 1:56 AM