Page MenuHomePhabricator
Differential D13972

[lib] standarize broadcasting device list update when removing device
ClosedPublic
Actions

Authored by kamil on Nov 20 2024, 3:05 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 23, 1:00 PM
Unknown Object (File)
Sun, Mar 23, 12:57 PM
Unknown Object (File)
Fri, Feb 28, 2:57 AM
Unknown Object (File)
Fri, Feb 28, 2:56 AM
Unknown Object (File)
Feb 18 2025, 1:56 PM
Unknown Object (File)
Feb 18 2025, 1:56 PM
Unknown Object (File)
Feb 10 2025, 1:42 PM
Unknown Object (File)
Jan 22 2025, 2:06 PM
View All 45 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
ashoat
Commits
rCOMMfb55cfff0e59: [lib] standarize broadcasting device list update when removing device
Summary

Addressing https://phab.comm.dev/D13963#inline-78590 and https://phab.comm.dev/D13963#inline-78595.

Right now we have the same approach each time:

  1. Sending device list updates to all our peers
  2. Sending device list updates to all our devices that are on the device list, but without the primary device
  3. Call getAndUpdateDeviceListsForUsers for our userID
    • update AuxUserStore
    • get platform details if the device was added

Depends on D13963

Test Plan

Remove secondary device and test if other peers received device list update

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Nov 20 2024, 3:05 AM
kamil held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 20 2024, 3:05 AM
kamil edited the summary of this revision. (Show Details)Nov 20 2024, 3:08 AM
kamil mentioned this in D13963: [lib] create hook to run Device List Update Protocol.
kamil published this revision for review.Nov 20 2024, 3:10 AM
kamil edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B32722: Diff 45894.Nov 20 2024, 3:23 AM
ashoat added inline comments.Nov 20 2024, 4:23 AM
lib/shared/device-list-utils.js
345 ↗(On Diff #45894)

We could consider extracting this outside the if branches since it's shared across all branches

356 ↗(On Diff #45894)

Same with this line

ashoat accepted this revision.Nov 20 2024, 4:23 AM
This revision is now accepted and ready to land.Nov 20 2024, 4:23 AM
kamil updated this revision to Diff 45987.Nov 25 2024, 2:23 AM

address review

Harbormaster completed remote builds in B32800: Diff 45987.Nov 25 2024, 2:40 AM
Closed by commit rCOMMfb55cfff0e59: [lib] standarize broadcasting device list update when removing device (authored by kamil). · Explain WhyNov 25 2024, 4:06 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMfb55cfff0e59: [lib] standarize broadcasting device list update when removing device.

Revision Contents
Changeset List

PathSize
lib/
shared/
57 lines

Diff 46000

View Options

lib/shared/device-list-utils.js

// @flow // @flow
import { setClientDBStoreActionType } from '../actions/client-db-store-actions.js'; import { setClientDBStoreActionType } from '../actions/client-db-store-actions.js';
import { import {
moveDraftActionType, moveDraftActionType,
updateDraftActionType, updateDraftActionType,
} from '../actions/draft-actions.js'; } from '../actions/draft-actions.js';
import { import {
deleteKeyserverAccountActionTypes, deleteKeyserverAccountActionTypes,
logOutActionTypes, logOutActionTypes,
deleteAccountActionTypes,
} from '../actions/user-actions.js'; } from '../actions/user-actions.js';
import { extractKeyserverIDFromID } from '../keyserver-conn/keyserver-call-utils.js';
import { setNewSessionActionType } from '../keyserver-conn/keyserver-conn-types.js'; import { setNewSessionActionType } from '../keyserver-conn/keyserver-conn-types.js';
import type { DraftStore, DraftStoreOperation } from '../types/draft-types.js'; import type { DraftStore, DraftStoreOperation } from '../types/draft-types.js';
import type { BaseAction } from '../types/redux-types.js'; import type { BaseAction } from '../types/redux-types.js';
type ReduceDraftStoreResult = { type ReduceDraftStoreResult = {
+draftStoreOperations: $ReadOnlyArray<DraftStoreOperation>, +draftStoreOperations: $ReadOnlyArray<DraftStoreOperation>,
+draftStore: DraftStore, +draftStore: DraftStore,
}; };
function removeKeyserversDraftsFromStore(
draftStore: DraftStore,
keyserverIDs: $ReadOnlyArray<string>,
): ReduceDraftStoreResult {
const keyserverIDsSet = new Set<string>(keyserverIDs);
const drafts: { [key: string]: string } = {};
const ids: string[] = [];
for (const key in draftStore.drafts) {
if (keyserverIDsSet.has(extractKeyserverIDFromID(key))) {
ids.push(key);
} else {
drafts[key] = draftStore.drafts[key];
}
}
return {
draftStoreOperations: [{ type: 'remove', payload: { ids } }],
draftStore: { ...draftStore, drafts },
};
}
function reduceDraftStore( function reduceDraftStore(
draftStore: DraftStore, draftStore: DraftStore,
action: BaseAction, action: BaseAction,
): ReduceDraftStoreResult { ): ReduceDraftStoreResult {
if ( if (
action.type === logOutActionTypes.success || action.type === logOutActionTypes.success ||
action.type === deleteKeyserverAccountActionTypes.success || action.type === deleteAccountActionTypes.success
(action.type === setNewSessionActionType &&
action.payload.sessionChange.cookieInvalidated)
) { ) {
return { return {
draftStoreOperations: [{ type: 'remove_all' }], draftStoreOperations: [{ type: 'remove_all' }],
draftStore: { drafts: {} }, draftStore: { drafts: {} },
}; };
} else if (action.type === deleteKeyserverAccountActionTypes.success) {
return removeKeyserversDraftsFromStore(
draftStore,
action.payload.keyserverIDs,
);
} else if (
action.type === setNewSessionActionType &&
action.payload.sessionChange.cookieInvalidated
) {
return removeKeyserversDraftsFromStore(draftStore, [
action.payload.keyserverID,
]);
} else if (action.type === updateDraftActionType) { } else if (action.type === updateDraftActionType) {
const { key, text } = action.payload; const { key, text } = action.payload;
const draftStoreOperations = [ const draftStoreOperations = [
{ {
type: 'update', type: 'update',
payload: { key, text }, payload: { key, text },
}, },
Show All 40 Lines return {
...draftStore, ...draftStore,
drafts: drafts, drafts: drafts,
}, },
}; };
} }
return { draftStore, draftStoreOperations: [] }; return { draftStore, draftStoreOperations: [] };
} }
export { reduceDraftStore }; export { reduceDraftStore, removeKeyserversDraftsFromStore };