Page MenuHomePhabricator
Differential D14044

[CryptoModule] store only pickled Olm Account in User Keys Backup
ClosedPublic
Actions

Authored by kamil on Nov 26 2024, 3:29 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 21, 4:52 PM
Unknown Object (File)
Wed, Mar 12, 1:59 PM
Unknown Object (File)
Wed, Mar 12, 1:59 PM
Unknown Object (File)
Wed, Mar 12, 1:55 PM
Unknown Object (File)
Wed, Mar 12, 1:54 PM
Unknown Object (File)
Feb 20 2025, 10:34 AM
Unknown Object (File)
Feb 6 2025, 7:47 PM
Unknown Object (File)
Feb 3 2025, 3:28 PM
View All 51 Files
Subscribers
ashoat

Details

Reviewers
bartek
tomek
Commits
rCOMM0f805007b641: [CryptoModule] store only pickled Olm Account in User Keys Backup
Summary

Discussed in ENG-9659.

Restoring should work without changes, session set will be empty.

Depends on D14005

Test Plan

Test creating User Keys backup

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Nov 26 2024, 3:29 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptNov 26 2024, 3:29 AM
Harbormaster completed remote builds in B32835: Diff 46050.Nov 26 2024, 3:47 AM
kamil added a child revision: D14045: [CryptoModule] remove `CryptoAccountID`.Nov 26 2024, 3:50 AM
kamil published this revision for review.Nov 26 2024, 4:09 AM
bartek accepted this revision.Nov 26 2024, 7:11 AM

Nit: Names are now a bit divergent: pickleAccountToString for account-only, and storeAsB64 for account+sessions but return types differ too. IMO storeAsB64 is misleading because Persist type isn't base64.

This revision is now accepted and ready to land.Nov 26 2024, 7:11 AM
kamil added a comment.Dec 2 2024, 7:07 AM
In D14044#391456, @bartek wrote:

Nit: Names are now a bit divergent: pickleAccountToString for account-only, and storeAsB64 for account+sessions but return types differ too. IMO storeAsB64 is misleading because Persist type isn't base64.

Good call. This is not related to my changes but to old code which was around for a while so I created ENG-9970.

Closed by commit rCOMM0f805007b641: [CryptoModule] store only pickled Olm Account in User Keys Backup (authored by kamil). · Explain WhyDec 3 2024, 6:28 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM0f805007b641: [CryptoModule] store only pickled Olm Account in User Keys Backup.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
CryptoTools/
2 lines
41 lines
NativeModules/
8 lines

Diff 46192

View Options

native/cpp/CommonCpp/CryptoTools/CryptoModule.h

landing/dist landing/dist
landing/flow-typed landing/flow-typed
landing/node_modules landing/node_modules
lib/flow-typed lib/flow-typed
lib/node_modules lib/node_modules
web/dist web/dist
web/flow-typed web/flow-typed
web/node_modules web/node_modules
web/opaque-ke-wasm/pkg web/opaque-ke-wasm/pkg
web/database/_generated web/database/_generated
web/backup-client-wasm/wasm/backup-client-wasm.js
keyserver/app_compiled keyserver/app_compiled
keyserver/landing_compiled keyserver/landing_compiled
keyserver/dist keyserver/dist
keyserver/secrets keyserver/secrets
keyserver/facts keyserver/facts
keyserver/fonts keyserver/fonts
keyserver/flow-typed keyserver/flow-typed
keyserver/node_modules keyserver/node_modules
Show All 11 Lines
View Options

native/cpp/CommonCpp/CryptoTools/CryptoModule.cpp

landing/dist landing/dist
landing/flow-typed landing/flow-typed
landing/node_modules landing/node_modules
lib/flow-typed lib/flow-typed
lib/node_modules lib/node_modules
web/dist web/dist
web/flow-typed web/flow-typed
web/node_modules web/node_modules
web/opaque-ke-wasm/pkg web/opaque-ke-wasm/pkg
web/database/_generated web/database/_generated
web/backup-client-wasm/wasm/backup-client-wasm.js
keyserver/app_compiled keyserver/app_compiled
keyserver/landing_compiled keyserver/landing_compiled
keyserver/dist keyserver/dist
keyserver/secrets keyserver/secrets
keyserver/facts keyserver/facts
keyserver/fonts keyserver/fonts
keyserver/flow-typed keyserver/flow-typed
keyserver/node_modules keyserver/node_modules
Show All 11 Lines
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

landing/dist landing/dist
landing/flow-typed landing/flow-typed
landing/node_modules landing/node_modules
lib/flow-typed lib/flow-typed
lib/node_modules lib/node_modules
web/dist web/dist
web/flow-typed web/flow-typed
web/node_modules web/node_modules
web/opaque-ke-wasm/pkg web/opaque-ke-wasm/pkg
web/database/_generated web/database/_generated
web/backup-client-wasm/wasm/backup-client-wasm.js
keyserver/app_compiled keyserver/app_compiled
keyserver/landing_compiled keyserver/landing_compiled
keyserver/dist keyserver/dist
keyserver/secrets keyserver/secrets
keyserver/facts keyserver/facts
keyserver/fonts keyserver/fonts
keyserver/flow-typed keyserver/flow-typed
keyserver/node_modules keyserver/node_modules
Show All 11 Lines