Paths

Table of Contentst

Differential D14058

[lib] create a hook to check if device is primary
ClosedPublic
Actions

Authored by kamil on Nov 27 2024, 9:30 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Jan 1, 2:46 PM

	Unknown Object (File)
	Tue, Dec 31, 11:29 AM

	Unknown Object (File)
	Tue, Dec 31, 3:00 AM

	Unknown Object (File)
	Mon, Dec 30, 1:48 AM

	Unknown Object (File)
	Mon, Dec 30, 12:56 AM

	Unknown Object (File)
	Sat, Dec 28, 12:55 PM

	Unknown Object (File)
	Sat, Dec 28, 10:44 AM

	Unknown Object (File)
	Sat, Dec 28, 4:07 AM

View All 35 Files

Subscribers

Details

Reviewers

bartek
tomek

Commits

rCOMM1c4a54aec179: [lib] create a hook to check if device is primary

Summary

The fact that this is asynchronous is painful but this is caused by ENG-8192.

Creatin hook to avoid code duplication

Test Plan

Log result and check if this works on primary and non-primary

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Nov 27 2024, 9:30 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptNov 27 2024, 9:31 AM

kamil added a child revision: D14056: [native] enable backup handler for staff.Nov 27 2024, 9:36 AM

Harbormaster completed remote builds in B32885: Diff 46100.Nov 27 2024, 9:52 AM

kamil published this revision for review.Nov 27 2024, 10:17 AM

kamil edited the summary of this revision. (Show Details)

kamil mentioned this in D14063: [native] allow password change only on primary device.Nov 28 2024, 5:29 AM

bartek accepted this revision.Nov 29 2024, 3:16 AM

bartek added inline comments.

lib/hooks/primary-device-hooks.js
22 ↗	(On Diff #46100)	Alternatively, you can use `await getContentSigningKey()` from `lib/utils/crypto-utils.js` to get just deviceID and avoid relying on Identity context

This revision is now accepted and ready to land.Nov 29 2024, 3:16 AM

kamil added inline comments.Dec 2 2024, 6:53 AM

lib/hooks/primary-device-hooks.js
22 ↗	(On Diff #46100)	It's basically the same, but I prefer using `getAuthMetadata()` as this is what we use a lot more in the codebase. Overall, we should aim to get ENG-8192 done as a future solution.

Closed by commit rCOMM1c4a54aec179: [lib] create a hook to check if device is primary (authored by kamil). · Explain WhyDec 2 2024, 6:54 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM1c4a54aec179: [lib] create a hook to check if device is primary.

kamil mentioned this in rCOMM99f4e4a6ccef: [native] allow password change only on primary device.Dec 3 2024, 6:28 AM

Revision Contents
Changeset List

Path

Size

lib/

hooks/

primary-device-hooks.js

27 lines

native/

account/

registration/

missing-registration-data/

missing-registration-data-handler.react.js

27 lines

Diff 46163

lib/hooks/primary-device-hooks.js

Loading...

native/account/registration/missing-registration-data/missing-registration-data-handler.react.js

Loading...