Paths

Table of Contentst

[lib] create a hook to check if device is primary
AcceptedPublic
Actions

Authored by kamil on Wed, Nov 27, 9:30 AM.

Details

Reviewers

bartek
tomek

Summary

The fact that this is asynchronous is painful but this is caused by ENG-8192.

Creatin hook to avoid code duplication

Test Plan

Log result and check if this works on primary and non-primary

Diff Detail

Repository

rCOMM Comm

Branch

backup-2

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Wed, Nov 27, 9:30 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptWed, Nov 27, 9:31 AM

kamil added a child revision: D14056: [native] enable backup handler for staff.Wed, Nov 27, 9:36 AM

Harbormaster completed remote builds in B32885: Diff 46100.Wed, Nov 27, 9:52 AM

kamil published this revision for review.Wed, Nov 27, 10:17 AM

kamil edited the summary of this revision. (Show Details)

kamil mentioned this in D14063: [native] allow password change only on primary device.Thu, Nov 28, 5:29 AM

bartek accepted this revision.Fri, Nov 29, 3:16 AM

bartek added inline comments.

lib/hooks/primary-device-hooks.js
22	Alternatively, you can use `await getContentSigningKey()` from `lib/utils/crypto-utils.js` to get just deviceID and avoid relying on Identity context

This revision is now accepted and ready to land.Fri, Nov 29, 3:16 AM

Revision Contents
Changeset List

Path

Size

lib/

hooks/

primary-device-hooks.js

27 lines

native/

account/

registration/

missing-registration-data/

missing-registration-data-handler.react.js

27 lines

Diff 46100

View Options

lib/hooks/primary-device-hooks.js