[native] handle invalid CSAT in Backup authenticated API
ClosedPublic
Actions

Authored by kamil on Nov 28 2024, 4:52 AM.

Details

Reviewers

bartek
tomek

Commits

rCOMM12c361f274a5: [native] handle invalid CSAT in Backup authenticated API

Summary

This is implementation on ENG-9604#comment-0ef625dd.

Similar to D14024.

We need to keep this in mind to handle this also in the future, when working on User Data restore, for now we download only User Keys which are unauthenticated, and there is no code for User Data yet.

Depends on D14060

Test Plan

Backup upload works
Mock CSAT with random string -> logged out on backup upload attempt

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Nov 28 2024, 4:52 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptNov 28 2024, 4:52 AM

kamil edited the summary of this revision. (Show Details)Nov 28 2024, 4:53 AM

kamil edited the summary of this revision. (Show Details)

kamil added a parent revision: D14060: [native] add handler for staff to attempt backup restore.

kamil removed a parent revision: D14024: [native] Handle invalid CSAT in Identity RPCs.

kamil published this revision for review.Nov 28 2024, 5:09 AM

Harbormaster completed remote builds in B32889: Diff 46105.Nov 28 2024, 5:09 AM

kamil added a child revision: D14063: [native] allow password change only on primary device.Nov 28 2024, 5:29 AM

Nice, thanks!

shared/backup_client/src/lib.rs
99–108 ↗	(On Diff #46105)	The original version with single match probably didn't work because of incompatible types, a `.into()` would probably work. But this is also okay, let it stay as is