[native] handle invalid CSAT in Backup authenticated API
AcceptedPublic
Actions

Authored by kamil on Thu, Nov 28, 4:52 AM.

Details

Reviewers

bartek
tomek

Summary

This is implementation on ENG-9604#comment-0ef625dd.

Similar to D14024.

We need to keep this in mind to handle this also in the future, when working on User Data restore, for now we download only User Keys which are unauthenticated, and there is no code for User Data yet.

Depends on D14060

Test Plan

Backup upload works
Mock CSAT with random string -> logged out on backup upload attempt

Diff Detail

Repository

rCOMM Comm

Branch

backup-2

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Thu, Nov 28, 4:52 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptThu, Nov 28, 4:52 AM

kamil edited the summary of this revision. (Show Details)Thu, Nov 28, 4:53 AM

kamil edited the summary of this revision. (Show Details)

kamil added a parent revision: D14060: [native] add handler for staff to attempt backup restore.

kamil removed a parent revision: D14024: [native] Handle invalid CSAT in Identity RPCs.

kamil published this revision for review.Thu, Nov 28, 5:09 AM

Harbormaster completed remote builds in B32889: Diff 46105.Thu, Nov 28, 5:09 AM

kamil added a child revision: D14063: [native] allow password change only on primary device.Thu, Nov 28, 5:29 AM

Nice, thanks!

shared/backup_client/src/lib.rs
99–108	The original version with single match probably didn't work because of incompatible types, a `.into()` would probably work. But this is also okay, let it stay as is