Page MenuHomePhabricator
Differential D13933

[CommCoreModule] remove capturing logs
ClosedPublic
Actions

Authored by kamil on Nov 14 2024, 8:34 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 12, 7:54 PM
Unknown Object (File)
Thu, Apr 3, 3:08 AM
Unknown Object (File)
Wed, Apr 2, 10:13 PM
Unknown Object (File)
Wed, Apr 2, 7:37 PM
Unknown Object (File)
Wed, Apr 2, 12:12 AM
Unknown Object (File)
Sat, Mar 22, 6:25 PM
Unknown Object (File)
Mar 3 2025, 6:25 AM
Unknown Object (File)
Mar 3 2025, 6:25 AM
View All 48 Files
Subscribers
ashoat

Details

Reviewers
bartek
tomek
Commits
rCOMM31151871843e: [CommCoreModule] remove capturing logs
Summary

ENG-9656.

The decision explained in ENG-9663.

Created ENG-9921 to revert this in the future.

Depends on D13932

Test Plan

N/A - making sure this method is not called anywhere.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
1 line
PersistentStorageUtilities/
DataStores/
1 line

Diff 46011

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

// @flow // @flow
import type { import type {
LogOutResult, LogOutResult,
KeyserverLogOutResult,
LogInStartingPayload, LogInStartingPayload,
LogInResult, LogInResult,
RegisterResult, RegisterResult,
DefaultNotificationPayload, DefaultNotificationPayload,
ClaimUsernameResponse, ClaimUsernameResponse,
KeyserverAuthResult, KeyserverAuthResult,
} from './account-types.js'; } from './account-types.js';
import type { import type {
▲ Show 20 Lines • Show All 178 Lines • ▼ Show 20 Linesexport type BaseAction =
| { | {
+type: 'LOG_OUT_FAILED', +type: 'LOG_OUT_FAILED',
+error: true, +error: true,
+payload: Error, +payload: Error,
+loadingInfo: LoadingInfo, +loadingInfo: LoadingInfo,
} }
| { | {
+type: 'LOG_OUT_SUCCESS', +type: 'LOG_OUT_SUCCESS',
+payload: LogOutResult, +payload: KeyserverLogOutResult,
+loadingInfo: LoadingInfo, +loadingInfo: LoadingInfo,
} }
| { | {
+type: 'CLAIM_USERNAME_STARTED', +type: 'CLAIM_USERNAME_STARTED',
+payload?: void, +payload?: void,
+loadingInfo: LoadingInfo, +loadingInfo: LoadingInfo,
} }
| { | {
Show All 15 Linesexport type BaseAction =
| { | {
+type: 'DELETE_KEYSERVER_ACCOUNT_FAILED', +type: 'DELETE_KEYSERVER_ACCOUNT_FAILED',
+error: true, +error: true,
+payload: Error, +payload: Error,
+loadingInfo: LoadingInfo, +loadingInfo: LoadingInfo,
} }
| { | {
+type: 'DELETE_KEYSERVER_ACCOUNT_SUCCESS', +type: 'DELETE_KEYSERVER_ACCOUNT_SUCCESS',
+payload: LogOutResult, +payload: KeyserverLogOutResult,
+loadingInfo: LoadingInfo, +loadingInfo: LoadingInfo,
} }
| { | {
+type: 'DELETE_IDENTITY_ACCOUNT_STARTED', +type: 'DELETE_IDENTITY_ACCOUNT_STARTED',
+payload?: void, +payload?: void,
+loadingInfo: LoadingInfo, +loadingInfo: LoadingInfo,
} }
| { | {
▲ Show 20 Lines • Show All 1,072 Lines • Show Last 20 Lines
View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/BaseDataStore.h

// @flow // @flow
import type { import type {
LogOutResult, LogOutResult,
KeyserverLogOutResult,
LogInStartingPayload, LogInStartingPayload,
LogInResult, LogInResult,
RegisterResult, RegisterResult,
DefaultNotificationPayload, DefaultNotificationPayload,
ClaimUsernameResponse, ClaimUsernameResponse,
KeyserverAuthResult, KeyserverAuthResult,
} from './account-types.js'; } from './account-types.js';
import type { import type {
▲ Show 20 Lines • Show All 178 Lines • ▼ Show 20 Linesexport type BaseAction =
| { | {
+type: 'LOG_OUT_FAILED', +type: 'LOG_OUT_FAILED',
+error: true, +error: true,
+payload: Error, +payload: Error,
+loadingInfo: LoadingInfo, +loadingInfo: LoadingInfo,
} }
| { | {
+type: 'LOG_OUT_SUCCESS', +type: 'LOG_OUT_SUCCESS',
+payload: LogOutResult, +payload: KeyserverLogOutResult,
+loadingInfo: LoadingInfo, +loadingInfo: LoadingInfo,
} }
| { | {
+type: 'CLAIM_USERNAME_STARTED', +type: 'CLAIM_USERNAME_STARTED',
+payload?: void, +payload?: void,
+loadingInfo: LoadingInfo, +loadingInfo: LoadingInfo,
} }
| { | {
Show All 15 Linesexport type BaseAction =
| { | {
+type: 'DELETE_KEYSERVER_ACCOUNT_FAILED', +type: 'DELETE_KEYSERVER_ACCOUNT_FAILED',
+error: true, +error: true,
+payload: Error, +payload: Error,
+loadingInfo: LoadingInfo, +loadingInfo: LoadingInfo,
} }
| { | {
+type: 'DELETE_KEYSERVER_ACCOUNT_SUCCESS', +type: 'DELETE_KEYSERVER_ACCOUNT_SUCCESS',
+payload: LogOutResult, +payload: KeyserverLogOutResult,
+loadingInfo: LoadingInfo, +loadingInfo: LoadingInfo,
} }
| { | {
+type: 'DELETE_IDENTITY_ACCOUNT_STARTED', +type: 'DELETE_IDENTITY_ACCOUNT_STARTED',
+payload?: void, +payload?: void,
+loadingInfo: LoadingInfo, +loadingInfo: LoadingInfo,
} }
| { | {
▲ Show 20 Lines • Show All 1,072 Lines • Show Last 20 Lines