[native] allow password change only on primary device
ClosedPublic
Actions

Authored by kamil on Nov 28 2024, 5:29 AM.

Details

Reviewers

ashoat
varun

Commits

rCOMM99f4e4a6ccef: [native] allow password change only on primary device

Summary

This was discussed in ENG-8070

Only the primary device should be able to change the password.

Perhaps there was some alternative to keep this for a while and disable this after the user migrated to Signed Device Lists (v2), but this is not easy and probably there is no need to complicate just to keep it for a ~month and then remove.

Hook with check was introduced in D14058

Depends on D14061, D14062

Test Plan

On primary device button to change password is visible
On secondary device there is no button

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Nov 28 2024, 5:29 AM

kamil held this revision as a draft.

Herald added a subscriber: tomek. · View Herald TranscriptNov 28 2024, 5:29 AM

Harbormaster completed remote builds in B32891: Diff 46107.Nov 28 2024, 5:47 AM

kamil added a child revision: D14065: [native] regenerate backup on every password change.Nov 28 2024, 6:23 AM

kamil published this revision for review.Nov 28 2024, 6:24 AM

ashoat accepted this revision.Sat, Nov 30, 8:11 AM

This revision is now accepted and ready to land.Sat, Nov 30, 8:11 AM

Closed by commit rCOMM99f4e4a6ccef: [native] allow password change only on primary device (authored by kamil). · Explain WhyTue, Dec 3, 6:28 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM99f4e4a6ccef: [native] allow password change only on primary device.

Revision Contents
Changeset List

Path

Size

native/

profile/

profile-screen.react.js

27 lines

Diff 46204

View Options

native/profile/profile-screen.react.js

[native] allow password change only on primary deviceClosedPublicActions