Paths

Table of Contentst

Differential D13932

[backup-client][native_rust_library] refactor uploading files to not ignore User Keys
ClosedPublic
Actions

Authored by kamil on Nov 14 2024, 8:31 AM.

Tags

None

Referenced Files

	F3513510: D13932.id46010.diff
	Sun, Dec 22, 12:25 AM

	F3513508: D13932.id45823.diff
	Sun, Dec 22, 12:25 AM

	F3513450: D13932.id.diff
	Sun, Dec 22, 12:24 AM

	F3513420: D13932.diff
	Sun, Dec 22, 12:23 AM

	Unknown Object (File)
	Mon, Dec 16, 12:28 PM

	Unknown Object (File)
	Mon, Dec 9, 10:54 PM

	Unknown Object (File)
	Wed, Dec 4, 6:00 PM

	Unknown Object (File)
	Wed, Dec 4, 4:53 PM

View All 29 Files

Subscribers

Details

Reviewers

bartek
tomek

Commits

rCOMM0e67143b806d: [backup-client][native_rust_library] refactor uploading files to not ignore…

Summary

Previously, it was treating User Keys as additional data and was skipping upload, because User Keys were updated together with User Data Compaction. This diff refactors code to attempt compaction upload for any backup_id for which there is User Data, User Keys, or logs (but we don't generate logs now -> next diff).

Depends on D13931

Test Plan

Tested in D13937

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Nov 14 2024, 8:31 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptNov 14 2024, 8:31 AM

kamil edited the summary of this revision. (Show Details)Nov 14 2024, 8:32 AM

kamil added a child revision: D13933: [CommCoreModule] remove capturing logs.Nov 14 2024, 8:34 AM

kamil edited the test plan for this revision. (Show Details)Nov 14 2024, 9:03 AM

Harbormaster completed remote builds in B32664: Diff 45823.Nov 14 2024, 11:18 AM

kamil published this revision for review.Nov 15 2024, 2:23 AM

kamil added inline comments.

native/native_rust_library/src/backup/upload_handler.rs
165–167 ↗	(On Diff #45823)	not sure what is better, if this should be placed here when adding to Vec, or called only once before this loop

bartek accepted this revision.Nov 19 2024, 5:45 AM

bartek added inline comments.

native/native_rust_library/src/backup/upload_handler.rs
165–167 ↗	(On Diff #45823)	I'm not sure if it makes any difference, it can stay here

This revision is now accepted and ready to land.Nov 19 2024, 5:45 AM

Closed by commit rCOMM0e67143b806d: [backup-client][native_rust_library] refactor uploading files to not ignore… (authored by kamil). · Explain WhyMon, Nov 25, 4:07 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM0e67143b806d: [backup-client][native_rust_library] refactor uploading files to not ignore….

Revision Contents
Changeset List

Path

Size

native/

native_rust_library/

src/

backup/

2 lines

upload_handler.rs

47 lines

Diff 46010

native/native_rust_library/src/backup/file_info.rs

Loading...

native/native_rust_library/src/backup/upload_handler.rs

Loading...