Paths

Table of Contentst

Differential D13932

[backup-client][native_rust_library] refactor uploading files to not ignore User Keys
AcceptedPublic
Actions

Authored by kamil on Thu, Nov 14, 8:31 AM.

Tags

None

Referenced Files

	F3326114: D13932.diff
	Wed, Nov 20, 7:07 AM

	Unknown Object (File)
	Tue, Nov 19, 10:14 PM

	Unknown Object (File)
	Sat, Nov 16, 8:09 PM

	Unknown Object (File)
	Sat, Nov 16, 6:16 PM

	Unknown Object (File)
	Sat, Nov 16, 6:16 PM

	Unknown Object (File)
	Sat, Nov 16, 6:15 PM

	Unknown Object (File)
	Sat, Nov 16, 4:22 PM

	Unknown Object (File)
	Sat, Nov 16, 3:39 PM

View All 11 Files

Subscribers

Details

Reviewers

bartek
tomek

Summary

Previously, it was treating User Keys as additional data and was skipping upload, because User Keys were updated together with User Data Compaction. This diff refactors code to attempt compaction upload for any backup_id for which there is User Data, User Keys, or logs (but we don't generate logs now -> next diff).

Depends on D13931

Test Plan

Tested in D13937

Diff Detail

Repository

Branch

publish-client-backup

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Thu, Nov 14, 8:31 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptThu, Nov 14, 8:31 AM

kamil edited the summary of this revision. (Show Details)Thu, Nov 14, 8:32 AM

kamil added a child revision: D13933: [CommCoreModule] remove capturing logs.Thu, Nov 14, 8:34 AM

kamil edited the test plan for this revision. (Show Details)Thu, Nov 14, 9:03 AM

Harbormaster completed remote builds in B32664: Diff 45823.Thu, Nov 14, 11:18 AM

kamil published this revision for review.Fri, Nov 15, 2:23 AM

kamil added inline comments.

native/native_rust_library/src/backup/upload_handler.rs
165–167	not sure what is better, if this should be placed here when adding to Vec, or called only once before this loop

bartek accepted this revision.Tue, Nov 19, 5:45 AM

bartek added inline comments.

native/native_rust_library/src/backup/upload_handler.rs
165–167	I'm not sure if it makes any difference, it can stay here

This revision is now accepted and ready to land.Tue, Nov 19, 5:45 AM

Revision Contents
Changeset List

Path

Size

native/

native_rust_library/

src/

backup/

2 lines

upload_handler.rs

47 lines

Diff 45823

native/native_rust_library/src/backup/file_info.rs

Loading...

native/native_rust_library/src/backup/upload_handler.rs

Loading...