Page MenuHomePhabricator
Differential D13937

[native_rust_library] update creating backup to return `backupID`
ClosedPublic
Actions

Authored by kamil on Nov 14 2024, 9:02 AM.
Tags
None
Referenced Files
F3513518: D13937.id45828.diff
Sun, Dec 22, 12:26 AM
F3513455: D13937.id.diff
Sun, Dec 22, 12:25 AM
F3513416: D13937.diff
Sun, Dec 22, 12:23 AM
F3510130: D13937.id45989.diff
Sat, Dec 21, 11:53 AM
Unknown Object (File)
Wed, Dec 18, 11:24 PM
Unknown Object (File)
Tue, Dec 17, 7:44 PM
Unknown Object (File)
Mon, Dec 16, 3:40 AM
Unknown Object (File)
Mon, Dec 16, 2:42 AM
View All 28 Files
Subscribers
ashoat

Details

Reviewers
bartek
tomek
Commits
rCOMM45497af77549: [native_rust_library] update creating backup to return `backupID`
Summary

ENG-9656.

We need to store backupID in the store, it's needed in e.g. ENG-9616.

Depends on D13936

Test Plan

This is the final diff for this stack so testing this end-to-end, mostly uploading User Keys, but also getting the latest Backup Info and Uploading full backup to test if this still works.
I was testing using physical iOS and Android, and both password and wallet users.
I was confirming everything with investigating DDB content.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Nov 14 2024, 9:02 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptNov 14 2024, 9:02 AM
kamil edited the test plan for this revision. (Show Details)Nov 14 2024, 9:02 AM
kamil mentioned this in D13931: [backup-client][native_rust_library] implement creating User Keys backup.
kamil mentioned this in D13932: [backup-client][native_rust_library] refactor uploading files to not ignore User Keys.
kamil mentioned this in D13934: [CommCoreModule] implement creating User Keys backup.
kamil mentioned this in D13935: [native] implement creating User Keys backup.
kamil mentioned this in D13936: [CommCoreModule] cleanup methods for creating backup.
kamil edited the test plan for this revision. (Show Details)Nov 14 2024, 9:06 AM
Harbormaster completed remote builds in B32669: Diff 45828.Nov 14 2024, 1:44 PM
kamil published this revision for review.Nov 15 2024, 2:27 AM
bartek accepted this revision.Nov 20 2024, 8:51 AM
bartek added inline comments.
native/native_rust_library/src/backup/compaction_upload_promises.rs
24–27 ↗(On Diff #45828)

IMO better

This revision is now accepted and ready to land.Nov 20 2024, 8:51 AM
kamil added a child revision: D14000: [CommCoreModule][native_rust_library] move constants to one place.Nov 22 2024, 2:15 AM
kamil updated this revision to Diff 45989.Mon, Nov 25, 2:37 AM

address review

Harbormaster completed remote builds in B32802: Diff 45989.Mon, Nov 25, 2:54 AM
Closed by commit rCOMM45497af77549: [native_rust_library] update creating backup to return `backupID` (authored by kamil). · Explain WhyMon, Nov 25, 4:07 AM
This revision was automatically updated to reflect the committed changes.
kamil mentioned this in rCOMM470578434b49: [backup-client][native_rust_library] implement creating User Keys backup.
kamil mentioned this in rCOMM0e67143b806d: [backup-client][native_rust_library] refactor uploading files to not ignore….
kamil mentioned this in rCOMMf38db4748c74: [CommCoreModule] implement creating User Keys backup.
kamil mentioned this in rCOMMdd0cfbe78f8f: [native] implement creating User Keys backup.
kamil mentioned this in rCOMMf2be17bca4bd: [CommCoreModule] cleanup methods for creating backup.
kamil added a commit: rCOMM45497af77549: [native_rust_library] update creating backup to return `backupID`.

Revision Contents
Changeset List

PathSize
native/
backup/
8 lines
native_rust_library/
src/
backup/
8 lines
profile/
10 lines
schema/
4 lines

Diff 46014

View Options

native/backup/use-client-backup.js

Loading...
View Options

native/native_rust_library/src/backup/compaction_upload_promises.rs

Loading...
View Options

native/profile/backup-menu.react.js

Loading...
View Options

native/schema/CommCoreModuleSchema.js

Loading...