Paths

Table of Contentst

-
native/backup/
-
backup/
-
backup-handler.js

[native] add handler for staff to attempt backup restore
ClosedPublic
Actions

Authored by kamil on Nov 27 2024, 9:45 AM.

Details

Reviewers

bartek
tomek

Commits

rCOMM618bdb01cda6: [native] add handler for staff to attempt backup restore

Summary

ENG-9711.

Depends on D14059

Test Plan

Update millisecondsPerDay to be lower value and test if this works.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Nov 27 2024, 9:45 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptNov 27 2024, 9:45 AM

Harbormaster completed remote builds in B32888: Diff 46103.Nov 27 2024, 10:10 AM

kamil published this revision for review.Nov 27 2024, 10:25 AM

kamil added inline comments.

native/backup/backup-handler.js
91–100 ↗	(On Diff #46103)	can be done using `Promise.all`
145–160 ↗	(On Diff #46103)	causing another update after 24 hours is intentional for testing purposes and checking stabillity

kamil added a child revision: D14061: [native] handle invalid CSAT in Backup authenticated API.Nov 28 2024, 4:53 AM

kamil added inline comments.Nov 28 2024, 6:19 AM

native/backup/backup-handler.js
148–150 ↗	(On Diff #46103)

bartek accepted this revision.Nov 29 2024, 2:59 AM

bartek added inline comments.

native/backup/backup-handler.js
145–160 ↗	(On Diff #46103)	Looks reasonable

This revision is now accepted and ready to land.Nov 29 2024, 2:59 AM

address notes

Harbormaster completed remote builds in B32919: Diff 46180.Dec 3 2024, 5:27 AM

Closed by commit rCOMM618bdb01cda6: [native] add handler for staff to attempt backup restore (authored by kamil). · Explain WhyDec 3 2024, 6:28 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM618bdb01cda6: [native] add handler for staff to attempt backup restore.

kamil mentioned this in D14077: [native] remove comment from `BackupHandler`.Dec 3 2024, 6:33 AM

kamil mentioned this in rCOMM066e576587e0: [native] remove comment from `BackupHandler`.Dec 4 2024, 4:38 AM

Revision Contents
Changeset List

Path

Size

native/

backup/

backup-handler.js

78 lines

Diff 46201

View Options

native/backup/backup-handler.js

// @flow		// @flow

import { setClientDBStoreActionType } from '../actions/client-db-store-actions.js';		import { setClientDBStoreActionType } from '../actions/client-db-store-actions.js';
import {		import {
moveDraftActionType,		moveDraftActionType,
updateDraftActionType,		updateDraftActionType,
} from '../actions/draft-actions.js';		} from '../actions/draft-actions.js';
import {		import {
deleteKeyserverAccountActionTypes,		deleteKeyserverAccountActionTypes,
logOutActionTypes,		logOutActionTypes,
		deleteAccountActionTypes,
} from '../actions/user-actions.js';		} from '../actions/user-actions.js';
		import { extractKeyserverIDFromID } from '../keyserver-conn/keyserver-call-utils.js';
import { setNewSessionActionType } from '../keyserver-conn/keyserver-conn-types.js';		import { setNewSessionActionType } from '../keyserver-conn/keyserver-conn-types.js';
import type { DraftStore, DraftStoreOperation } from '../types/draft-types.js';		import type { DraftStore, DraftStoreOperation } from '../types/draft-types.js';
import type { BaseAction } from '../types/redux-types.js';		import type { BaseAction } from '../types/redux-types.js';

type ReduceDraftStoreResult = {		type ReduceDraftStoreResult = {
+draftStoreOperations: $ReadOnlyArray<DraftStoreOperation>,		+draftStoreOperations: $ReadOnlyArray<DraftStoreOperation>,
+draftStore: DraftStore,		+draftStore: DraftStore,
};		};

		function removeKeyserversDraftsFromStore(
		draftStore: DraftStore,
		keyserverIDs: $ReadOnlyArray<string>,
		): ReduceDraftStoreResult {
		const keyserverIDsSet = new Set<string>(keyserverIDs);

		const drafts: { [key: string]: string } = {};
		const ids: string[] = [];
		for (const key in draftStore.drafts) {
		if (keyserverIDsSet.has(extractKeyserverIDFromID(key))) {
		ids.push(key);
		} else {
		drafts[key] = draftStore.drafts[key];
		}
		}

		return {
		draftStoreOperations: [{ type: 'remove', payload: { ids } }],
		draftStore: { ...draftStore, drafts },
		};
		}

function reduceDraftStore(		function reduceDraftStore(
draftStore: DraftStore,		draftStore: DraftStore,
action: BaseAction,		action: BaseAction,
): ReduceDraftStoreResult {		): ReduceDraftStoreResult {
if (		if (
action.type === logOutActionTypes.success \|\|		action.type === logOutActionTypes.success \|\|
action.type === deleteKeyserverAccountActionTypes.success \|\|		action.type === deleteAccountActionTypes.success
(action.type === setNewSessionActionType &&
action.payload.sessionChange.cookieInvalidated)
) {		) {
return {		return {
draftStoreOperations: [{ type: 'remove_all' }],		draftStoreOperations: [{ type: 'remove_all' }],
draftStore: { drafts: {} },		draftStore: { drafts: {} },
};		};
		} else if (action.type === deleteKeyserverAccountActionTypes.success) {
		return removeKeyserversDraftsFromStore(
		draftStore,
		action.payload.keyserverIDs,
		);
		} else if (
		action.type === setNewSessionActionType &&
		action.payload.sessionChange.cookieInvalidated
		) {
		return removeKeyserversDraftsFromStore(draftStore, [
		action.payload.keyserverID,
		]);
} else if (action.type === updateDraftActionType) {		} else if (action.type === updateDraftActionType) {
const { key, text } = action.payload;		const { key, text } = action.payload;

const draftStoreOperations = [		const draftStoreOperations = [
{		{
type: 'update',		type: 'update',
payload: { key, text },		payload: { key, text },
},		},
Show All 40 Lines	return {
...draftStore,		...draftStore,
drafts: drafts,		drafts: drafts,
},		},
};		};
}		}
return { draftStore, draftStoreOperations: [] };		return { draftStore, draftStoreOperations: [] };
}		}

export { reduceDraftStore };		export { reduceDraftStore, removeKeyserversDraftsFromStore };

[native] add handler for staff to attempt backup restoreClosedPublicActions