Page MenuHomePhabricator
Differential D14060

[native] add handler for staff to attempt backup restore
ClosedPublic
Actions

Authored by kamil on Wed, Nov 27, 9:45 AM.
Tags
None
Referenced Files
F3522102: D14060.id46180.diff
Mon, Dec 23, 5:46 AM
Unknown Object (File)
Sat, Dec 21, 6:00 PM
Unknown Object (File)
Fri, Dec 20, 8:32 PM
Unknown Object (File)
Sun, Dec 15, 2:21 PM
Unknown Object (File)
Sun, Dec 15, 1:25 PM
Unknown Object (File)
Sun, Dec 15, 7:20 AM
Unknown Object (File)
Wed, Dec 11, 5:12 AM
Unknown Object (File)
Wed, Dec 11, 3:37 AM
View All 28 Files
Subscribers
ashoat

Details

Reviewers
bartek
tomek
Commits
rCOMM618bdb01cda6: [native] add handler for staff to attempt backup restore
Summary

ENG-9711.

Depends on D14059

Test Plan

Update millisecondsPerDay to be lower value and test if this works.

Diff Detail

Repository
rCOMM Comm
Branch
land
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Wed, Nov 27, 9:45 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptWed, Nov 27, 9:45 AM
Harbormaster completed remote builds in B32888: Diff 46103.Wed, Nov 27, 10:10 AM
kamil published this revision for review.Wed, Nov 27, 10:25 AM
kamil added inline comments.
native/backup/backup-handler.js
91–100 ↗(On Diff #46103)

can be done using Promise.all

145–160 ↗(On Diff #46103)

causing another update after 24 hours is intentional for testing purposes and checking stabillity

kamil added a child revision: D14061: [native] handle invalid CSAT in Backup authenticated API.Thu, Nov 28, 4:53 AM
kamil added inline comments.Thu, Nov 28, 6:19 AM
native/backup/backup-handler.js
148–150 ↗(On Diff #46103)
bartek accepted this revision.Fri, Nov 29, 2:59 AM
bartek added inline comments.
native/backup/backup-handler.js
145–160 ↗(On Diff #46103)

Looks reasonable

This revision is now accepted and ready to land.Fri, Nov 29, 2:59 AM
kamil updated this revision to Diff 46180.Tue, Dec 3, 4:22 AM

address notes

Harbormaster completed remote builds in B32919: Diff 46180.Tue, Dec 3, 5:27 AM
Closed by commit rCOMM618bdb01cda6: [native] add handler for staff to attempt backup restore (authored by kamil). · Explain WhyTue, Dec 3, 6:28 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM618bdb01cda6: [native] add handler for staff to attempt backup restore.
kamil mentioned this in D14077: [native] remove comment from `BackupHandler`.Tue, Dec 3, 6:33 AM
kamil mentioned this in rCOMM066e576587e0: [native] remove comment from `BackupHandler`.Wed, Dec 4, 4:38 AM

Revision Contents
Changeset List

PathSize
native/
backup/
78 lines

Diff 46180

View Options

native/backup/backup-handler.js

Loading...