Page MenuHomePhabricator

[backup-client] avoid adding `attachments` when uploading User Keys
AcceptedPublic

Authored by kamil on Thu, Nov 14, 8:03 AM.
Tags
None
Referenced Files
F3332345: D13928.id45818.diff
Wed, Nov 20, 11:47 PM
F3323324: D13928.id.diff
Wed, Nov 20, 3:33 AM
Unknown Object (File)
Tue, Nov 19, 11:26 PM
Unknown Object (File)
Tue, Nov 19, 1:30 AM
Unknown Object (File)
Tue, Nov 19, 12:59 AM
Unknown Object (File)
Mon, Nov 18, 5:13 AM
Unknown Object (File)
Mon, Nov 18, 1:19 AM
Unknown Object (File)
Sun, Nov 17, 2:50 PM
Subscribers

Details

Reviewers
bartek
tomek
Summary

ENG-9656.

On backup service, we parse multipart in sequence, so we're going to read attachments and as a result set siwe_backup_msg to None even if this is present.

The alternative is to completely refactor how we parse Multipart on the service side - but this is quick and clean, as attachments are present only if we have User Data.

Test Plan

Run commtest

Diff Detail

Repository
rCOMM Comm
Branch
publish-client-backup
Lint
No Lint Coverage
Unit
No Test Coverage