Page MenuHomePhabricator

[backup-client] avoid adding `attachments` when uploading User Keys
ClosedPublic

Authored by kamil on Nov 14 2024, 8:03 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 3, 6:25 AM
Unknown Object (File)
Mon, Mar 3, 6:25 AM
Unknown Object (File)
Fri, Feb 28, 2:56 AM
Unknown Object (File)
Fri, Feb 28, 2:56 AM
Unknown Object (File)
Feb 20 2025, 10:17 AM
Unknown Object (File)
Jan 22 2025, 2:06 PM
Unknown Object (File)
Jan 22 2025, 2:06 PM
Unknown Object (File)
Jan 22 2025, 2:06 PM
Subscribers

Details

Summary

ENG-9656.

On backup service, we parse multipart in sequence, so we're going to read attachments and as a result set siwe_backup_msg to None even if this is present.

The alternative is to completely refactor how we parse Multipart on the service side - but this is quick and clean, as attachments are present only if we have User Data.

Test Plan

Run commtest

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable