Page MenuHomePhabricator
Differential D14050

[lib][native] create action to set latest `backupID` on User Keys upload
AcceptedPublic
Actions

Authored by kamil on Tue, Nov 26, 8:07 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 27, 3:18 PM
Unknown Object (File)
Wed, Nov 27, 3:18 PM
Unknown Object (File)
Wed, Nov 27, 3:18 PM
Unknown Object (File)
Wed, Nov 27, 3:18 PM
Unknown Object (File)
Wed, Nov 27, 3:18 PM
Unknown Object (File)
Wed, Nov 27, 3:18 PM
Unknown Object (File)
Wed, Nov 27, 3:18 PM
Unknown Object (File)
Wed, Nov 27, 3:18 PM
View All 24 Files
Subscribers
ashoat

Details

Reviewers
bartek
tomek
Summary

ENG-9701.

Depends on D14049

Test Plan

Call this code:

void dispatchActionPromise(
  createUserKeysBackupActionTypes,
  createUserKeysBackup(),
);

and check if it worked

Diff Detail

Repository
rCOMM Comm
Branch
backup
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Tue, Nov 26, 8:07 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptTue, Nov 26, 8:07 AM
kamil published this revision for review.Tue, Nov 26, 8:08 AM
kamil edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B32869: Diff 46084.Tue, Nov 26, 9:16 AM
kamil added a child revision: D14056: [native] enable backup handler for staff.Wed, Nov 27, 6:44 AM
tomek accepted this revision.Wed, Nov 27, 7:25 AM
tomek added inline comments.
lib/actions/backup-actions.js
4–6

Are you sure we need to use the dispatchActionPromise? Why a single action won't suffice?

lib/reducers/backup-reducer.js
16

The reducer should be pure - in this case, every time it is called, the result will be different. The correct way to solve this issue is to generate the timestamp and put it into action.

This revision is now accepted and ready to land.Wed, Nov 27, 7:25 AM

Revision Contents
Changeset List

PathSize
lib/
actions/
9 lines
reducers/
23 lines
types/
16 lines
native/
redux/
2 lines

Diff 46084

View Options

lib/actions/backup-actions.js

Loading...
View Options

lib/reducers/backup-reducer.js

Loading...
View Options

lib/types/redux-types.js

Loading...
View Options

native/redux/redux-setup.js

Loading...