[native] enable backup handler for staff
ClosedPublic
Actions

Authored by kamil on Nov 27 2024, 6:44 AM.

Details

Reviewers

bartek
tomek

Commits

rCOMM9778c7490289: [native] enable backup handler for staff

Summary

Part of ENG-9604 but only for staff.

Starting Rust thread responsible for uploading Backup. Right now it will be used to upload User Keys only, but in the future, it will be used for User Data and logs.

Adding an alert to log if anything went wrong.

Depends on D14048, D14050

Test Plan

Add additional log to make sure if this is started or not, test it with iOS and Android (background/foreground/background).

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Nov 27 2024, 6:44 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptNov 27 2024, 6:44 AM

add check if device is primary

kamil added a parent revision: D14058: [lib] create a hook to check if device is primary.Nov 27 2024, 9:36 AM

kamil added a child revision: D14059: [native] upload User Keys backup when user is staff.Nov 27 2024, 9:42 AM

Harbormaster completed remote builds in B32886: Diff 46101.Nov 27 2024, 9:55 AM

kamil published this revision for review.Nov 27 2024, 10:18 AM

kamil edited the summary of this revision. (Show Details)

kamil added inline comments.

native/backup/backup-handler.js
23–58 ↗	(On Diff #46101)	Identification changes later in the stack

ashoat added inline comments.Nov 27 2024, 3:06 PM

native/backup/backup-handler.js
39 ↗	(On Diff #46101)	Should we only display this alert to staff?
47 ↗	(On Diff #46101)	Same here

kamil added inline comments.Nov 28 2024, 1:19 AM

native/backup/backup-handler.js
39 ↗	(On Diff #46101)	This code won't be ever executed for non-staff users, it's gated on `staffCanSee` (see line 24). But I can use `useStaffAlert` here to point out that this is staff-specific

bartek accepted this revision.Nov 29 2024, 2:55 AM

bartek added inline comments.

native/backup/backup-handler.js
39 ↗	(On Diff #46101)	By looking at the difference between `useStaffCanSee` and `useIsCurrentUserStaff`, the latter has a check for `isDev` too, and so does the `useStaffAlert`. Shouldn't we de-dupe them somehow?