Page MenuHomePhabricator
Differential D13933

[CommCoreModule] remove capturing logs
ClosedPublic
Actions

Authored by kamil on Nov 14 2024, 8:34 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 21, 11:20 AM
Unknown Object (File)
Sat, Apr 12, 7:54 PM
Unknown Object (File)
Thu, Apr 3, 3:08 AM
Unknown Object (File)
Wed, Apr 2, 10:13 PM
Unknown Object (File)
Wed, Apr 2, 7:37 PM
Unknown Object (File)
Wed, Apr 2, 12:12 AM
Unknown Object (File)
Mar 22 2025, 6:25 PM
Unknown Object (File)
Mar 3 2025, 6:25 AM
View All 49 Files
Subscribers
ashoat

Details

Reviewers
bartek
tomek
Commits
rCOMM31151871843e: [CommCoreModule] remove capturing logs
Summary

ENG-9656.

The decision explained in ENG-9663.

Created ENG-9921 to revert this in the future.

Depends on D13932

Test Plan

N/A - making sure this method is not called anywhere.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
1 line
PersistentStorageUtilities/
DataStores/
1 line

Diff 46011

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

// @flow // @flow
import { useRoute } from '@react-navigation/core';
import * as React from 'react'; import * as React from 'react';
import { Animated, Text, View } from 'react-native';
import { TabBarItem } from 'react-native-tab-view';
import { useCurrentUserFID } from 'lib/utils/farcaster-utils.js'; import { useCurrentUserFID } from 'lib/utils/farcaster-utils.js';
import { createChatTabBarButton } from './chat-tab-bar-button.react.js';
import { backgroundChatThreadListOptions } from '../chat/chat-options.js'; import { backgroundChatThreadListOptions } from '../chat/chat-options.js';
import { useSelector } from '../redux/redux-utils.js';
import { useStyles } from '../themes/colors.js';
import { LightTheme, DarkTheme } from '../themes/navigation.js';
import { import {
type NUXTipsOverlayProps, type NUXTipsOverlayProps,
createNUXTipsOverlay, createNUXTipsOverlay,
} from '../tooltip/nux-tips-overlay.react.js'; } from '../tooltip/nux-tips-overlay.react.js';
const mutedTabTipTextBase = const mutedTabTipTextBase =
'When you mute a chat, it automatically gets moved to this tab.'; 'When you mute a chat, it automatically gets moved to this tab.';
const mutedTabTipTextIfFID = const mutedTabTipTextIfFID =
' When Comm automatically adds you to a community associated with a ' + ' When Comm automatically adds you to a community associated with a ' +
'Farcaster channel you follow, we mute them by default.'; 'Farcaster channel you follow, we mute them by default.';
const dummyCallback = () => {};
const dummyNavigationState = { index: 0, routes: [] };
const unboundStyles = {
button: {
flexDirection: 'row',
backgroundColor: 'tabBarBackground',
},
label: {
textAlign: 'center',
textTransform: 'uppercase',
fontSize: 13,
margin: 4,
backgroundColor: 'transparent',
},
icon: {
height: 24,
width: 24,
},
};
function WrappedChatTabBarButton(): React.Node {
const { title, tabBarIcon: Icon } = backgroundChatThreadListOptions;
const position = React.useRef(() => new Animated.Value(0));
const route = useRoute();
const activeTheme = useSelector(state => state.globalThemeInfo.activeTheme);
const color = React.useMemo(
() =>
activeTheme === 'dark' ? DarkTheme.colors.text : LightTheme.colors.text,
[activeTheme],
);
const styles = useStyles(unboundStyles);
const renderLabel = React.useCallback(
({ color: labelColor }: { color: string, ... }) => {
return <Text style={[styles.label, { color: labelColor }]}>{title}</Text>;
},
[styles.label, title],
);
const renderIcon = React.useCallback(
({ color: iconColor }: { color: string, ... }) => {
return (
<View style={styles.icon}>
<Icon color={iconColor} />
</View>
);
},
[styles.icon],
);
const renderLabelText = React.useCallback(() => title, [title]);
return (
<TabBarItem
position={position.current}
route={route}
navigationState={dummyNavigationState}
onPress={dummyCallback}
onLongPress={dummyCallback}
style={styles.button}
getLabelText={renderLabelText}
getAccessible={dummyCallback}
getAccessibilityLabel={dummyCallback}
renderIcon={renderIcon}
getTestID={dummyCallback}
activeColor={color}
renderLabel={renderLabel}
/>
);
}
function MutedTabTip(props: NUXTipsOverlayProps<'MutedTabTip'>): React.Node { function MutedTabTip(props: NUXTipsOverlayProps<'MutedTabTip'>): React.Node {
const fid = useCurrentUserFID(); const fid = useCurrentUserFID();
const text = React.useMemo(() => { const text = React.useMemo(() => {
if (!fid) { if (!fid) {
return mutedTabTipTextBase; return mutedTabTipTextBase;
} }
return mutedTabTipTextBase + mutedTabTipTextIfFID; return mutedTabTipTextBase + mutedTabTipTextIfFID;
}, [fid]); }, [fid]);
const MutedTabTipComponent: React.ComponentType< const MutedTabTipComponent: React.ComponentType<
NUXTipsOverlayProps<'MutedTabTip'>, NUXTipsOverlayProps<'MutedTabTip'>,
> = createNUXTipsOverlay(WrappedChatTabBarButton, text); > = createNUXTipsOverlay(
createChatTabBarButton<'MutedTabTip'>(backgroundChatThreadListOptions),
text,
);
return <MutedTabTipComponent {...props} />; return <MutedTabTipComponent {...props} />;
} }
export default MutedTabTip; export default MutedTabTip;
View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/BaseDataStore.h

// @flow // @flow
import { useRoute } from '@react-navigation/core';
import * as React from 'react'; import * as React from 'react';
import { Animated, Text, View } from 'react-native';
import { TabBarItem } from 'react-native-tab-view';
import { useCurrentUserFID } from 'lib/utils/farcaster-utils.js'; import { useCurrentUserFID } from 'lib/utils/farcaster-utils.js';
import { createChatTabBarButton } from './chat-tab-bar-button.react.js';
import { backgroundChatThreadListOptions } from '../chat/chat-options.js'; import { backgroundChatThreadListOptions } from '../chat/chat-options.js';
import { useSelector } from '../redux/redux-utils.js';
import { useStyles } from '../themes/colors.js';
import { LightTheme, DarkTheme } from '../themes/navigation.js';
import { import {
type NUXTipsOverlayProps, type NUXTipsOverlayProps,
createNUXTipsOverlay, createNUXTipsOverlay,
} from '../tooltip/nux-tips-overlay.react.js'; } from '../tooltip/nux-tips-overlay.react.js';
const mutedTabTipTextBase = const mutedTabTipTextBase =
'When you mute a chat, it automatically gets moved to this tab.'; 'When you mute a chat, it automatically gets moved to this tab.';
const mutedTabTipTextIfFID = const mutedTabTipTextIfFID =
' When Comm automatically adds you to a community associated with a ' + ' When Comm automatically adds you to a community associated with a ' +
'Farcaster channel you follow, we mute them by default.'; 'Farcaster channel you follow, we mute them by default.';
const dummyCallback = () => {};
const dummyNavigationState = { index: 0, routes: [] };
const unboundStyles = {
button: {
flexDirection: 'row',
backgroundColor: 'tabBarBackground',
},
label: {
textAlign: 'center',
textTransform: 'uppercase',
fontSize: 13,
margin: 4,
backgroundColor: 'transparent',
},
icon: {
height: 24,
width: 24,
},
};
function WrappedChatTabBarButton(): React.Node {
const { title, tabBarIcon: Icon } = backgroundChatThreadListOptions;
const position = React.useRef(() => new Animated.Value(0));
const route = useRoute();
const activeTheme = useSelector(state => state.globalThemeInfo.activeTheme);
const color = React.useMemo(
() =>
activeTheme === 'dark' ? DarkTheme.colors.text : LightTheme.colors.text,
[activeTheme],
);
const styles = useStyles(unboundStyles);
const renderLabel = React.useCallback(
({ color: labelColor }: { color: string, ... }) => {
return <Text style={[styles.label, { color: labelColor }]}>{title}</Text>;
},
[styles.label, title],
);
const renderIcon = React.useCallback(
({ color: iconColor }: { color: string, ... }) => {
return (
<View style={styles.icon}>
<Icon color={iconColor} />
</View>
);
},
[styles.icon],
);
const renderLabelText = React.useCallback(() => title, [title]);
return (
<TabBarItem
position={position.current}
route={route}
navigationState={dummyNavigationState}
onPress={dummyCallback}
onLongPress={dummyCallback}
style={styles.button}
getLabelText={renderLabelText}
getAccessible={dummyCallback}
getAccessibilityLabel={dummyCallback}
renderIcon={renderIcon}
getTestID={dummyCallback}
activeColor={color}
renderLabel={renderLabel}
/>
);
}
function MutedTabTip(props: NUXTipsOverlayProps<'MutedTabTip'>): React.Node { function MutedTabTip(props: NUXTipsOverlayProps<'MutedTabTip'>): React.Node {
const fid = useCurrentUserFID(); const fid = useCurrentUserFID();
const text = React.useMemo(() => { const text = React.useMemo(() => {
if (!fid) { if (!fid) {
return mutedTabTipTextBase; return mutedTabTipTextBase;
} }
return mutedTabTipTextBase + mutedTabTipTextIfFID; return mutedTabTipTextBase + mutedTabTipTextIfFID;
}, [fid]); }, [fid]);
const MutedTabTipComponent: React.ComponentType< const MutedTabTipComponent: React.ComponentType<
NUXTipsOverlayProps<'MutedTabTip'>, NUXTipsOverlayProps<'MutedTabTip'>,
> = createNUXTipsOverlay(WrappedChatTabBarButton, text); > = createNUXTipsOverlay(
createChatTabBarButton<'MutedTabTip'>(backgroundChatThreadListOptions),
text,
);
return <MutedTabTipComponent {...props} />; return <MutedTabTipComponent {...props} />;
} }
export default MutedTabTip; export default MutedTabTip;