Page MenuHomePhabricator
Differential D14024

[native] Handle invalid CSAT in Identity RPCs
AcceptedPublic
Actions

Authored by bartek on Sun, Nov 24, 11:27 PM.

Details

Reviewers
kamil
varun
Summary

Part of ENG-6664

Depends on D13992

Test Plan

Manual testing with mocked invalid access token. Identity authed RPC calls end up with logout.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Sun, Nov 24, 11:27 PM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptSun, Nov 24, 11:27 PM
bartek added a child revision: D14025: [web] Handle invalid CSAT in Identity client.Sun, Nov 24, 11:29 PM
Harbormaster completed remote builds in B32791: Diff 45978.Sun, Nov 24, 11:52 PM
bartek published this revision for review.Mon, Nov 25, 2:08 AM
kamil accepted this revision.Mon, Nov 25, 5:09 AM
kamil added inline comments.
native/identity-service/identity-service-context-provider.react.js
117 ↗(On Diff #45978)

should this be includes('bad_credentials')?

also, maybe worth combining with D14029 and putting bad_credentials into shared constant, something like this

This revision is now accepted and ready to land.Mon, Nov 25, 5:09 AM
kamil mentioned this in D14025: [web] Handle invalid CSAT in Identity client.Mon, Nov 25, 5:10 AM
bartek added inline comments.Tue, Nov 26, 4:31 AM
native/identity-service/identity-service-context-provider.react.js
117 ↗(On Diff #45978)

We don't use constants for client-side error code handling, but maybe we should. E.g. here

For includes, it's the same story as in https://phab.comm.dev/D14029#inline-78764 - native-rust-library takes care of the correct format

bartek updated this revision to Diff 46059.Tue, Nov 26, 4:32 AM

Rebase

Harbormaster completed remote builds in B32844: Diff 46059.Tue, Nov 26, 5:24 AM
bartek mentioned this in D13992: [native][web] Handle invalid CSAT in input-state-containers.Tue, Nov 26, 6:19 AM
kamil added a child revision: D14061: [native] handle invalid CSAT in Backup authenticated API.Thu, Nov 28, 4:52 AM
kamil mentioned this in D14061: [native] handle invalid CSAT in Backup authenticated API.Thu, Nov 28, 4:53 AM
kamil removed a child revision: D14061: [native] handle invalid CSAT in Backup authenticated API.

Revision Contents
Changeset List

PathSize
native/
identity-service/
184 lines

Diff 46059

View Options

native/identity-service/identity-service-context-provider.react.js

Loading...