Page MenuHomePhabricator
Differential D14024

[native] Handle invalid CSAT in Identity RPCs
ClosedPublic
Actions

Authored by bartek on Nov 24 2024, 11:27 PM.
Tags
None
Referenced Files
F3602979: D14024.id46059.diff
Tue, Dec 31, 9:45 AM
Unknown Object (File)
Sat, Dec 28, 11:19 PM
Unknown Object (File)
Sat, Dec 28, 6:52 PM
Unknown Object (File)
Sat, Dec 28, 4:47 PM
Unknown Object (File)
Fri, Dec 27, 3:06 AM
Unknown Object (File)
Thu, Dec 26, 6:27 AM
Unknown Object (File)
Thu, Dec 26, 5:51 AM
Unknown Object (File)
Thu, Dec 26, 5:51 AM
View All 28 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
varun
Commits
rCOMMf2473ee529d9: [native] Handle invalid CSAT in Identity RPCs
Summary

Part of ENG-6664

Depends on D13992

Test Plan

Manual testing with mocked invalid access token. Identity authed RPC calls end up with logout.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Nov 24 2024, 11:27 PM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 24 2024, 11:27 PM
bartek added a child revision: D14025: [web] Handle invalid CSAT in Identity client.Nov 24 2024, 11:29 PM
Harbormaster completed remote builds in B32791: Diff 45978.Nov 24 2024, 11:52 PM
bartek published this revision for review.Nov 25 2024, 2:08 AM
kamil accepted this revision.Nov 25 2024, 5:09 AM
kamil added inline comments.
native/identity-service/identity-service-context-provider.react.js
117 ↗(On Diff #45978)

should this be includes('bad_credentials')?

also, maybe worth combining with D14029 and putting bad_credentials into shared constant, something like this

This revision is now accepted and ready to land.Nov 25 2024, 5:09 AM
kamil mentioned this in D14025: [web] Handle invalid CSAT in Identity client.Nov 25 2024, 5:10 AM
bartek added inline comments.Nov 26 2024, 4:31 AM
native/identity-service/identity-service-context-provider.react.js
117 ↗(On Diff #45978)

We don't use constants for client-side error code handling, but maybe we should. E.g. here

For includes, it's the same story as in https://phab.comm.dev/D14029#inline-78764 - native-rust-library takes care of the correct format

bartek updated this revision to Diff 46059.Nov 26 2024, 4:32 AM

Rebase

Harbormaster completed remote builds in B32844: Diff 46059.Nov 26 2024, 5:24 AM
bartek mentioned this in D13992: [native][web] Handle invalid CSAT in input-state-containers.Nov 26 2024, 6:19 AM
kamil added a child revision: D14061: [native] handle invalid CSAT in Backup authenticated API.Nov 28 2024, 4:52 AM
kamil mentioned this in D14061: [native] handle invalid CSAT in Backup authenticated API.Nov 28 2024, 4:53 AM
kamil removed a child revision: D14061: [native] handle invalid CSAT in Backup authenticated API.
Closed by commit rCOMMf2473ee529d9: [native] Handle invalid CSAT in Identity RPCs (authored by bartek). · Explain WhyNov 29 2024, 5:03 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMMf2473ee529d9: [native] Handle invalid CSAT in Identity RPCs.
kamil mentioned this in rCOMM12c361f274a5: [native] handle invalid CSAT in Backup authenticated API.Tue, Dec 3, 6:28 AM

Revision Contents
Changeset List

PathSize
native/
identity-service/
184 lines

Diff 46140

View Options

native/identity-service/identity-service-context-provider.react.js

Loading...