Paths

Table of Contentst

Differential D14026

[keyserver] Extract uploadOneTimeKeys to a separate function
ClosedPublic
Actions

Authored by bartek on Nov 24 2024, 11:30 PM.

Tags

None

Referenced Files

	F3604539: D14026.id46061.diff
	Tue, Dec 31, 1:16 PM

	Unknown Object (File)
	Mon, Dec 30, 5:06 AM

	Unknown Object (File)
	Mon, Dec 30, 3:05 AM

	Unknown Object (File)
	Sun, Dec 29, 4:40 AM

	Unknown Object (File)
	Thu, Dec 26, 5:51 AM

	Unknown Object (File)
	Thu, Dec 26, 5:51 AM

	Unknown Object (File)
	Thu, Dec 26, 5:51 AM

	Unknown Object (File)
	Thu, Dec 26, 5:45 AM

View All 31 Files

Subscribers

Details

Reviewers

varun
kamil

Commits

rCOMMfecc90b1316d: [keyserver] Extract uploadOneTimeKeys to a separate function

Summary

Needed for ENG-6544 to handle invalid auth from one place

Test Plan

Flow, ran keyserver locally

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Nov 24 2024, 11:30 PM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 24 2024, 11:30 PM

bartek added a child revision: D14027: [keyserver] Extract publishPrekeys to a separate function.Nov 24 2024, 11:30 PM

Harbormaster completed remote builds in B32793: Diff 45980.Nov 24 2024, 11:55 PM

bartek published this revision for review.Nov 25 2024, 2:06 AM

kamil accepted this revision.Nov 25 2024, 4:33 AM

kamil added inline comments.

keyserver/src/utils/olm-utils.js
211 ↗	(On Diff #45980)	Looking in the diffs later in the stack, `verifyUserLoggedIn` is called in extracted functions and also in all other functions in `/identity-utils.js`. I would do the same here

This revision is now accepted and ready to land.Nov 25 2024, 4:34 AM

bartek added inline comments.Nov 26 2024, 4:34 AM

keyserver/src/utils/olm-utils.js
211 ↗	(On Diff #45980)	I left it on purpose because in between some Olm actions are performed, which can be skipped when identity info is null

Rebase

Harbormaster completed remote builds in B32846: Diff 46061.Nov 26 2024, 5:43 AM

Closed by commit rCOMMfecc90b1316d: [keyserver] Extract uploadOneTimeKeys to a separate function (authored by bartek). · Explain WhyNov 29 2024, 5:03 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMfecc90b1316d: [keyserver] Extract uploadOneTimeKeys to a separate function.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

utils/

identity-utils.js

20 lines

16 lines

Diff 46143

keyserver/src/utils/identity-utils.js

Loading...

keyserver/src/utils/olm-utils.js

Loading...