[keyserver] Extract uploadOneTimeKeys to a separate function
AcceptedPublic
Actions

Authored by bartek on Sun, Nov 24, 11:30 PM.

Details

Reviewers

varun
kamil

Summary

Needed for ENG-6544 to handle invalid auth from one place

Test Plan

Flow, ran keyserver locally

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Sun, Nov 24, 11:30 PM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptSun, Nov 24, 11:30 PM

bartek added a child revision: D14027: [keyserver] Extract publishPrekeys to a separate function.Sun, Nov 24, 11:30 PM

Harbormaster completed remote builds in B32793: Diff 45980.Sun, Nov 24, 11:55 PM

bartek published this revision for review.Mon, Nov 25, 2:06 AM

kamil accepted this revision.Mon, Nov 25, 4:33 AM

kamil added inline comments.

keyserver/src/utils/olm-utils.js
211 ↗	(On Diff #45980)	Looking in the diffs later in the stack, `verifyUserLoggedIn` is called in extracted functions and also in all other functions in `/identity-utils.js`. I would do the same here

This revision is now accepted and ready to land.Mon, Nov 25, 4:34 AM

bartek added inline comments.Tue, Nov 26, 4:34 AM

keyserver/src/utils/olm-utils.js
211 ↗	(On Diff #45980)	I left it on purpose because in between some Olm actions are performed, which can be skipped when identity info is null

Rebase

Harbormaster completed remote builds in B32846: Diff 46061.Tue, Nov 26, 5:43 AM

Revision Contents
Changeset List

Path

Size

keyserver/

src/

utils/

identity-utils.js

20 lines

olm-utils.js

16 lines

Diff 46061

View Options

keyserver/src/utils/identity-utils.js