Page MenuHomePhabricator
Differential D13957

[keyserver] Add function to clear identity metadata
ClosedPublic
Actions

Authored by bartek on Nov 18 2024, 6:50 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 16, 2:31 AM
Unknown Object (File)
Mon, Dec 16, 2:31 AM
Unknown Object (File)
Fri, Dec 13, 8:52 PM
Unknown Object (File)
Fri, Dec 13, 1:37 AM
Unknown Object (File)
Mon, Dec 9, 6:43 AM
Unknown Object (File)
Thu, Dec 5, 7:34 PM
Unknown Object (File)
Wed, Dec 4, 8:49 PM
Unknown Object (File)
Tue, Dec 3, 5:49 PM
View All 25 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
kamil
ashoat
Commits
rCOMMf7dc430e45e4: [keyserver] Add function to clear identity metadata
Summary

Partially addresses ENG-6545.
Added a function to clear user ID and access token from metadata table. It's going to be called when service authentication fails.

Test Plan

Called this function manually and verified in TablePlus that these rows were removed. Calling verifyUserLoggedIn() creates them again.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Nov 18 2024, 6:50 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 18 2024, 6:50 AM
Harbormaster completed remote builds in B32698: Diff 45864.Nov 18 2024, 7:26 AM
bartek added a child revision: D13988: [lib][keyserver] Handle invalid CSAT in BlobOperationResult.Nov 21 2024, 3:58 AM
bartek published this revision for review.Nov 21 2024, 9:13 AM
varun accepted this revision.Nov 21 2024, 11:09 AM
This revision is now accepted and ready to land.Nov 21 2024, 11:09 AM
ashoat accepted this revision.Nov 21 2024, 6:24 PM
ashoat added inline comments.
keyserver/src/user/identity.js
131 ↗(On Diff #45864)

Nit: this query will crash if passed an empty array. We don't do that currently, but I've seen this accidentally happen enough times that I usually try to cover it

136 ↗(On Diff #45864)

I think it would be better to return Promise<void>. The QueryResult type has some anys and you never seem to use it from any of the callsites of clearMetadata currently in this stack

bartek added a child revision: D14030: [keyserver] Handle invalid CSAT in Tunnelbroker socket.Mon, Nov 25, 4:10 AM
bartek updated this revision to Diff 46038.Mon, Nov 25, 7:31 AM

Add zero-length check, return Promise<void>

Harbormaster completed remote builds in B32828: Diff 46038.Mon, Nov 25, 9:06 AM
Closed by commit rCOMMf7dc430e45e4: [keyserver] Add function to clear identity metadata (authored by bartek). · Explain WhyFri, Nov 29, 5:02 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMMf7dc430e45e4: [keyserver] Add function to clear identity metadata.

Revision Contents
Changeset List

PathSize
keyserver/
src/
user/
18 lines

Diff 46132

View Options

keyserver/src/user/identity.js

Loading...