Page MenuHomePhabricator
Differential D14028

[keyserver] Extract getInboundKeys to a separate function
ClosedPublic
Actions

Authored by bartek on Nov 24 2024, 11:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 27, 2:02 PM
Unknown Object (File)
Mon, Mar 24, 2:15 AM
Unknown Object (File)
Mar 5 2025, 8:29 PM
Unknown Object (File)
Mar 5 2025, 8:29 PM
Unknown Object (File)
Mar 5 2025, 8:29 PM
Unknown Object (File)
Mar 5 2025, 8:29 PM
Unknown Object (File)
Mar 5 2025, 8:29 PM
Unknown Object (File)
Mar 3 2025, 6:21 AM
View All 41 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
kamil
Commits
rCOMMd6994b2823f0: [keyserver] Extract getInboundKeys to a separate function
Summary

Needed for ENG-6544 to handle invalid auth from one place

Depends on D14027

Test Plan

Flow, ran keyserver locally

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
keyserver/
src/
responders/
28 lines
utils/
30 lines

Diff 46145

View Options

keyserver/src/responders/user-responders.js

// @flow // @flow
import base64 from 'base-64'; import base64 from 'base-64';
import { getMessageForException } from './errors.js';
import type { AuthMetadata } from '../shared/identity-client-context.js'; import type { AuthMetadata } from '../shared/identity-client-context.js';
// If this is true then we're using the identity service for auth. After we // If this is true then we're using the identity service for auth. After we
// auth, the identity service gives us a CSAT, which we can use to auth with // auth, the identity service gives us a CSAT, which we can use to auth with
// other Comm services. // other Comm services.
const usingCommServicesAccessToken = true; const usingCommServicesAccessToken = true;
// If this is true, then the app is able to support multiple keyservers. This // If this is true, then the app is able to support multiple keyservers. This
Show All 22 Linesfunction createDefaultHTTPRequestHeaders(authMetadata: AuthMetadata): {
[string]: string, [string]: string,
} { } {
const authorization = createHTTPAuthorizationHeader(authMetadata); const authorization = createHTTPAuthorizationHeader(authMetadata);
return { return {
Authorization: authorization, Authorization: authorization,
}; };
} }
function httpResponseIsInvalidCSAT(response: Response): boolean {
const { status } = response;
return status === 401 || status === 403;
}
function errorMessageIsInvalidCSAT(exception: mixed): boolean {
const errorMessage = getMessageForException(exception);
return errorMessage === 'invalid_csat';
}
export { export {
usingCommServicesAccessToken, usingCommServicesAccessToken,
supportingMultipleKeyservers, supportingMultipleKeyservers,
relyingOnAuthoritativeKeyserver, relyingOnAuthoritativeKeyserver,
usingRestoreFlow, usingRestoreFlow,
createHTTPAuthorizationHeader, createHTTPAuthorizationHeader,
createDefaultHTTPRequestHeaders, createDefaultHTTPRequestHeaders,
httpResponseIsInvalidCSAT,
errorMessageIsInvalidCSAT,
}; };
View Options

keyserver/src/utils/identity-utils.js

// @flow // @flow
import base64 from 'base-64'; import base64 from 'base-64';
import { getMessageForException } from './errors.js';
import type { AuthMetadata } from '../shared/identity-client-context.js'; import type { AuthMetadata } from '../shared/identity-client-context.js';
// If this is true then we're using the identity service for auth. After we // If this is true then we're using the identity service for auth. After we
// auth, the identity service gives us a CSAT, which we can use to auth with // auth, the identity service gives us a CSAT, which we can use to auth with
// other Comm services. // other Comm services.
const usingCommServicesAccessToken = true; const usingCommServicesAccessToken = true;
// If this is true, then the app is able to support multiple keyservers. This // If this is true, then the app is able to support multiple keyservers. This
Show All 22 Linesfunction createDefaultHTTPRequestHeaders(authMetadata: AuthMetadata): {
[string]: string, [string]: string,
} { } {
const authorization = createHTTPAuthorizationHeader(authMetadata); const authorization = createHTTPAuthorizationHeader(authMetadata);
return { return {
Authorization: authorization, Authorization: authorization,
}; };
} }
function httpResponseIsInvalidCSAT(response: Response): boolean {
const { status } = response;
return status === 401 || status === 403;
}
function errorMessageIsInvalidCSAT(exception: mixed): boolean {
const errorMessage = getMessageForException(exception);
return errorMessage === 'invalid_csat';
}
export { export {
usingCommServicesAccessToken, usingCommServicesAccessToken,
supportingMultipleKeyservers, supportingMultipleKeyservers,
relyingOnAuthoritativeKeyserver, relyingOnAuthoritativeKeyserver,
usingRestoreFlow, usingRestoreFlow,
createHTTPAuthorizationHeader, createHTTPAuthorizationHeader,
createDefaultHTTPRequestHeaders, createDefaultHTTPRequestHeaders,
httpResponseIsInvalidCSAT,
errorMessageIsInvalidCSAT,
}; };