Page MenuHomePhabricator
Differential D14058

[lib] create a hook to check if device is primary
ClosedPublic
Actions

Authored by kamil on Wed, Nov 27, 9:30 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 1, 11:36 PM
Unknown Object (File)
Sun, Dec 1, 7:07 AM
Unknown Object (File)
Sat, Nov 30, 4:47 PM
Unknown Object (File)
Sat, Nov 30, 1:37 PM
Unknown Object (File)
Wed, Nov 27, 3:22 PM
Unknown Object (File)
Wed, Nov 27, 3:22 PM
Unknown Object (File)
Wed, Nov 27, 3:22 PM
Unknown Object (File)
Wed, Nov 27, 3:22 PM
View All 16 Files
Subscribers
ashoat

Details

Reviewers
bartek
tomek
Commits
rCOMM1c4a54aec179: [lib] create a hook to check if device is primary
Summary

The fact that this is asynchronous is painful but this is caused by ENG-8192.

Creatin hook to avoid code duplication

Test Plan

Log result and check if this works on primary and non-primary

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Wed, Nov 27, 9:30 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptWed, Nov 27, 9:31 AM
kamil added a child revision: D14056: [native] enable backup handler for staff.Wed, Nov 27, 9:36 AM
Harbormaster completed remote builds in B32885: Diff 46100.Wed, Nov 27, 9:52 AM
kamil published this revision for review.Wed, Nov 27, 10:17 AM
kamil edited the summary of this revision. (Show Details)
kamil mentioned this in D14063: [native] allow password change only on primary device.Thu, Nov 28, 5:29 AM
bartek accepted this revision.Fri, Nov 29, 3:16 AM
bartek added inline comments.
lib/hooks/primary-device-hooks.js
22 ↗(On Diff #46100)

Alternatively, you can use await getContentSigningKey() from lib/utils/crypto-utils.js to get just deviceID and avoid relying on Identity context

This revision is now accepted and ready to land.Fri, Nov 29, 3:16 AM
kamil added inline comments.Mon, Dec 2, 6:53 AM
lib/hooks/primary-device-hooks.js
22 ↗(On Diff #46100)

It's basically the same, but I prefer using getAuthMetadata() as this is what we use a lot more in the codebase. Overall, we should aim to get ENG-8192 done as a future solution.

Closed by commit rCOMM1c4a54aec179: [lib] create a hook to check if device is primary (authored by kamil). · Explain WhyMon, Dec 2, 6:54 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM1c4a54aec179: [lib] create a hook to check if device is primary.
kamil mentioned this in rCOMM99f4e4a6ccef: [native] allow password change only on primary device.Tue, Dec 3, 6:28 AM

Revision Contents
Changeset List

PathSize
lib/
hooks/
27 lines
native/
account/
registration/
missing-registration-data/
27 lines

Diff 46163

View Options

lib/hooks/primary-device-hooks.js

Loading...
View Options

native/account/registration/missing-registration-data/missing-registration-data-handler.react.js

Loading...