[CryptoModule] store only pickled Olm Account in User Keys Backup
ClosedPublic
Actions

Authored by kamil on Nov 26 2024, 3:29 AM.

Details

Reviewers

bartek
tomek

Commits

rCOMM0f805007b641: [CryptoModule] store only pickled Olm Account in User Keys Backup

Summary

Discussed in ENG-9659.

Restoring should work without changes, session set will be empty.

Depends on D14005

Test Plan

Test creating User Keys backup

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Nov 26 2024, 3:29 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptNov 26 2024, 3:29 AM

Harbormaster completed remote builds in B32835: Diff 46050.Nov 26 2024, 3:47 AM

kamil added a child revision: D14045: [CryptoModule] remove `CryptoAccountID`.Nov 26 2024, 3:50 AM

kamil published this revision for review.Nov 26 2024, 4:09 AM

Nit: Names are now a bit divergent: pickleAccountToString for account-only, and storeAsB64 for account+sessions but return types differ too. IMO storeAsB64 is misleading because Persist type isn't base64.

This revision is now accepted and ready to land.Nov 26 2024, 7:11 AM

In D14044#391456, @bartek wrote:

Nit: Names are now a bit divergent: pickleAccountToString for account-only, and storeAsB64 for account+sessions but return types differ too. IMO storeAsB64 is misleading because Persist type isn't base64.

Good call. This is not related to my changes but to old code which was around for a while so I created ENG-9970.

Closed by commit rCOMM0f805007b641: [CryptoModule] store only pickled Olm Account in User Keys Backup (authored by kamil). · Explain WhyTue, Dec 3, 6:28 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM0f805007b641: [CryptoModule] store only pickled Olm Account in User Keys Backup.