Page MenuHomePhabricator
Differential D14044

[CryptoModule] store only pickled Olm Account in User Keys Backup
AcceptedPublic
Actions

Authored by kamil on Tue, Nov 26, 3:29 AM.
Tags
None
Referenced Files
F3388485: D14044.diff
Fri, Nov 29, 2:33 PM
Unknown Object (File)
Tue, Nov 26, 8:44 PM
Unknown Object (File)
Tue, Nov 26, 8:44 PM
Unknown Object (File)
Tue, Nov 26, 8:44 PM
Unknown Object (File)
Tue, Nov 26, 8:44 PM
Unknown Object (File)
Tue, Nov 26, 8:44 PM
Unknown Object (File)
Tue, Nov 26, 8:44 PM
Unknown Object (File)
Tue, Nov 26, 8:44 PM
View All 14 Files
Subscribers
ashoat

Details

Reviewers
bartek
tomek
Summary

Discussed in ENG-9659.

Restoring should work without changes, session set will be empty.

Depends on D14005

Test Plan

Test creating User Keys backup

Diff Detail

Repository
rCOMM Comm
Branch
backup
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Tue, Nov 26, 3:29 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptTue, Nov 26, 3:29 AM
Harbormaster completed remote builds in B32835: Diff 46050.Tue, Nov 26, 3:47 AM
kamil added a child revision: D14045: [CryptoModule] remove `CryptoAccountID`.Tue, Nov 26, 3:50 AM
kamil published this revision for review.Tue, Nov 26, 4:09 AM
bartek accepted this revision.Tue, Nov 26, 7:11 AM

Nit: Names are now a bit divergent: pickleAccountToString for account-only, and storeAsB64 for account+sessions but return types differ too. IMO storeAsB64 is misleading because Persist type isn't base64.

This revision is now accepted and ready to land.Tue, Nov 26, 7:11 AM

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
CryptoTools/
2 lines
41 lines
NativeModules/
8 lines

Diff 46050

View Options

native/cpp/CommonCpp/CryptoTools/CryptoModule.h

Loading...
View Options

native/cpp/CommonCpp/CryptoTools/CryptoModule.cpp

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...