Page MenuHomePhabricator
Differential D12805

[lib] introduce new device list function to replace keyserver device
ClosedPublic
Actions

Authored by varun on Jul 19 2024, 12:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 25, 2:38 AM
Unknown Object (File)
Fri, Oct 25, 2:38 AM
Unknown Object (File)
Fri, Oct 25, 2:38 AM
Unknown Object (File)
Mon, Oct 21, 10:25 PM
Unknown Object (File)
Oct 3 2024, 3:27 AM
Unknown Object (File)
Sep 28 2024, 6:54 PM
Unknown Object (File)
Sep 25 2024, 1:31 AM
Unknown Object (File)
Sep 25 2024, 1:31 AM
View All 51 Files
Subscribers
tomek

Details

Reviewers
bartek
ashoat
Commits
rCOMMc65be4f84cff: [lib] introduce new device list function to replace keyserver device
Summary

we want to be able to replace an existing keyserver with a new one

Depends on D12734

Test Plan

later in the diff stack I successfully replace my existing keyserver device with a new one

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Jul 19 2024, 12:52 PM
Herald added a subscriber: tomek. · View Herald TranscriptJul 19 2024, 12:52 PM
Harbormaster completed remote builds in B30515: Diff 42550.Jul 19 2024, 1:09 PM
varun requested review of this revision.Jul 19 2024, 1:09 PM
varun added a child revision: D12809: [lib] add new selector and function to get own user's keyserver device ID.Jul 19 2024, 2:18 PM
bartek requested changes to this revision.Jul 22 2024, 1:36 AM
bartek added inline comments.
lib/shared/device-list-utils.js
236–240 ↗(On Diff #42550)

What if the old device is not on the list, but the new one is not?
I think we should continue adding it in that case.

Otherwise, this function would return successfully without the device list being updated

This revision now requires changes to proceed.Jul 22 2024, 1:36 AM
varun updated this revision to Diff 42792.Jul 25 2024, 8:37 PM

address feedback

Harbormaster completed remote builds in B30681: Diff 42792.Jul 25 2024, 8:53 PM
bartek accepted this revision.Jul 26 2024, 1:56 AM
This revision is now accepted and ready to land.Jul 26 2024, 1:56 AM
Closed by commit rCOMMc65be4f84cff: [lib] introduce new device list function to replace keyserver device (authored by varun). · Explain WhyAug 22 2024, 9:24 AM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMMc65be4f84cff: [lib] introduce new device list function to replace keyserver device.

Revision Contents
Changeset List

PathSize
lib/
shared/
30 lines

Diff 42792

View Options

lib/shared/device-list-utils.js

Loading...