Improve the logic
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Jul 24 2024
Jul 24 2024
Harbormaster failed remote builds in B30640: Diff 42735 for D12748: Expose function to get notifs inbound keys to C++!
Harbormaster failed remote builds in B30637: Diff 42733 for D12836: Patch localforage to support transactional multiple items retrieval/persistence!
Harbormaster failed remote builds in B30636: Diff 42732 for D12677: Implement method to query identity service from the NSE!
Harbormaster failed remote builds in B30635: Diff 42731 for D12676: Migrate notifications crypto account to MMKV on native!
Harbormaster failed remote builds in B30634: Diff 42730 for D12673: Utilities to idempotently create content and notif sessions!
I'd prefer to also validate on the JS side, but it isn't a strong opinion.
Harbormaster failed remote builds in B30633: Diff 42729 for D12672: Implement utility functions to check if we have content or notif session with device!
Harbormaster failed remote builds in B30632: Diff 42728 for D12670: Implement notification encryption on native!
Address review
marcin updated the diff for D12703: Transfer CSAT to IndexedDB from service worker and implement call to identity to query for inbound keys.
Address review
marcin updated the diff for D12836: Patch localforage to support transactional multiple items retrieval/persistence.
Addres review
Address review
Address review
Address review
marcin updated the diff for D12672: Implement utility functions to check if we have content or notif session with device.
Address review
Harbormaster failed remote builds in B30630: Diff 42726 for D12668: Implement peer notifications session creation as outbound on native!
Have you tested it on both platforms?
Address review
marcin updated the diff for D12669: Implement peer notifications session creation as outbound on web and add notifs outbound session creator to OlmAPI.
Address review
marcin updated the diff for D12668: Implement peer notifications session creation as outbound on native.
Address review
In D12692#361481, @kamil wrote:Right now two JS threads (shared worker and service worker) can concurrently modify the same key in IndexedDB. I think to make it safe we should use transactions to make sure this is safe.
Unfortunately, looks like locaforage is not supporting this: https://github.com/localForage/localForage/issues/582 and https://github.com/localForage/localForage/issues/17.
Could you do some research about whether it's safe or suggest an alternative solution?
(this could change most of the code so not reviewing details of this diff)
marcin added a comment to D12836: Patch localforage to support transactional multiple items retrieval/persistence.
About to create fork with PR shortly
In D12677#361397, @bartek wrote:The HTTP request-response logic looks good; it's analogous to the existing Blob GET request logic.
Accepting but please remember to fix that semicolon. Otherwise, release builds will fail.
marcin added inline comments to D12672: Implement utility functions to check if we have content or notif session with device.
marcin added a comment to D12668: Implement peer notifications session creation as outbound on native.
In D12668#361448, @ashoat wrote:In D12668#361372, @kamil wrote:I really don't like the idea (looking at this diff and the entire stack) of passing isKeyserverSession - notification crypto module should treat all devices the same regardless of whether this is a keyserver or client device, and we should only have senderID, because the current design makes it confusing. But given this is implemented and tested I believe we can proceed, you could create a follow-up task to improve it in future but for now LGTM.
Curious for @marcin's perspective on this, and how much time it might take to fix up
One thing that doesn’t work in thick threads is fetching next pages of results. This is because timestamps exceed cpp int, so SQLiteQueryExecutor::searchMessages doesn’t bind them to sql query correctly. Fixing this is tracked in ENG-8893
inka added 1 blocking reviewer(s) for D12865: [keyserver][lib][web][native] use local search for thick threads: kamil.
Jul 23 2024
Jul 23 2024
[terraform] upgrade the disk image to 1.0.102
will requested review of D12863: [terraform] move image config to aws_ecs and add custom image variable.
marcin updated the test plan for D12838: Implement web notifs session createion with race condition handling.
marcin updated the diff for D12838: Implement web notifs session createion with race condition handling.
Rebase
marcin updated the diff for D12750: Implement inbound notif session creation from the NSE with race condition handling.
Use common C++ implementation on Android. It was tested the same way as iOS using latest staging Tunnelbroker release
Rebase
Use the API in send-utils
Make encryptNotification a part of olmAPI. This change is ESSENTIAL on web since it makes encryptNotification run on shared worker. This enables us to deterministically handle race conditions.
kamil committed rCOMMdd5c4d502382: [SQLite] rename all QueryExecutor params to `camelCase` (authored by kamil).
[SQLite] rename all QueryExecutor params to `camelCase`
kamil committed rCOMM5d535a143135: [lib] introduce message searching to `SQLiteAPI` (authored by kamil).
[lib] introduce message searching to `SQLiteAPI`
kamil committed rCOMM12032bbfe1af: [native] introduce message searching to `CommCoreModule` (authored by kamil).
[native] introduce message searching to `CommCoreModule`
kamil committed rCOMM81fc7466f203: [web] introduce message searching to shared worker (authored by kamil).
[web] introduce message searching to shared worker
kamil committed rCOMM7085908cc6d2: [SQLite] implement tests for messages search (authored by kamil).
[SQLite] implement tests for messages search
kamil committed rCOMMffb88c4a6c6d: [SQLite] add Emscripten bindings for message search (authored by kamil).
[SQLite] add Emscripten bindings for message search
kamil committed rCOMM3b9546b1e346: [SQLite] implement query for searching messages (authored by kamil).
[SQLite] implement query for searching messages
kamil committed rCOMMb290620829de: [SQLite] add method for message search to SQLiteQueryExecutor for both web and… (authored by kamil).
[SQLite] add method for message search to SQLiteQueryExecutor for both web and…
Still have to figure out a distinction between this and JOIN_THREAD
merge types
address review
Add the util
Add to specs
Add to specs
kamil added inline comments to D12843: [SQLite] add method for message search to SQLiteQueryExecutor for both web and native.
kamil updated the diff for D12843: [SQLite] add method for message search to SQLiteQueryExecutor for both web and native.
rename
marcin added inline comments to D12843: [SQLite] add method for message search to SQLiteQueryExecutor for both web and native.
In D12806#363499, @ashoat wrote:I wonder if we should have a separate task for updating the replies count. I don't think I contemplated it in sendTextMessageSpec
[native][web] Rename P2P messages methods
We can also build and run the native app as a part of the test plan.
We can consider one more thing: sorting the returned messages.
kamil published D12856: [Tunnelbroker][lib] cleanup Device <-> Tunnelbroker message types for review.