Update extractKeyserverIDFromID so that it returns null for DMs
Needs RevisionPublic
Actions

Authored by tomek on Wed, Jul 3, 6:28 AM.

Details

Reviewers

inka
bartek

Summary

This requires changes in a lot of places because we were assuming that a thread ID is present.

Test Plan

Mostly Flow. Tested some simple scenarios, e.g. sending a message.

Repository

rCOMM Comm

Branch

master12

Lint

No Lint Coverage

Unit

No Test Coverage

tomek requested review of this revision.Wed, Jul 3, 6:44 AM

Okay, this makes sense 😉

inka requested changes to this revision.Thu, Jul 4, 4:15 AM

inka added inline comments.

lib/actions/activity-actions.js
32–34	It really feels like we should extract this to a function
lib/keyserver-conn/keyserver-call-utils.js
21	This will throw in `keyserverAuth` if `threadWatcher.getWatchedIDs()` includes thick threads. Are we sure this can't happen?
native/chat/settings/thread-settings-push-notifs.react.js
179–184	I feel like this could be done inside of `deviceTokenSelector`, but not sure
web/calendar/entry.react.js
479–481	Shouldn't this be checking some connection to tunnelbroker? Probably not in this diff, but it feels like we shouldn't just leave this like that. There probably is a reason for checking if we can send the save entry request

This revision now requires changes to proceed.Thu, Jul 4, 4:15 AM

lib/keyserver-conn/keyserver-call-utils.js
21	Great catch
web/calendar/entry.react.js
479–481	Looks like the only place this is used is to trigger auto-retries of failed entry updates once we detect the user has come online What @tomek is doing here is basically disabling that automatic retry. Checking Tunnelbroker connection would probably be appropriate, but it might not be necessary if we have a separate automatic retry mechanism, which I think @tomek is planning for this month (but tracked separately) Unrelated: I might suggest collapsing this all into a single `const online = useSelector`