[lib] Stop requesting device lists for users that don't have them
ClosedPublic
Actions

Authored by inka on Jul 18 2024, 7:36 AM.

Details

Reviewers

tomek
kamil
ashoat

Commits

rCOMMcc6992d6cef1: [lib] Stop requesting device lists for users that don't have them

Summary

issue: ENG-8842
When we launch CSAT, some users will not yet have device lists. We don't want to be requesting them every couple of seconds.

Test Plan

Created a user registered with the keyserver but not with identity. Checked that their device list was being fetched multiple times, and none was returned by identity.
Checked that after this change the list was being requested only once.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Jul 18 2024, 7:36 AM

Herald added a subscriber: ashoat. · View Herald TranscriptJul 18 2024, 7:36 AM

Harbormaster completed remote builds in B30469: Diff 42468.Jul 18 2024, 7:53 AM

inka requested review of this revision.Jul 18 2024, 7:53 AM

inka edited the test plan for this revision. (Show Details)Jul 18 2024, 7:56 AM

ashoat accepted this revision.Jul 18 2024, 12:49 PM

This revision is now accepted and ready to land.Jul 18 2024, 12:49 PM

Landed this so we could include it in the next release

Closed by commit rCOMMcc6992d6cef1: [lib] Stop requesting device lists for users that don't have them (authored by inka, committed by ashoat). · Explain WhyJul 18 2024, 6:07 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMcc6992d6cef1: [lib] Stop requesting device lists for users that don't have them.

Revision Contents
Changeset List

Path

Size

lib/

handlers/

user-infos-handler.react.js

25 lines

hooks/

peer-list-hooks.js

8 lines

Diff 42509

View Options

lib/handlers/user-infos-handler.react.js