Page MenuHomePhabricator
Differential D12783

[web] Add bindings for inserting into the search table
ClosedPublic
Actions

Authored by inka on Jul 17 2024, 4:50 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 17, 12:32 AM
Unknown Object (File)
Fri, Mar 7, 3:38 AM
Unknown Object (File)
Feb 21 2025, 4:37 AM
Unknown Object (File)
Feb 21 2025, 4:37 AM
Unknown Object (File)
Feb 21 2025, 4:37 AM
Unknown Object (File)
Feb 9 2025, 1:30 PM
Unknown Object (File)
Jan 21 2025, 11:46 PM
Unknown Object (File)
Jan 20 2025, 6:52 AM
View All 73 Files
Subscribers
ashoat

Details

Reviewers
tomek
kamil
marcin
Commits
rCOMM7b41e0ca3666: [web] Add bindings for inserting into the search table
Summary

issue: ENG-8825

Test Plan

Called sqliteQueryExecutor.updateMessageSearchResult and veryfied that updateMessageSearchResult was called

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka created this revision.Jul 17 2024, 4:50 AM
Herald added a subscriber: ashoat. · View Herald TranscriptJul 17 2024, 4:50 AM
inka added a parent revision: D12778: [native] Add SQLiteQueryExecutor code for inserting into the search table.Jul 17 2024, 4:50 AM
Harbormaster completed remote builds in B30407: Diff 42378.Jul 17 2024, 5:07 AM
inka requested review of this revision.Jul 17 2024, 5:07 AM
tomek accepted this revision.Jul 17 2024, 7:03 AM
This revision is now accepted and ready to land.Jul 17 2024, 7:03 AM
inka updated this revision to Diff 42459.Jul 18 2024, 4:56 AM

Rebase

inka updated this revision to Diff 42463.Jul 18 2024, 5:07 AM

Rename to updateMessageSearchIndex

Harbormaster completed remote builds in B30460: Diff 42459.Jul 18 2024, 5:15 AM
Harbormaster failed remote builds in B30464: Diff 42463!Jul 18 2024, 5:42 AM
inka updated this revision to Diff 42466.Jul 18 2024, 5:59 AM

Update wasm

Harbormaster completed remote builds in B30467: Diff 42466.Jul 18 2024, 6:15 AM
inka added a child revision: D12794: [native] Add MessageSearchStoreOperations.Jul 18 2024, 8:05 AM
inka updated this revision to Diff 42476.Jul 18 2024, 8:35 AM

Rename fix

Harbormaster completed remote builds in B30477: Diff 42476.Jul 18 2024, 8:52 AM
kamil accepted this revision.Jul 19 2024, 4:57 AM
inka updated this revision to Diff 42603.Jul 22 2024, 12:26 AM

Rebase

Harbormaster failed remote builds in B30556: Diff 42603!Jul 22 2024, 12:40 AM
inka updated this revision to Diff 42619.Jul 22 2024, 8:17 AM

Rebase

Harbormaster completed remote builds in B30568: Diff 42619.Jul 22 2024, 8:32 AM
Harbormaster completed remote builds in B30556: Diff 42603.Jul 22 2024, 11:36 PM
inka updated this revision to Diff 42657.Jul 23 2024, 1:28 AM

wasm

Harbormaster completed remote builds in B30588: Diff 42657.Jul 23 2024, 1:48 AM
Closed by commit rCOMM7b41e0ca3666: [web] Add bindings for inserting into the search table (authored by inka). · Explain WhyJul 23 2024, 2:44 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMM7b41e0ca3666: [web] Add bindings for inserting into the search table.

Revision Contents
Changeset List

PathSize
web/
cpp/
5 lines
shared-worker/
_generated/
types/
6 lines

Diff 42663

View Options

web/cpp/SQLiteQueryExecutorBindings.cpp

Show First 20 Lines • Show All 51 Lines • ▼ Show 20 Linesresource "aws_scheduler_schedule" "blob_cleanup" {
# Task can run within 15 minutes window of the scheduled time # Task can run within 15 minutes window of the scheduled time
flexible_time_window { flexible_time_window {
mode = "FLEXIBLE" mode = "FLEXIBLE"
maximum_window_in_minutes = 15 maximum_window_in_minutes = 15
} }
target { target {
arn = aws_ecs_cluster.comm_services.arn arn = aws_ecs_cluster.comm_services.arn
role_arn = aws_iam_role.scheduler.arn role_arn = aws_iam_role.task_scheduler.arn
ecs_parameters { ecs_parameters {
task_definition_arn = aws_ecs_task_definition.blob_cleanup.arn_without_revision task_definition_arn = aws_ecs_task_definition.blob_cleanup.arn_without_revision
launch_type = "FARGATE" launch_type = "FARGATE"
network_configuration { network_configuration {
assign_public_ip = true assign_public_ip = true
security_groups = [aws_security_group.blob_service.id] security_groups = [aws_security_group.blob_service.id]
subnets = [ subnets = [
aws_subnet.public_a.id, aws_subnet.public_a.id,
aws_subnet.public_b.id, aws_subnet.public_b.id,
aws_subnet.public_c.id, aws_subnet.public_c.id,
] ]
} }
} }
retry_policy { retry_policy {
maximum_event_age_in_seconds = 300 maximum_event_age_in_seconds = 300
maximum_retry_attempts = 5 maximum_retry_attempts = 5
} }
} }
} }
resource "aws_iam_role" "scheduler" { resource "aws_iam_role_policy_attachment" "blob_cleanup_scheduler" {
name = "cron-scheduler-role" policy_arn = aws_iam_policy.blob_cleanup_scheduler.arn
assume_role_policy = jsonencode({ role = aws_iam_role.task_scheduler.name
Version = "2012-10-17"
Statement = [
{
Effect = "Allow"
Principal = {
Service = ["scheduler.amazonaws.com"]
}
Action = "sts:AssumeRole"
}
]
})
}
resource "aws_iam_role_policy_attachment" "scheduler" {
policy_arn = aws_iam_policy.scheduler.arn
role = aws_iam_role.scheduler.name
} }
resource "aws_iam_policy" "scheduler" { resource "aws_iam_policy" "blob_cleanup_scheduler" {
name = "cron-scheduler-policy" name = "blob-cleanup-cron-scheduler-policy"
policy = jsonencode({ policy = jsonencode({
Version = "2012-10-17" Version = "2012-10-17"
Statement = [ Statement = [
# Allow scheduler to execute the task # Allow scheduler to execute the task
{ {
Effect = "Allow", Effect = "Allow",
Action = [ Action = [
Show All 18 Lines
View Options

web/shared-worker/_generated/comm_query_executor.wasm

Show First 20 Lines • Show All 51 Lines • ▼ Show 20 Linesresource "aws_scheduler_schedule" "blob_cleanup" {
# Task can run within 15 minutes window of the scheduled time # Task can run within 15 minutes window of the scheduled time
flexible_time_window { flexible_time_window {
mode = "FLEXIBLE" mode = "FLEXIBLE"
maximum_window_in_minutes = 15 maximum_window_in_minutes = 15
} }
target { target {
arn = aws_ecs_cluster.comm_services.arn arn = aws_ecs_cluster.comm_services.arn
role_arn = aws_iam_role.scheduler.arn role_arn = aws_iam_role.task_scheduler.arn
ecs_parameters { ecs_parameters {
task_definition_arn = aws_ecs_task_definition.blob_cleanup.arn_without_revision task_definition_arn = aws_ecs_task_definition.blob_cleanup.arn_without_revision
launch_type = "FARGATE" launch_type = "FARGATE"
network_configuration { network_configuration {
assign_public_ip = true assign_public_ip = true
security_groups = [aws_security_group.blob_service.id] security_groups = [aws_security_group.blob_service.id]
subnets = [ subnets = [
aws_subnet.public_a.id, aws_subnet.public_a.id,
aws_subnet.public_b.id, aws_subnet.public_b.id,
aws_subnet.public_c.id, aws_subnet.public_c.id,
] ]
} }
} }
retry_policy { retry_policy {
maximum_event_age_in_seconds = 300 maximum_event_age_in_seconds = 300
maximum_retry_attempts = 5 maximum_retry_attempts = 5
} }
} }
} }
resource "aws_iam_role" "scheduler" { resource "aws_iam_role_policy_attachment" "blob_cleanup_scheduler" {
name = "cron-scheduler-role" policy_arn = aws_iam_policy.blob_cleanup_scheduler.arn
assume_role_policy = jsonencode({ role = aws_iam_role.task_scheduler.name
Version = "2012-10-17"
Statement = [
{
Effect = "Allow"
Principal = {
Service = ["scheduler.amazonaws.com"]
}
Action = "sts:AssumeRole"
}
]
})
}
resource "aws_iam_role_policy_attachment" "scheduler" {
policy_arn = aws_iam_policy.scheduler.arn
role = aws_iam_role.scheduler.name
} }
resource "aws_iam_policy" "scheduler" { resource "aws_iam_policy" "blob_cleanup_scheduler" {
name = "cron-scheduler-policy" name = "blob-cleanup-cron-scheduler-policy"
policy = jsonencode({ policy = jsonencode({
Version = "2012-10-17" Version = "2012-10-17"
Statement = [ Statement = [
# Allow scheduler to execute the task # Allow scheduler to execute the task
{ {
Effect = "Allow", Effect = "Allow",
Action = [ Action = [
Show All 18 Lines
View Options

web/shared-worker/types/sqlite-query-executor.js

Show First 20 Lines • Show All 51 Lines • ▼ Show 20 Linesresource "aws_scheduler_schedule" "blob_cleanup" {
# Task can run within 15 minutes window of the scheduled time # Task can run within 15 minutes window of the scheduled time
flexible_time_window { flexible_time_window {
mode = "FLEXIBLE" mode = "FLEXIBLE"
maximum_window_in_minutes = 15 maximum_window_in_minutes = 15
} }
target { target {
arn = aws_ecs_cluster.comm_services.arn arn = aws_ecs_cluster.comm_services.arn
role_arn = aws_iam_role.scheduler.arn role_arn = aws_iam_role.task_scheduler.arn
ecs_parameters { ecs_parameters {
task_definition_arn = aws_ecs_task_definition.blob_cleanup.arn_without_revision task_definition_arn = aws_ecs_task_definition.blob_cleanup.arn_without_revision
launch_type = "FARGATE" launch_type = "FARGATE"
network_configuration { network_configuration {
assign_public_ip = true assign_public_ip = true
security_groups = [aws_security_group.blob_service.id] security_groups = [aws_security_group.blob_service.id]
subnets = [ subnets = [
aws_subnet.public_a.id, aws_subnet.public_a.id,
aws_subnet.public_b.id, aws_subnet.public_b.id,
aws_subnet.public_c.id, aws_subnet.public_c.id,
] ]
} }
} }
retry_policy { retry_policy {
maximum_event_age_in_seconds = 300 maximum_event_age_in_seconds = 300
maximum_retry_attempts = 5 maximum_retry_attempts = 5
} }
} }
} }
resource "aws_iam_role" "scheduler" { resource "aws_iam_role_policy_attachment" "blob_cleanup_scheduler" {
name = "cron-scheduler-role" policy_arn = aws_iam_policy.blob_cleanup_scheduler.arn
assume_role_policy = jsonencode({ role = aws_iam_role.task_scheduler.name
Version = "2012-10-17"
Statement = [
{
Effect = "Allow"
Principal = {
Service = ["scheduler.amazonaws.com"]
}
Action = "sts:AssumeRole"
}
]
})
}
resource "aws_iam_role_policy_attachment" "scheduler" {
policy_arn = aws_iam_policy.scheduler.arn
role = aws_iam_role.scheduler.name
} }
resource "aws_iam_policy" "scheduler" { resource "aws_iam_policy" "blob_cleanup_scheduler" {
name = "cron-scheduler-policy" name = "blob-cleanup-cron-scheduler-policy"
policy = jsonencode({ policy = jsonencode({
Version = "2012-10-17" Version = "2012-10-17"
Statement = [ Statement = [
# Allow scheduler to execute the task # Allow scheduler to execute the task
{ {
Effect = "Allow", Effect = "Allow",
Action = [ Action = [
Show All 18 Lines