Page MenuHomePhabricator
Differential D12740

[lib] Introduce getRelatedMessages to SQLiteAPI
ClosedPublic
Actions

Authored by ashoat on Jul 14 2024, 6:14 PM.
Tags
None
Referenced Files
F3524482: D12740.id42371.diff
Mon, Dec 23, 12:41 PM
F3524481: D12740.id42335.diff
Mon, Dec 23, 12:40 PM
F3524480: D12740.id42318.diff
Mon, Dec 23, 12:40 PM
F3524479: D12740.id42312.diff
Mon, Dec 23, 12:40 PM
F3524478: D12740.id42273.diff
Mon, Dec 23, 12:40 PM
F3524429: D12740.id.diff
Mon, Dec 23, 12:40 PM
F3524404: D12740.diff
Mon, Dec 23, 12:39 PM
Unknown Object (File)
Sat, Dec 14, 2:07 PM
View All 92 Files
Subscribers
None

Details

Reviewers
kamil
tomek
marcin
Commits
rCOMM308cf3b2c316: [lib] Introduce getRelatedMessages to SQLiteAPI
Summary

This diff introduces a shared interface on SQLiteAPI so the JS code in lib can hit this API on both native and web.

Depends on D12739

Test Plan
  1. In combination with later diffs, I tested a patch on both native and web that hit getRelatedMessages with a specific message ID and confirmed that it returned the message
  2. I tested a message ID that did not exist and confirmed I got undefined back

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Jul 14 2024, 6:14 PM
ashoat added a child revision: D12741: [lib] Process DMOperations when received from peers via Tunnelbroker.Jul 14 2024, 6:17 PM
Harbormaster completed remote builds in B30313: Diff 42273.Jul 14 2024, 6:38 PM
ashoat requested review of this revision.Jul 14 2024, 6:38 PM
marcin accepted this revision.Jul 15 2024, 2:58 AM
This revision is now accepted and ready to land.Jul 15 2024, 2:58 AM
ashoat added a child revision: D12759: [SQLite] Add target_message generated column and index.Jul 15 2024, 2:15 PM
ashoat removed a child revision: D12741: [lib] Process DMOperations when received from peers via Tunnelbroker.Jul 15 2024, 2:26 PM
ashoat retitled this revision from [lib] Introduce getLatestMessageEdit to SQLiteAPI to [lib] Introduce getRelatedMessages to SQLiteAPI.Jul 15 2024, 7:03 PM
ashoat edited the test plan for this revision. (Show Details)
ashoat added a child revision: D12741: [lib] Process DMOperations when received from peers via Tunnelbroker.Jul 15 2024, 7:06 PM
ashoat removed a child revision: D12759: [SQLite] Add target_message generated column and index.
ashoat updated this revision to Diff 42312.Jul 15 2024, 7:14 PM

Rework into getRelatedMessages, which can be reused for rendering search results

Harbormaster failed remote builds in B30350: Diff 42312!Jul 15 2024, 7:31 PM
ashoat added a child revision: D12764: [lib] Introduce useGetLatestMessageEdit.Jul 15 2024, 7:38 PM
ashoat removed a child revision: D12741: [lib] Process DMOperations when received from peers via Tunnelbroker.Jul 15 2024, 7:38 PM
ashoat updated this revision to Diff 42318.Jul 15 2024, 7:58 PM

ESLint fix

Harbormaster failed remote builds in B30356: Diff 42318!Jul 15 2024, 8:42 PM
ashoat updated this revision to Diff 42335.Jul 16 2024, 4:10 AM

Rebase

Harbormaster completed remote builds in B30372: Diff 42335.Jul 16 2024, 4:32 AM
Closed by commit rCOMM308cf3b2c316: [lib] Introduce getRelatedMessages to SQLiteAPI (authored by ashoat). · Explain WhyJul 16 2024, 6:46 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM308cf3b2c316: [lib] Introduce getRelatedMessages to SQLiteAPI.

Revision Contents
Changeset List

PathSize
lib/
types/
2 lines
utils/
__mocks__/
1 line
native/
database/
1 line
web/
database/
12 lines

Diff 42371

View Options

lib/types/sqlite-types.js

Loading...
View Options

lib/utils/__mocks__/config.js

Loading...
View Options

native/database/sqlite-api.js

Loading...
View Options

web/database/sqlite-api.js

Loading...