Page MenuHomePhabricator
Differential D12740

[lib] Introduce getRelatedMessages to SQLiteAPI
ClosedPublic
Actions

Authored by ashoat on Jul 14 2024, 6:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 11, 11:44 PM
Unknown Object (File)
Thu, Mar 6, 6:20 AM
Unknown Object (File)
Wed, Feb 26, 6:03 AM
Unknown Object (File)
Wed, Feb 26, 6:03 AM
Unknown Object (File)
Wed, Feb 26, 6:03 AM
Unknown Object (File)
Wed, Feb 26, 6:02 AM
Unknown Object (File)
Wed, Feb 26, 6:02 AM
Unknown Object (File)
Wed, Feb 26, 6:02 AM
View All Files
Subscribers
None

Details

Reviewers
kamil
tomek
marcin
Commits
rCOMM308cf3b2c316: [lib] Introduce getRelatedMessages to SQLiteAPI
Summary

This diff introduces a shared interface on SQLiteAPI so the JS code in lib can hit this API on both native and web.

Depends on D12739

Test Plan
  1. In combination with later diffs, I tested a patch on both native and web that hit getRelatedMessages with a specific message ID and confirmed that it returned the message
  2. I tested a message ID that did not exist and confirmed I got undefined back

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Jul 14 2024, 6:14 PM
ashoat added a child revision: D12741: [lib] Process DMOperations when received from peers via Tunnelbroker.Jul 14 2024, 6:17 PM
Harbormaster completed remote builds in B30313: Diff 42273.Jul 14 2024, 6:38 PM
ashoat requested review of this revision.Jul 14 2024, 6:38 PM
marcin accepted this revision.Jul 15 2024, 2:58 AM
This revision is now accepted and ready to land.Jul 15 2024, 2:58 AM
ashoat added a child revision: D12759: [SQLite] Add target_message generated column and index.Jul 15 2024, 2:15 PM
ashoat removed a child revision: D12741: [lib] Process DMOperations when received from peers via Tunnelbroker.Jul 15 2024, 2:26 PM
ashoat retitled this revision from [lib] Introduce getLatestMessageEdit to SQLiteAPI to [lib] Introduce getRelatedMessages to SQLiteAPI.Jul 15 2024, 7:03 PM
ashoat edited the test plan for this revision. (Show Details)
ashoat added a child revision: D12741: [lib] Process DMOperations when received from peers via Tunnelbroker.Jul 15 2024, 7:06 PM
ashoat removed a child revision: D12759: [SQLite] Add target_message generated column and index.
ashoat updated this revision to Diff 42312.Jul 15 2024, 7:14 PM

Rework into getRelatedMessages, which can be reused for rendering search results

Harbormaster failed remote builds in B30350: Diff 42312!Jul 15 2024, 7:31 PM
ashoat added a child revision: D12764: [lib] Introduce useGetLatestMessageEdit.Jul 15 2024, 7:38 PM
ashoat removed a child revision: D12741: [lib] Process DMOperations when received from peers via Tunnelbroker.Jul 15 2024, 7:38 PM
ashoat updated this revision to Diff 42318.Jul 15 2024, 7:58 PM

ESLint fix

Harbormaster failed remote builds in B30356: Diff 42318!Jul 15 2024, 8:42 PM
ashoat updated this revision to Diff 42335.Jul 16 2024, 4:10 AM

Rebase

Harbormaster completed remote builds in B30372: Diff 42335.Jul 16 2024, 4:32 AM
Closed by commit rCOMM308cf3b2c316: [lib] Introduce getRelatedMessages to SQLiteAPI (authored by ashoat). · Explain WhyJul 16 2024, 6:46 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM308cf3b2c316: [lib] Introduce getRelatedMessages to SQLiteAPI.

Revision Contents
Changeset List

PathSize
lib/
types/
2 lines
utils/
__mocks__/
1 line
native/
database/
1 line
web/
database/
12 lines

Diff 42371

View Options

lib/types/sqlite-types.js

Show First 20 Lines • Show All 72 Lines • ▼ Show 20 Lines "dependencies": {
"ethers": "^6.11.1", "ethers": "^6.11.1",
"expo": "47.0.14", "expo": "47.0.14",
"expo-application": "^5.1.1", "expo-application": "^5.1.1",
"expo-barcode-scanner": "~12.1.0", "expo-barcode-scanner": "~12.1.0",
"expo-dev-client": "~2.0.1", "expo-dev-client": "~2.0.1",
"expo-file-system": "~15.1.1", "expo-file-system": "~15.1.1",
"expo-font": "~11.0.1", "expo-font": "~11.0.1",
"expo-haptics": "~12.0.1", "expo-haptics": "~12.0.1",
"expo-image": "^1.2.2", "expo-image": "1.2.3",
"expo-image-manipulator": "~11.0.0", "expo-image-manipulator": "~11.0.0",
"expo-image-picker": "~14.0.2", "expo-image-picker": "~14.0.2",
"expo-media-library": "~15.0.0", "expo-media-library": "~15.0.0",
"expo-secure-store": "~12.0.0", "expo-secure-store": "~12.0.0",
"expo-splash-screen": "~0.17.4", "expo-splash-screen": "~0.17.4",
"find-root": "^1.1.0", "find-root": "^1.1.0",
"invariant": "^2.2.4", "invariant": "^2.2.4",
"lib": "0.0.1", "lib": "0.0.1",
"lodash": "^4.17.21", "lodash": "^4.17.21",
"lottie-react-native": "^5.1.4", "lottie-react-native": "^5.1.4",
"md5": "^2.2.1", "md5": "^2.2.1",
"olm": "git+https://github.com/CommE2E/olm.git#v0.2.1", "olm": "git+https://github.com/CommE2E/olm.git#v0.2.1",
"react": "18.1.0", "react": "18.1.0",
"react-native": "0.70.9", "react-native": "0.70.9",
"react-native-camera": "^3.31.0", "react-native-camera": "^3.31.0",
"react-native-device-info": "^10.3.0", "react-native-device-info": "^10.3.0",
"react-native-ffmpeg": "^0.4.4", "react-native-ffmpeg": "^0.5.2",
"react-native-figma-squircle": "^0.1.2", "react-native-figma-squircle": "^0.1.2",
"react-native-floating-action": "^1.22.0", "react-native-floating-action": "^1.22.0",
"react-native-fs": "^2.20.0", "react-native-fs": "^2.20.0",
"react-native-gesture-handler": "^2.8.0", "react-native-gesture-handler": "^2.8.0",
"react-native-in-app-message": "^1.0.2", "react-native-in-app-message": "^1.0.2",
"react-native-keyboard-input": "6.0.1", "react-native-keyboard-input": "6.0.1",
"react-native-keychain": "^8.0.0", "react-native-keychain": "^8.0.0",
"react-native-orientation-locker": "^1.5.0", "react-native-orientation-locker": "^1.5.0",
Show All 29 Lines
View Options

lib/utils/__mocks__/config.js

Show First 20 Lines • Show All 72 Lines • ▼ Show 20 Lines "dependencies": {
"ethers": "^6.11.1", "ethers": "^6.11.1",
"expo": "47.0.14", "expo": "47.0.14",
"expo-application": "^5.1.1", "expo-application": "^5.1.1",
"expo-barcode-scanner": "~12.1.0", "expo-barcode-scanner": "~12.1.0",
"expo-dev-client": "~2.0.1", "expo-dev-client": "~2.0.1",
"expo-file-system": "~15.1.1", "expo-file-system": "~15.1.1",
"expo-font": "~11.0.1", "expo-font": "~11.0.1",
"expo-haptics": "~12.0.1", "expo-haptics": "~12.0.1",
"expo-image": "^1.2.2", "expo-image": "1.2.3",
"expo-image-manipulator": "~11.0.0", "expo-image-manipulator": "~11.0.0",
"expo-image-picker": "~14.0.2", "expo-image-picker": "~14.0.2",
"expo-media-library": "~15.0.0", "expo-media-library": "~15.0.0",
"expo-secure-store": "~12.0.0", "expo-secure-store": "~12.0.0",
"expo-splash-screen": "~0.17.4", "expo-splash-screen": "~0.17.4",
"find-root": "^1.1.0", "find-root": "^1.1.0",
"invariant": "^2.2.4", "invariant": "^2.2.4",
"lib": "0.0.1", "lib": "0.0.1",
"lodash": "^4.17.21", "lodash": "^4.17.21",
"lottie-react-native": "^5.1.4", "lottie-react-native": "^5.1.4",
"md5": "^2.2.1", "md5": "^2.2.1",
"olm": "git+https://github.com/CommE2E/olm.git#v0.2.1", "olm": "git+https://github.com/CommE2E/olm.git#v0.2.1",
"react": "18.1.0", "react": "18.1.0",
"react-native": "0.70.9", "react-native": "0.70.9",
"react-native-camera": "^3.31.0", "react-native-camera": "^3.31.0",
"react-native-device-info": "^10.3.0", "react-native-device-info": "^10.3.0",
"react-native-ffmpeg": "^0.4.4", "react-native-ffmpeg": "^0.5.2",
"react-native-figma-squircle": "^0.1.2", "react-native-figma-squircle": "^0.1.2",
"react-native-floating-action": "^1.22.0", "react-native-floating-action": "^1.22.0",
"react-native-fs": "^2.20.0", "react-native-fs": "^2.20.0",
"react-native-gesture-handler": "^2.8.0", "react-native-gesture-handler": "^2.8.0",
"react-native-in-app-message": "^1.0.2", "react-native-in-app-message": "^1.0.2",
"react-native-keyboard-input": "6.0.1", "react-native-keyboard-input": "6.0.1",
"react-native-keychain": "^8.0.0", "react-native-keychain": "^8.0.0",
"react-native-orientation-locker": "^1.5.0", "react-native-orientation-locker": "^1.5.0",
Show All 29 Lines
View Options

native/database/sqlite-api.js

Show First 20 Lines • Show All 72 Lines • ▼ Show 20 Lines "dependencies": {
"ethers": "^6.11.1", "ethers": "^6.11.1",
"expo": "47.0.14", "expo": "47.0.14",
"expo-application": "^5.1.1", "expo-application": "^5.1.1",
"expo-barcode-scanner": "~12.1.0", "expo-barcode-scanner": "~12.1.0",
"expo-dev-client": "~2.0.1", "expo-dev-client": "~2.0.1",
"expo-file-system": "~15.1.1", "expo-file-system": "~15.1.1",
"expo-font": "~11.0.1", "expo-font": "~11.0.1",
"expo-haptics": "~12.0.1", "expo-haptics": "~12.0.1",
"expo-image": "^1.2.2", "expo-image": "1.2.3",
"expo-image-manipulator": "~11.0.0", "expo-image-manipulator": "~11.0.0",
"expo-image-picker": "~14.0.2", "expo-image-picker": "~14.0.2",
"expo-media-library": "~15.0.0", "expo-media-library": "~15.0.0",
"expo-secure-store": "~12.0.0", "expo-secure-store": "~12.0.0",
"expo-splash-screen": "~0.17.4", "expo-splash-screen": "~0.17.4",
"find-root": "^1.1.0", "find-root": "^1.1.0",
"invariant": "^2.2.4", "invariant": "^2.2.4",
"lib": "0.0.1", "lib": "0.0.1",
"lodash": "^4.17.21", "lodash": "^4.17.21",
"lottie-react-native": "^5.1.4", "lottie-react-native": "^5.1.4",
"md5": "^2.2.1", "md5": "^2.2.1",
"olm": "git+https://github.com/CommE2E/olm.git#v0.2.1", "olm": "git+https://github.com/CommE2E/olm.git#v0.2.1",
"react": "18.1.0", "react": "18.1.0",
"react-native": "0.70.9", "react-native": "0.70.9",
"react-native-camera": "^3.31.0", "react-native-camera": "^3.31.0",
"react-native-device-info": "^10.3.0", "react-native-device-info": "^10.3.0",
"react-native-ffmpeg": "^0.4.4", "react-native-ffmpeg": "^0.5.2",
"react-native-figma-squircle": "^0.1.2", "react-native-figma-squircle": "^0.1.2",
"react-native-floating-action": "^1.22.0", "react-native-floating-action": "^1.22.0",
"react-native-fs": "^2.20.0", "react-native-fs": "^2.20.0",
"react-native-gesture-handler": "^2.8.0", "react-native-gesture-handler": "^2.8.0",
"react-native-in-app-message": "^1.0.2", "react-native-in-app-message": "^1.0.2",
"react-native-keyboard-input": "6.0.1", "react-native-keyboard-input": "6.0.1",
"react-native-keychain": "^8.0.0", "react-native-keychain": "^8.0.0",
"react-native-orientation-locker": "^1.5.0", "react-native-orientation-locker": "^1.5.0",
Show All 29 Lines
View Options

web/database/sqlite-api.js

Show First 20 Lines • Show All 72 Lines • ▼ Show 20 Lines "dependencies": {
"ethers": "^6.11.1", "ethers": "^6.11.1",
"expo": "47.0.14", "expo": "47.0.14",
"expo-application": "^5.1.1", "expo-application": "^5.1.1",
"expo-barcode-scanner": "~12.1.0", "expo-barcode-scanner": "~12.1.0",
"expo-dev-client": "~2.0.1", "expo-dev-client": "~2.0.1",
"expo-file-system": "~15.1.1", "expo-file-system": "~15.1.1",
"expo-font": "~11.0.1", "expo-font": "~11.0.1",
"expo-haptics": "~12.0.1", "expo-haptics": "~12.0.1",
"expo-image": "^1.2.2", "expo-image": "1.2.3",
"expo-image-manipulator": "~11.0.0", "expo-image-manipulator": "~11.0.0",
"expo-image-picker": "~14.0.2", "expo-image-picker": "~14.0.2",
"expo-media-library": "~15.0.0", "expo-media-library": "~15.0.0",
"expo-secure-store": "~12.0.0", "expo-secure-store": "~12.0.0",
"expo-splash-screen": "~0.17.4", "expo-splash-screen": "~0.17.4",
"find-root": "^1.1.0", "find-root": "^1.1.0",
"invariant": "^2.2.4", "invariant": "^2.2.4",
"lib": "0.0.1", "lib": "0.0.1",
"lodash": "^4.17.21", "lodash": "^4.17.21",
"lottie-react-native": "^5.1.4", "lottie-react-native": "^5.1.4",
"md5": "^2.2.1", "md5": "^2.2.1",
"olm": "git+https://github.com/CommE2E/olm.git#v0.2.1", "olm": "git+https://github.com/CommE2E/olm.git#v0.2.1",
"react": "18.1.0", "react": "18.1.0",
"react-native": "0.70.9", "react-native": "0.70.9",
"react-native-camera": "^3.31.0", "react-native-camera": "^3.31.0",
"react-native-device-info": "^10.3.0", "react-native-device-info": "^10.3.0",
"react-native-ffmpeg": "^0.4.4", "react-native-ffmpeg": "^0.5.2",
"react-native-figma-squircle": "^0.1.2", "react-native-figma-squircle": "^0.1.2",
"react-native-floating-action": "^1.22.0", "react-native-floating-action": "^1.22.0",
"react-native-fs": "^2.20.0", "react-native-fs": "^2.20.0",
"react-native-gesture-handler": "^2.8.0", "react-native-gesture-handler": "^2.8.0",
"react-native-in-app-message": "^1.0.2", "react-native-in-app-message": "^1.0.2",
"react-native-keyboard-input": "6.0.1", "react-native-keyboard-input": "6.0.1",
"react-native-keychain": "^8.0.0", "react-native-keychain": "^8.0.0",
"react-native-orientation-locker": "^1.5.0", "react-native-orientation-locker": "^1.5.0",
Show All 29 Lines