Page MenuHomePhabricator
Differential D12735

[native] Introduce MessageEntity type alias in more places
ClosedPublic
Actions

Authored by ashoat on Jul 14 2024, 6:05 PM.
Tags
None
Referenced Files
F2707043: D12735.id.diff
Sun, Sep 15, 10:07 AM
F2707002: D12735.diff
Sun, Sep 15, 10:06 AM
F2701951: D12735.id42364.diff
Sat, Sep 14, 11:14 PM
Unknown Object (File)
Sat, Sep 14, 7:12 PM
Unknown Object (File)
Sat, Sep 14, 7:00 AM
Unknown Object (File)
Tue, Sep 10, 11:15 PM
Unknown Object (File)
Mon, Sep 9, 3:25 AM
Unknown Object (File)
Tue, Aug 27, 11:07 PM
View All 35 Files
Subscribers
None

Details

Reviewers
kamil
tomek
marcin
Commits
rCOMM1457551a5a0f: [native] Introduce MessageEntity type alias in more places
Summary

Noticed we had this in MessageStore.h and figured we could simplify some other places too.

Ended up moving it to DatabaseManagers so it could be used inside the libraries we package for web.

Test Plan

I tested compilation on both web and iOS

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
DatabaseManagers/
4 lines
5 lines
5 lines
entities/
2 lines
NativeModules/
1 line
17 lines
PersistentStorageUtilities/
DataStores/
2 lines

Diff 42364

View Options

native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/entities/Message.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...
View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/MessageStore.h

Loading...