Noticed we had this in MessageStore.h and figured we could simplify some other places too.
Ended up moving it to DatabaseManagers so it could be used inside the libraries we package for web.
Paths
| Differential D12735 Authored by ashoat on Jul 14 2024, 6:05 PM.
Details Summary Noticed we had this in MessageStore.h and figured we could simplify some other places too. Ended up moving it to DatabaseManagers so it could be used inside the libraries we package for web. Test Plan I tested compilation on both web and iOS
Diff Detail
Event Timelineashoat added a child revision: D12736: [web] add std::optional (C++) <-> undefined (JS) marshalling. Harbormaster completed remote builds in B30308: Diff 42268.Jul 14 2024, 6:22 PM2024-07-14 18:22:52 (UTC-7) This revision is now accepted and ready to land.Jul 15 2024, 1:39 AM2024-07-15 01:39:35 (UTC-7) ashoat added a child revision: D12737: [SQLite] Introduce getRelatedMessages.Jul 15 2024, 7:00 PM2024-07-15 19:00:08 (UTC-7) Closed by commit rCOMM1457551a5a0f: [native] Introduce MessageEntity type alias in more places (authored by ashoat). · Explain WhyJul 16 2024, 6:46 PM2024-07-16 18:46:29 (UTC-7) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 42364 native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h
native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h
native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
native/cpp/CommonCpp/DatabaseManagers/entities/Message.h
|