This diff introduces the code on native to interface with our new getRelatedMessages API.
Depends on D12738
Details
Details
- In combination with later diffs, I tested a patch on both native and web that hit getRelatedMessages with a specific message ID and confirmed that it returned the message
- I tested a message ID that did not exist and confirmed I got undefined back
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp | ||
|---|---|---|
| 2616–2620 ↗ | (On Diff #42272) | This formatting looks strange. Did you run yarn clang-format-all? It doesn't get executed automatically during commit, Dev must execute it manually to achieve formatting. |
| native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp | ||
|---|---|---|
| 2616–2620 ↗ | (On Diff #42272) | Sorry for the confusion - after talking to @kamil I found that this sentence:
is only true if someone has commit hooks disabled. |
| native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp | ||
|---|---|---|
| 2616–2620 ↗ | (On Diff #42272) | I can confirm that running yarn clang-format-all yields no changes |