[lib] Specify messageID in sendTextMessageSpec
ClosedPublic
Actions

Authored by ashoat on Jul 21 2024, 5:04 AM.

Details

Reviewers

tomek
kamil
marcin

Commits

rCOMM3980d47ad71f: [lib] Specify messageID in sendTextMessageSpec

Summary

Testing revealed that I had forgotten to specify this.

Depends on D12828

Test Plan

I followed the test plan described in this Linear comment. Before this diff, I saw this error, which disappeared afterwards:

Failed processing Olm P2P message: [Invariant Violation: new messageInfos should have serverID]

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Jul 21 2024, 5:04 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 21 2024, 5:08 AM

Harbormaster failed remote builds in B30548: Diff 42595!

Harbormaster completed remote builds in B30548: Diff 42595.Jul 21 2024, 5:20 AM

ashoat requested review of this revision.Jul 21 2024, 5:20 AM

Makes sense! I asked about it in https://phab.comm.dev/D12655#362785.

This revision is now accepted and ready to land.Jul 22 2024, 10:33 AM

ashoat mentioned this in D12655: [lib] DMOperationSpec for SEND_TEXT_MESSAGE operation.Jul 22 2024, 3:04 PM

Closed by commit rCOMM3980d47ad71f: [lib] Specify messageID in sendTextMessageSpec. · Explain WhyJul 22 2024, 4:29 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM3980d47ad71f: [lib] Specify messageID in sendTextMessageSpec.

Revision Contents
Changeset List

Path

Size

lib/

shared/

dm-ops/

send-text-message-spec.js

3 lines

Diff 42629

View Options

lib/shared/dm-ops/send-text-message-spec.js

[lib] Specify messageID in sendTextMessageSpecClosedPublicActions