[lib] Specify messageID in sendTextMessageSpec
ClosedPublic
Actions

Authored by ashoat on Jul 20 2024, 10:04 PM.

Details

Reviewers

tomek
kamil
marcin

Commits

rCOMM3980d47ad71f: [lib] Specify messageID in sendTextMessageSpec

Summary

Testing revealed that I had forgotten to specify this.

Depends on D12828

Test Plan

I followed the test plan described in this Linear comment. Before this diff, I saw this error, which disappeared afterwards:

Failed processing Olm P2P message: [Invariant Violation: new messageInfos should have serverID]

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Jul 20 2024, 10:04 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 20 2024, 10:08 PM

Harbormaster failed remote builds in B30548: Diff 42595!

Harbormaster completed remote builds in B30548: Diff 42595.Jul 20 2024, 10:20 PM

ashoat requested review of this revision.Jul 20 2024, 10:20 PM

Makes sense! I asked about it in https://phab.comm.dev/D12655#362785.

This revision is now accepted and ready to land.Jul 22 2024, 3:33 AM

ashoat mentioned this in D12655: [lib] DMOperationSpec for SEND_TEXT_MESSAGE operation.Jul 22 2024, 8:04 AM

Closed by commit rCOMM3980d47ad71f: [lib] Specify messageID in sendTextMessageSpec (authored by ashoat). · Explain WhyJul 22 2024, 9:29 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM3980d47ad71f: [lib] Specify messageID in sendTextMessageSpec.

Revision Contents
Changeset List

Path

Size

lib/

shared/

dm-ops/

send-text-message-spec.js

3 lines

Diff 42629

View Options

lib/shared/dm-ops/send-text-message-spec.js

				use tracing::error;

	pub type BoxedError = Box<dyn std::error::Error + Send + Sync + 'static>;			pub type BoxedError = Box<dyn std::error::Error + Send + Sync + 'static>;

	#[derive(			#[derive(
	Debug, derive_more::Display, derive_more::From, derive_more::Error,			Debug, derive_more::Display, derive_more::From, derive_more::Error,
	)]			)]
	pub enum WebsocketError {			pub enum WebsocketError {
	InvalidMessage,			InvalidMessage,
				InvalidSearchQuery,
	UnauthorizedDevice,			UnauthorizedDevice,
	SendError,			SendError,
	SearchError,			SearchError,
	AuthError,			AuthError,
	SerializationError,			SerializationError,
	}			}

				impl From<serde_json::Error> for WebsocketError {
				fn from(err: serde_json::Error) -> Self {
				tracing::error!("Error serializing: {}", err);
				WebsocketError::SerializationError
				}
				}

				impl From<reqwest::Error> for WebsocketError {
				fn from(err: reqwest::Error) -> Self {
				tracing::error!("Error with search request: {}", err);
				WebsocketError::SearchError
				}
				}

[lib] Specify messageID in sendTextMessageSpecClosedPublicActions