Page MenuHomePhabricator

[lib] DMOperationSpec for SEND_TEXT_MESSAGE operation
ClosedPublic

Authored by ashoat on Jul 3 2024, 7:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 23, 4:20 AM
Unknown Object (File)
Fri, Oct 11, 2:45 AM
Unknown Object (File)
Fri, Oct 11, 2:45 AM
Unknown Object (File)
Fri, Oct 11, 2:45 AM
Unknown Object (File)
Fri, Oct 11, 2:45 AM
Unknown Object (File)
Fri, Oct 11, 2:45 AM
Unknown Object (File)
Fri, Oct 11, 2:44 AM
Unknown Object (File)
Sep 9 2024, 4:00 PM
Subscribers
None

Details

Summary

I did this one first because it's more simple

Depends on D12652

Test Plan

I haven't tested this stack outside of Flow. I'd like to propose that we land this so the team can iterate. I'll make sure to test all of the functionality once it's integrated into the rest of the codebase.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 3 2024, 8:05 PM
Harbormaster failed remote builds in B30105: Diff 41976!
ashoat requested review of this revision.Jul 3 2024, 8:29 PM
lib/shared/dm-ops/send-text-message-spec.js
27 ↗(On Diff #41982)

Why do we use this id?

lib/shared/dm-ops/send-text-message-spec.js
27 ↗(On Diff #41982)

Sorry, forgot to explain this. These ids are only used for UpdateInfos on the keyserver side... they don't matter at all on the client side. At some point we probably should have changed the types to remove them, and I suppose we should still do that now... but it's tough to prioritize it given our launch schedule

Created ENG-8713 as a follow-up

Thank you for explaining

This revision is now accepted and ready to land.Jul 4 2024, 7:01 AM

Decided to use a UUID instead of 'ignored'. I'm pretty sure it's not used on the client anywhere, but figured it's better to avoid any risks in case it affects anything, given our tight timeline for launch

This revision was landed with ongoing or failed builds.Jul 4 2024, 11:15 AM
This revision was automatically updated to reflect the committed changes.
lib/shared/dm-ops/send-text-message-spec.js
18–24

@ashoat is it intentional that this message doesn't contain an ID?

lib/shared/dm-ops/send-text-message-spec.js
18–24

Oops! Addressed in D12829