Page MenuHomePhabricator
Differential D12655

[lib] DMOperationSpec for SEND_TEXT_MESSAGE operation
ClosedPublic
Actions

Authored by ashoat on Jul 3 2024, 7:51 PM.
Tags
None
Referenced Files
F3390926: D12655.diff
Sat, Nov 30, 1:33 AM
Unknown Object (File)
Wed, Nov 27, 8:09 AM
Unknown Object (File)
Tue, Nov 26, 10:28 PM
Unknown Object (File)
Mon, Nov 25, 8:08 AM
Unknown Object (File)
Mon, Nov 11, 3:34 PM
Unknown Object (File)
Mon, Nov 11, 2:35 PM
Unknown Object (File)
Mon, Nov 11, 12:34 PM
Unknown Object (File)
Mon, Nov 11, 12:29 PM
View All 65 Files
Subscribers
None

Details

Reviewers
tomek
marcin
inka
Commits
rCOMM23cf032f052c: [lib] DMOperationSpec for SEND_TEXT_MESSAGE operation
Summary

I did this one first because it's more simple

Depends on D12652

Test Plan

I haven't tested this stack outside of Flow. I'd like to propose that we land this so the team can iterate. I'll make sure to test all of the functionality once it's integrated into the rest of the codebase.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Jul 3 2024, 7:51 PM
ashoat added a child revision: D12656: [lib] Make it possible to skip some thread/message properties.
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 3 2024, 8:05 PM
Harbormaster failed remote builds in B30105: Diff 41976!
ashoat updated this revision to Diff 41982.Jul 3 2024, 8:11 PM

Rebase

Harbormaster completed remote builds in B30111: Diff 41982.Jul 3 2024, 8:29 PM
ashoat requested review of this revision.Jul 3 2024, 8:29 PM
inka added inline comments.Jul 4 2024, 6:07 AM
lib/shared/dm-ops/send-text-message-spec.js
27 ↗(On Diff #41982)

Why do we use this id?

ashoat added inline comments.Jul 4 2024, 6:44 AM
lib/shared/dm-ops/send-text-message-spec.js
27 ↗(On Diff #41982)

Sorry, forgot to explain this. These ids are only used for UpdateInfos on the keyserver side... they don't matter at all on the client side. At some point we probably should have changed the types to remove them, and I suppose we should still do that now... but it's tough to prioritize it given our launch schedule

Created ENG-8713 as a follow-up

inka accepted this revision.Jul 4 2024, 7:01 AM

Thank you for explaining

This revision is now accepted and ready to land.Jul 4 2024, 7:01 AM
ashoat updated this revision to Diff 42056.EditedJul 4 2024, 11:06 AM

Decided to use a UUID instead of 'ignored'. I'm pretty sure it's not used on the client anywhere, but figured it's better to avoid any risks in case it affects anything, given our tight timeline for launch

This revision was landed with ongoing or failed builds.Jul 4 2024, 11:15 AM
Closed by commit rCOMM23cf032f052c: [lib] DMOperationSpec for SEND_TEXT_MESSAGE operation (authored by ashoat). · Explain Why
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM23cf032f052c: [lib] DMOperationSpec for SEND_TEXT_MESSAGE operation.
Harbormaster completed remote builds in B30164: Diff 42056.Jul 4 2024, 11:52 AM
tomek added inline comments.Jul 19 2024, 12:50 PM
lib/shared/dm-ops/send-text-message-spec.js
18–24 ↗(On Diff #42060)

@ashoat is it intentional that this message doesn't contain an ID?

tomek mentioned this in D12829: [lib] Specify messageID in sendTextMessageSpec.Jul 22 2024, 3:33 AM
ashoat added inline comments.Jul 22 2024, 8:04 AM
lib/shared/dm-ops/send-text-message-spec.js
18–24 ↗(On Diff #42060)

Oops! Addressed in D12829

Revision Contents
Changeset List

PathSize
lib/
shared/
dm-ops/
32 lines

Diff 42056

View Options

lib/shared/dm-ops/send-text-message-spec.js

Loading...