Page MenuHomePhabricator
Differential D12660

[keyserver] Update ServerThreadInfo to only cover ThinThreadType
ClosedPublic
Actions

Authored by ashoat on Jul 3 2024, 8:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 21 2025, 12:11 AM
Unknown Object (File)
Feb 21 2025, 12:11 AM
Unknown Object (File)
Feb 21 2025, 12:11 AM
Unknown Object (File)
Feb 21 2025, 12:11 AM
Unknown Object (File)
Jan 26 2025, 4:19 AM
Unknown Object (File)
Jan 21 2025, 10:41 PM
Unknown Object (File)
Jan 4 2025, 7:08 PM
Unknown Object (File)
Jan 4 2025, 7:05 PM
View All 64 Files
Subscribers
None

Details

Reviewers
tomek
marcin
inka
Commits
rCOMMa761d91e9ae2: [keyserver] Update ServerThreadInfo to only cover ThinThreadType
Summary

ServerThreadInfos are only used on the keyserver, and as such they don't include thick threads.

This diff is necessary to make sure that the changes in the next don't cause Flow errors.

Depends on D12656

Test Plan

Make sure the next diff doesn't have any Flow errors

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
keyserver/
src/
fetchers/
11 lines
lib/
shared/
5 lines
types/
2 lines

Diff 42062

View Options

keyserver/src/fetchers/thread-fetchers.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import uuid from 'uuid'; import uuid from 'uuid';
import { createRoleAndPermissionForThickThreads } from './create-thread-spec.js'; import { createRoleAndPermissionForThickThreads } from './create-thread-spec.js';
import type { import type {
DMOperationSpec, DMOperationSpec,
ProcessDMOperationUtilities, ProcessDMOperationUtilities,
} from './dm-op-spec.js'; } from './dm-op-spec.js';
import type { DMAddMembersOperation } from '../../types/dm-ops.js'; import type { DMAddMembersOperation } from '../../types/dm-ops.js';
import { messageTypes } from '../../types/message-types-enum.js'; import { messageTypes } from '../../types/message-types-enum.js';
import { type RawMessageInfo } from '../../types/message-types.js';
import type { AddMembersMessageData } from '../../types/messages/add-members.js'; import type { AddMembersMessageData } from '../../types/messages/add-members.js';
import { import { minimallyEncodeMemberInfo } from '../../types/minimally-encoded-thread-permissions-types.js';
minimallyEncodeMemberInfo,
type ThickRawThreadInfo,
} from '../../types/minimally-encoded-thread-permissions-types.js';
import { joinThreadSubscription } from '../../types/subscription-types.js'; import { joinThreadSubscription } from '../../types/subscription-types.js';
import type { ThickMemberInfo } from '../../types/thread-types.js'; import type { ThickMemberInfo } from '../../types/thread-types.js';
import { updateTypes } from '../../types/update-types-enum.js'; import { updateTypes } from '../../types/update-types-enum.js';
import type { ClientUpdateInfo } from '../../types/update-types.js';
import { values } from '../../utils/objects.js'; import { values } from '../../utils/objects.js';
import { rawMessageInfoFromMessageData } from '../message-utils.js'; import { rawMessageInfoFromMessageData } from '../message-utils.js';
import { roleIsDefaultRole, userIsMember } from '../thread-utils.js'; import { roleIsDefaultRole, userIsMember } from '../thread-utils.js';
export type AddMembersResult = {
rawMessageInfos: Array<RawMessageInfo>,
updateInfos: Array<ClientUpdateInfo>,
threadInfo: ?ThickRawThreadInfo,
};
function createAddNewMembersMessageDataFromDMOperation( function createAddNewMembersMessageDataFromDMOperation(
dmOperation: DMAddMembersOperation, dmOperation: DMAddMembersOperation,
): AddMembersMessageData { ): AddMembersMessageData {
const { editorID, time, addedUserIDs, threadID } = dmOperation; const { editorID, time, addedUserIDs, threadID } = dmOperation;
return { return {
type: messageTypes.ADD_MEMBERS, type: messageTypes.ADD_MEMBERS,
threadID, threadID,
creatorID: editorID, creatorID: editorID,
▲ Show 20 Lines • Show All 115 Lines • Show Last 20 Lines
View Options

lib/shared/thread-utils.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import uuid from 'uuid'; import uuid from 'uuid';
import { createRoleAndPermissionForThickThreads } from './create-thread-spec.js'; import { createRoleAndPermissionForThickThreads } from './create-thread-spec.js';
import type { import type {
DMOperationSpec, DMOperationSpec,
ProcessDMOperationUtilities, ProcessDMOperationUtilities,
} from './dm-op-spec.js'; } from './dm-op-spec.js';
import type { DMAddMembersOperation } from '../../types/dm-ops.js'; import type { DMAddMembersOperation } from '../../types/dm-ops.js';
import { messageTypes } from '../../types/message-types-enum.js'; import { messageTypes } from '../../types/message-types-enum.js';
import { type RawMessageInfo } from '../../types/message-types.js';
import type { AddMembersMessageData } from '../../types/messages/add-members.js'; import type { AddMembersMessageData } from '../../types/messages/add-members.js';
import { import { minimallyEncodeMemberInfo } from '../../types/minimally-encoded-thread-permissions-types.js';
minimallyEncodeMemberInfo,
type ThickRawThreadInfo,
} from '../../types/minimally-encoded-thread-permissions-types.js';
import { joinThreadSubscription } from '../../types/subscription-types.js'; import { joinThreadSubscription } from '../../types/subscription-types.js';
import type { ThickMemberInfo } from '../../types/thread-types.js'; import type { ThickMemberInfo } from '../../types/thread-types.js';
import { updateTypes } from '../../types/update-types-enum.js'; import { updateTypes } from '../../types/update-types-enum.js';
import type { ClientUpdateInfo } from '../../types/update-types.js';
import { values } from '../../utils/objects.js'; import { values } from '../../utils/objects.js';
import { rawMessageInfoFromMessageData } from '../message-utils.js'; import { rawMessageInfoFromMessageData } from '../message-utils.js';
import { roleIsDefaultRole, userIsMember } from '../thread-utils.js'; import { roleIsDefaultRole, userIsMember } from '../thread-utils.js';
export type AddMembersResult = {
rawMessageInfos: Array<RawMessageInfo>,
updateInfos: Array<ClientUpdateInfo>,
threadInfo: ?ThickRawThreadInfo,
};
function createAddNewMembersMessageDataFromDMOperation( function createAddNewMembersMessageDataFromDMOperation(
dmOperation: DMAddMembersOperation, dmOperation: DMAddMembersOperation,
): AddMembersMessageData { ): AddMembersMessageData {
const { editorID, time, addedUserIDs, threadID } = dmOperation; const { editorID, time, addedUserIDs, threadID } = dmOperation;
return { return {
type: messageTypes.ADD_MEMBERS, type: messageTypes.ADD_MEMBERS,
threadID, threadID,
creatorID: editorID, creatorID: editorID,
▲ Show 20 Lines • Show All 115 Lines • Show Last 20 Lines
View Options

lib/types/thread-types.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import uuid from 'uuid'; import uuid from 'uuid';
import { createRoleAndPermissionForThickThreads } from './create-thread-spec.js'; import { createRoleAndPermissionForThickThreads } from './create-thread-spec.js';
import type { import type {
DMOperationSpec, DMOperationSpec,
ProcessDMOperationUtilities, ProcessDMOperationUtilities,
} from './dm-op-spec.js'; } from './dm-op-spec.js';
import type { DMAddMembersOperation } from '../../types/dm-ops.js'; import type { DMAddMembersOperation } from '../../types/dm-ops.js';
import { messageTypes } from '../../types/message-types-enum.js'; import { messageTypes } from '../../types/message-types-enum.js';
import { type RawMessageInfo } from '../../types/message-types.js';
import type { AddMembersMessageData } from '../../types/messages/add-members.js'; import type { AddMembersMessageData } from '../../types/messages/add-members.js';
import { import { minimallyEncodeMemberInfo } from '../../types/minimally-encoded-thread-permissions-types.js';
minimallyEncodeMemberInfo,
type ThickRawThreadInfo,
} from '../../types/minimally-encoded-thread-permissions-types.js';
import { joinThreadSubscription } from '../../types/subscription-types.js'; import { joinThreadSubscription } from '../../types/subscription-types.js';
import type { ThickMemberInfo } from '../../types/thread-types.js'; import type { ThickMemberInfo } from '../../types/thread-types.js';
import { updateTypes } from '../../types/update-types-enum.js'; import { updateTypes } from '../../types/update-types-enum.js';
import type { ClientUpdateInfo } from '../../types/update-types.js';
import { values } from '../../utils/objects.js'; import { values } from '../../utils/objects.js';
import { rawMessageInfoFromMessageData } from '../message-utils.js'; import { rawMessageInfoFromMessageData } from '../message-utils.js';
import { roleIsDefaultRole, userIsMember } from '../thread-utils.js'; import { roleIsDefaultRole, userIsMember } from '../thread-utils.js';
export type AddMembersResult = {
rawMessageInfos: Array<RawMessageInfo>,
updateInfos: Array<ClientUpdateInfo>,
threadInfo: ?ThickRawThreadInfo,
};
function createAddNewMembersMessageDataFromDMOperation( function createAddNewMembersMessageDataFromDMOperation(
dmOperation: DMAddMembersOperation, dmOperation: DMAddMembersOperation,
): AddMembersMessageData { ): AddMembersMessageData {
const { editorID, time, addedUserIDs, threadID } = dmOperation; const { editorID, time, addedUserIDs, threadID } = dmOperation;
return { return {
type: messageTypes.ADD_MEMBERS, type: messageTypes.ADD_MEMBERS,
threadID, threadID,
creatorID: editorID, creatorID: editorID,
▲ Show 20 Lines • Show All 115 Lines • Show Last 20 Lines