Page MenuHomePhabricator
Differential D12652

[lib] Introduce DMOperations
ClosedPublic
Actions

Authored by ashoat on Jul 3 2024, 5:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Feb 21, 12:56 AM
Unknown Object (File)
Fri, Feb 21, 12:56 AM
Unknown Object (File)
Fri, Feb 21, 12:56 AM
Unknown Object (File)
Fri, Feb 21, 12:56 AM
Unknown Object (File)
Feb 20 2025, 1:01 PM
Unknown Object (File)
Feb 3 2025, 1:48 PM
Unknown Object (File)
Jan 27 2025, 4:40 AM
Unknown Object (File)
Jan 21 2025, 10:41 PM
View All 82 Files
Subscribers
None

Details

Reviewers
tomek
marcin
inka
Commits
rCOMMbdece8406e42: [lib] Introduce DMOperations
Summary

This is the start of a stack addressing ENG-8421.

The idea is that communication will occur between peer devices via this new message type, communicated across usePeerToPeerMessageHandler via Tunnelbroker.

We might also process these on the sending client.

Test Plan

I haven't tested this stack outside of Flow. I'd like to propose that we land this so the team can iterate. I'll make sure to test all of the functionality once it's integrated into the rest of the codebase.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
shared/
dm-ops/
14 lines
17 lines
13 lines
14 lines
types/
63 lines

Diff 42063

View Options

lib/shared/dm-ops/create-thread-spec.js

Show First 20 Lines • Show All 341 Lines • ▼ Show 20 Lines
describe('minimallyEncodedRoleInfoValidator', () => { describe('minimallyEncodedRoleInfoValidator', () => {
it('should validate correctly formed MinimallyEncodedRoleInfo', () => { it('should validate correctly formed MinimallyEncodedRoleInfo', () => {
expect( expect(
roleInfoValidator.is({ roleInfoValidator.is({
minimallyEncoded: true, minimallyEncoded: true,
id: 'roleID', id: 'roleID',
name: 'roleName', name: 'roleName',
permissions: ['abc', 'def'], permissions: ['abc', 'def'],
isDefault: true,
specialRole: specialRoles.DEFAULT_ROLE, specialRole: specialRoles.DEFAULT_ROLE,
}), }),
).toBe(true); ).toBe(true);
}); });
it('should NOT validate malformed MinimallyEncodedRoleInfo', () => { it('should NOT validate malformed MinimallyEncodedRoleInfo', () => {
expect( expect(
roleInfoValidator.is({ roleInfoValidator.is({
▲ Show 20 Lines • Show All 303 Lines • Show Last 20 Lines
View Options

lib/shared/dm-ops/dm-op-spec.js

Show First 20 Lines • Show All 341 Lines • ▼ Show 20 Lines
describe('minimallyEncodedRoleInfoValidator', () => { describe('minimallyEncodedRoleInfoValidator', () => {
it('should validate correctly formed MinimallyEncodedRoleInfo', () => { it('should validate correctly formed MinimallyEncodedRoleInfo', () => {
expect( expect(
roleInfoValidator.is({ roleInfoValidator.is({
minimallyEncoded: true, minimallyEncoded: true,
id: 'roleID', id: 'roleID',
name: 'roleName', name: 'roleName',
permissions: ['abc', 'def'], permissions: ['abc', 'def'],
isDefault: true,
specialRole: specialRoles.DEFAULT_ROLE, specialRole: specialRoles.DEFAULT_ROLE,
}), }),
).toBe(true); ).toBe(true);
}); });
it('should NOT validate malformed MinimallyEncodedRoleInfo', () => { it('should NOT validate malformed MinimallyEncodedRoleInfo', () => {
expect( expect(
roleInfoValidator.is({ roleInfoValidator.is({
▲ Show 20 Lines • Show All 303 Lines • Show Last 20 Lines
View Options

lib/shared/dm-ops/dm-op-specs.js

Show First 20 Lines • Show All 341 Lines • ▼ Show 20 Lines
describe('minimallyEncodedRoleInfoValidator', () => { describe('minimallyEncodedRoleInfoValidator', () => {
it('should validate correctly formed MinimallyEncodedRoleInfo', () => { it('should validate correctly formed MinimallyEncodedRoleInfo', () => {
expect( expect(
roleInfoValidator.is({ roleInfoValidator.is({
minimallyEncoded: true, minimallyEncoded: true,
id: 'roleID', id: 'roleID',
name: 'roleName', name: 'roleName',
permissions: ['abc', 'def'], permissions: ['abc', 'def'],
isDefault: true,
specialRole: specialRoles.DEFAULT_ROLE, specialRole: specialRoles.DEFAULT_ROLE,
}), }),
).toBe(true); ).toBe(true);
}); });
it('should NOT validate malformed MinimallyEncodedRoleInfo', () => { it('should NOT validate malformed MinimallyEncodedRoleInfo', () => {
expect( expect(
roleInfoValidator.is({ roleInfoValidator.is({
▲ Show 20 Lines • Show All 303 Lines • Show Last 20 Lines
View Options

lib/shared/dm-ops/send-text-message-spec.js

Show First 20 Lines • Show All 341 Lines • ▼ Show 20 Lines
describe('minimallyEncodedRoleInfoValidator', () => { describe('minimallyEncodedRoleInfoValidator', () => {
it('should validate correctly formed MinimallyEncodedRoleInfo', () => { it('should validate correctly formed MinimallyEncodedRoleInfo', () => {
expect( expect(
roleInfoValidator.is({ roleInfoValidator.is({
minimallyEncoded: true, minimallyEncoded: true,
id: 'roleID', id: 'roleID',
name: 'roleName', name: 'roleName',
permissions: ['abc', 'def'], permissions: ['abc', 'def'],
isDefault: true,
specialRole: specialRoles.DEFAULT_ROLE, specialRole: specialRoles.DEFAULT_ROLE,
}), }),
).toBe(true); ).toBe(true);
}); });
it('should NOT validate malformed MinimallyEncodedRoleInfo', () => { it('should NOT validate malformed MinimallyEncodedRoleInfo', () => {
expect( expect(
roleInfoValidator.is({ roleInfoValidator.is({
▲ Show 20 Lines • Show All 303 Lines • Show Last 20 Lines
View Options

lib/types/dm-ops.js

Loading...