Page MenuHomePhabricator

[lib] Turn on notifs by default for thick threads
ClosedPublic

Authored by ashoat on Jul 20 2024, 9:38 PM.
Tags
None
Referenced Files
F3524767: D12825.id42625.diff
Mon, Dec 23, 2:25 PM
F3524766: D12825.id42596.diff
Mon, Dec 23, 2:25 PM
F3524765: D12825.id42591.diff
Mon, Dec 23, 2:25 PM
F3524747: D12825.id.diff
Mon, Dec 23, 2:24 PM
F3524734: D12825.diff
Mon, Dec 23, 2:24 PM
Unknown Object (File)
Wed, Dec 4, 7:09 PM
Unknown Object (File)
Thu, Nov 28, 1:07 PM
Unknown Object (File)
Tue, Nov 26, 3:48 AM
Subscribers
None

Details

Summary

When I first introduced this code, I used defaultThreadSubscription, thinking it corresponding to having notifs turned on.

After testing as part of ENG-8426, I found that thick threads were being created with notifs turned off. This made me realize I should be using joinThreadSubscription here to make sure that the notifs are turned on by default for thick threads.

Depends on D12824

Test Plan

I followed the test plan described in this Linear comment. Before this diff, the thick thread was created in the Muted tab. After this diff, it now appears in the Home tab

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable