Page MenuHomePhabricator

[lib] Turn on notifs by default for thick threads
ClosedPublic

Authored by ashoat on Jul 20 2024, 9:38 PM.
Tags
None
Referenced Files
F3140820: D12825.diff
Sun, Nov 3, 5:29 AM
Unknown Object (File)
Fri, Oct 25, 3:09 PM
Unknown Object (File)
Sat, Oct 19, 5:18 PM
Unknown Object (File)
Sat, Oct 19, 12:32 PM
Unknown Object (File)
Sat, Oct 19, 12:32 PM
Unknown Object (File)
Sat, Oct 19, 12:32 PM
Unknown Object (File)
Sat, Oct 19, 12:32 PM
Unknown Object (File)
Sat, Oct 19, 12:32 PM
Subscribers
None

Details

Summary

When I first introduced this code, I used defaultThreadSubscription, thinking it corresponding to having notifs turned on.

After testing as part of ENG-8426, I found that thick threads were being created with notifs turned off. This made me realize I should be using joinThreadSubscription here to make sure that the notifs are turned on by default for thick threads.

Depends on D12824

Test Plan

I followed the test plan described in this Linear comment. Before this diff, the thick thread was created in the Muted tab. After this diff, it now appears in the Home tab

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage