Details

Reviewers

kamil
tomek
marcin

Commits

rCOMM308cf3b2c316: [lib] Introduce getRelatedMessages to SQLiteAPI

Summary

This diff introduces a shared interface on SQLiteAPI so the JS code in lib can hit this API on both native and web.

Depends on D12739

Test Plan

In combination with later diffs, I tested a patch on both native and web that hit getRelatedMessages with a specific message ID and confirmed that it returned the message
I tested a message ID that did not exist and confirmed I got undefined back

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Jul 14 2024, 6:14 PM

ashoat added a child revision: D12741: [lib] Process DMOperations when received from peers via Tunnelbroker.Jul 14 2024, 6:17 PM

Harbormaster completed remote builds in B30313: Diff 42273.Jul 14 2024, 6:38 PM

ashoat requested review of this revision.Jul 14 2024, 6:38 PM

marcin accepted this revision.Jul 15 2024, 2:58 AM

This revision is now accepted and ready to land.Jul 15 2024, 2:58 AM

ashoat added a child revision: D12759: [SQLite] Add target_message generated column and index.Jul 15 2024, 2:15 PM

ashoat removed a child revision: D12741: [lib] Process DMOperations when received from peers via Tunnelbroker.Jul 15 2024, 2:26 PM

ashoat retitled this revision from [lib] Introduce getLatestMessageEdit to SQLiteAPI to [lib] Introduce getRelatedMessages to SQLiteAPI.Jul 15 2024, 7:03 PM

ashoat edited the test plan for this revision. (Show Details)

ashoat added a child revision: D12741: [lib] Process DMOperations when received from peers via Tunnelbroker.Jul 15 2024, 7:06 PM

ashoat removed a child revision: D12759: [SQLite] Add target_message generated column and index.

Rework into getRelatedMessages, which can be reused for rendering search results

Harbormaster failed remote builds in B30350: Diff 42312!Jul 15 2024, 7:31 PM

ashoat added a child revision: D12764: [lib] Introduce useGetLatestMessageEdit.Jul 15 2024, 7:38 PM

ashoat removed a child revision: D12741: [lib] Process DMOperations when received from peers via Tunnelbroker.Jul 15 2024, 7:38 PM

ESLint fix

Harbormaster failed remote builds in B30356: Diff 42318!Jul 15 2024, 8:42 PM

Rebase

Harbormaster completed remote builds in B30372: Diff 42335.Jul 16 2024, 4:32 AM

Closed by commit rCOMM308cf3b2c316: [lib] Introduce getRelatedMessages to SQLiteAPI (authored by ashoat). · Explain WhyJul 16 2024, 6:46 PM