Page MenuHomePhabricator
Feed Advanced Search

Today

marcin added inline comments to D11684: Construct local badge-only notif when notification doesn't have body property.
Fri, Apr 19, 12:15 PM
marcin updated the diff for D11638: Persist SIWE backup secrets to SQLite after succesfull registration process.
  1. Put SIWE backup secrets persistence to step 1.
  2. Put clearing cached selections to step 2.
Fri, Apr 19, 10:30 AM
marcin added inline comments to D11638: Persist SIWE backup secrets to SQLite after succesfull registration process.
Fri, Apr 19, 10:28 AM
marcin requested review of D11702: Remove unecessary SQLite initialization from CommHybrid.
Fri, Apr 19, 10:08 AM
marcin updated the diff for D11684: Construct local badge-only notif when notification doesn't have body property.
  1. Update the comment
  2. Use method to get badge only content for notif.
Fri, Apr 19, 10:03 AM
marcin added inline comments to D11684: Construct local badge-only notif when notification doesn't have body property.
Fri, Apr 19, 9:41 AM
marcin updated the diff for D11638: Persist SIWE backup secrets to SQLite after succesfull registration process.

Add finally statements to set gurd refs to false eventually.

Fri, Apr 19, 8:20 AM
marcin added a comment to D11638: Persist SIWE backup secrets to SQLite after succesfull registration process.

It wasn't easy to introduce new step here. If this solution is not accepted I will just introduce new step that clears cached Selections in the same promise as sqlite persistence and leave avatar upload unchanged.

Fri, Apr 19, 8:15 AM
marcin updated the diff for D11638: Persist SIWE backup secrets to SQLite after succesfull registration process.

Introduce two new steps: SQLite data persistence and clearing cached selections

Fri, Apr 19, 8:11 AM
marcin updated the diff for D11636: Implement screen to create backup mesage and its signature.

Encrypt with Ethereum Wallet -> Encrypt with Ethereum signature

Fri, Apr 19, 8:10 AM
marcin added inline comments to D11684: Construct local badge-only notif when notification doesn't have body property.
Fri, Apr 19, 8:07 AM
marcin added inline comments to D11638: Persist SIWE backup secrets to SQLite after succesfull registration process.
Fri, Apr 19, 4:58 AM
marcin added inline comments to D11638: Persist SIWE backup secrets to SQLite after succesfull registration process.
Fri, Apr 19, 3:43 AM
marcin updated the diff for D11684: Construct local badge-only notif when notification doesn't have body property.
  1. Remove needsSilentBadgeUpdate function and replace it with inline checks.
  2. Bring back useful comment.
Fri, Apr 19, 3:05 AM
marcin added inline comments to D11684: Construct local badge-only notif when notification doesn't have body property.
Fri, Apr 19, 3:05 AM
marcin accepted D11693: [native] Wait for authoritative keyserver login before setting avatar in registration flow.
Fri, Apr 19, 2:46 AM

Yesterday

marcin requested review of D11684: Construct local badge-only notif when notification doesn't have body property.
Thu, Apr 18, 4:07 AM
marcin added inline comments to D11638: Persist SIWE backup secrets to SQLite after succesfull registration process.
Thu, Apr 18, 1:24 AM
marcin updated the diff for D11645: Force already logged in ETH users to create and sign backup message.

Persist directly to SQLite when forcing user to create backup message signature.

Thu, Apr 18, 1:22 AM
marcin updated the diff for D11644: Extract shareable logic from CreateSIWEBackupMessage component.

REbase to reflect changes from parent diff

Thu, Apr 18, 1:22 AM
marcin updated the diff for D11638: Persist SIWE backup secrets to SQLite after succesfull registration process.

Move siwe secrets persistence and cached selections clearing to registration server call.

Thu, Apr 18, 1:21 AM
marcin attached a referenced file: F1568318: Simulator Screen Shot - iPhone 14 Pro - 2024-04-18 at 09.53.40.png.
Thu, Apr 18, 1:20 AM
marcin added a comment to D11636: Implement screen to create backup mesage and its signature.

If we go back from registration terms screen then siwe backup message creation screen looks like this:

Simulator Screen Shot - iPhone 14 Pro - 2024-04-18 at 09.53.40.png (2×1 px, 144 KB)

Thu, Apr 18, 1:20 AM
marcin updated the diff for D11636: Implement screen to create backup mesage and its signature.

Handle existing siwe backup secrets in cached selections.

Thu, Apr 18, 1:18 AM

Wed, Apr 17

marcin added a comment to D11666: [native] Rename get/setCurrentUserID in CommCoreModule.

Should we regenerate a wasm file?

Wed, Apr 17, 4:35 AM

Tue, Apr 16

marcin added inline comments to D11638: Persist SIWE backup secrets to SQLite after succesfull registration process.
Tue, Apr 16, 7:35 AM
marcin added a comment to D11638: Persist SIWE backup secrets to SQLite after succesfull registration process.

Are we able to cache it, such that if the user goes back to before this screen, and then advances to this screen again, the SIWE flow does not need to be re-entered?

Tue, Apr 16, 5:55 AM
marcin updated the diff for D11638: Persist SIWE backup secrets to SQLite after succesfull registration process.
  1. Clear all cached selections at once after user becomes logged in. Persist siweBackupSecrets in SQLite beforehand.
Tue, Apr 16, 5:52 AM
marcin added inline comments to D11636: Implement screen to create backup mesage and its signature.
Tue, Apr 16, 5:51 AM
marcin attached a referenced file: F1552593: Simulator Screen Shot - iPhone 14 Pro - 2024-04-16 at 14.11.09.png.
Tue, Apr 16, 5:45 AM
marcin added a comment to D11636: Implement screen to create backup mesage and its signature.

Screen with backup icon from MaterialIcons

Simulator Screen Shot - iPhone 14 Pro - 2024-04-16 at 14.11.09.png (2×1 px, 128 KB)

Tue, Apr 16, 5:44 AM
marcin updated the diff for D11644: Extract shareable logic from CreateSIWEBackupMessage component.

Use backup icon from MaterialIcons

Tue, Apr 16, 5:06 AM
marcin updated the diff for D11636: Implement screen to create backup mesage and its signature.

Use backup icon from MaterialIcons

Tue, Apr 16, 5:05 AM
marcin added inline comments to D11636: Implement screen to create backup mesage and its signature.
Tue, Apr 16, 5:04 AM
marcin attached a referenced file: F1552438: Simulator Screen Shot - iPhone 14 Pro - 2024-04-16 at 13.39.45.png.
Tue, Apr 16, 4:43 AM
marcin added a comment to D11636: Implement screen to create backup mesage and its signature.

New screen looks like this:

Simulator Screen Shot - iPhone 14 Pro - 2024-04-16 at 13.39.45.png (2×1 px, 135 KB)

Tue, Apr 16, 4:42 AM
marcin added inline comments to D11636: Implement screen to create backup mesage and its signature.
Tue, Apr 16, 4:42 AM
marcin updated the diff for D11636: Implement screen to create backup mesage and its signature.

Add icon to enchance user experience.

Tue, Apr 16, 4:41 AM
marcin added inline comments to D11645: Force already logged in ETH users to create and sign backup message.
Tue, Apr 16, 3:55 AM
marcin added inline comments to D11645: Force already logged in ETH users to create and sign backup message.
Tue, Apr 16, 3:49 AM
marcin added inline comments to D11638: Persist SIWE backup secrets to SQLite after succesfull registration process.
Tue, Apr 16, 3:05 AM

Mon, Apr 15

marcin added inline comments to D11645: Force already logged in ETH users to create and sign backup message.
Mon, Apr 15, 9:40 AM
marcin updated the diff for D11645: Force already logged in ETH users to create and sign backup message.

Bring back deleted condition that is actually necessary.

Mon, Apr 15, 8:24 AM
marcin added inline comments to D11645: Force already logged in ETH users to create and sign backup message.
Mon, Apr 15, 8:23 AM
marcin updated the diff for D11645: Force already logged in ETH users to create and sign backup message.

Simplify condition

Mon, Apr 15, 8:20 AM
marcin added inline comments to D11645: Force already logged in ETH users to create and sign backup message.
Mon, Apr 15, 8:16 AM
marcin updated the diff for D11644: Extract shareable logic from CreateSIWEBackupMessage component.

Memoize CreateSIWEBackupMessageBase

Mon, Apr 15, 8:07 AM
marcin updated the diff for D11638: Persist SIWE backup secrets to SQLite after succesfull registration process.

Use cachedSelections to keep siweBackupSecrets

Mon, Apr 15, 8:07 AM
marcin updated the diff for D11634: Introduce user texts for siwe backup message creation.
  1. Update user texts
Mon, Apr 15, 8:05 AM
marcin added inline comments to D11638: Persist SIWE backup secrets to SQLite after succesfull registration process.
Mon, Apr 15, 7:55 AM
marcin added a comment to D11635: Handle backup message type with different user texts in siwe.reac.js.

Would be good to include screenshots of what the various screens look like from mobile. (You can omit the original screen if it's unchanged.)

Mon, Apr 15, 7:54 AM
marcin attached a referenced file: F1549420: Simulator Screen Shot - iPhone 14 Pro - 2024-04-15 at 16.03.27.png.
Mon, Apr 15, 7:53 AM
marcin attached a referenced file: F1549434: simulator-screen-recording-iphone-14-pro-2024-04-15-at-155923_hNfN1eQU.mp4.
Mon, Apr 15, 7:52 AM
marcin attached a referenced file: F1549424: Simulator Screen Shot - iPhone 14 Pro - 2024-04-15 at 16.04.12.png.
Mon, Apr 15, 7:52 AM
marcin added a comment to D11636: Implement screen to create backup mesage and its signature.

Video with the registration flow:

Mon, Apr 15, 7:52 AM
marcin added inline comments to D11645: Force already logged in ETH users to create and sign backup message.
Mon, Apr 15, 4:33 AM
marcin closed D11661: Handle key permanently invalidated error to fix Android app crash.
Mon, Apr 15, 4:11 AM
marcin committed rCOMMde6a3fd1d383: Handle key permanently invalidated error to fix Android app crash (authored by marcin).
Handle key permanently invalidated error to fix Android app crash
Mon, Apr 15, 4:11 AM
marcin added a comment to D11637: Implement JSI getter and setter for siwe backup secrets.
In D11637#334446, @atul wrote:

Looks good. (There shouldn't be any WASM stuff that needs to be generated for the non-DB code here right?)

Mon, Apr 15, 4:09 AM
marcin added inline comments to D11636: Implement screen to create backup mesage and its signature.
Mon, Apr 15, 4:07 AM
marcin added inline comments to D11635: Handle backup message type with different user texts in siwe.reac.js.
Mon, Apr 15, 3:44 AM
marcin added inline comments to D11634: Introduce user texts for siwe backup message creation.
Mon, Apr 15, 3:41 AM
marcin updated the diff for D11661: Handle key permanently invalidated error to fix Android app crash.

Rebase before landing.

Mon, Apr 15, 3:24 AM
marcin added a comment to D11649: [web] Reassign the notifs session.

One additional questions:
Is it possible that due to some internal keyserver error the cookie will change and the keyserver will request the client to create new notifs session but new notifications session creation will execute before the effect is executed? In such case the old session would overwrite new one.

Mon, Apr 15, 12:38 AM
marcin accepted D11649: [web] Reassign the notifs session.

I would amend to the test plan some steps that try to recreate race condition when we log in multiple pages at the same time. We should expect that after logging in to all pages we can see multiple notifs sessions in IndexedDB but when the notifs is received we can decrypt it and it removes all but one notif session.

Mon, Apr 15, 12:33 AM
marcin accepted D11648: [web] Create a function that reassigns notifs session.
Mon, Apr 15, 12:26 AM
marcin accepted D11647: [web] Extract a function that determines where to store notifs session.
Mon, Apr 15, 12:18 AM

Sun, Apr 14

marcin requested review of D11661: Handle key permanently invalidated error to fix Android app crash.
Sun, Apr 14, 4:21 AM

Fri, Apr 12

marcin requested review of D11645: Force already logged in ETH users to create and sign backup message.
Fri, Apr 12, 5:57 AM
marcin updated the diff for D11638: Persist SIWE backup secrets to SQLite after succesfull registration process.

Simplify hook

Fri, Apr 12, 5:44 AM
marcin requested review of D11644: Extract shareable logic from CreateSIWEBackupMessage component.
Fri, Apr 12, 5:39 AM
marcin abandoned D5057: Expose rust native blob gRPC client API to C++.

Diff from 2022 what I was assigned encrypted blob upload work.

Fri, Apr 12, 4:59 AM
marcin abandoned D5056: Implement data structure and methods to start and continue gRPC multimedia download streaming.

Diff from 2022 what I was assigned encrypted blob upload work.

Fri, Apr 12, 4:59 AM
marcin abandoned D5055: Implement methods to start, continue and resume gRPC blob streaming.

Diff from 2022 what I was assigned encrypted blob upload work.

Fri, Apr 12, 4:58 AM
marcin added a comment to D5055: Implement methods to start, continue and resume gRPC blob streaming.

Diff from 2022 what I was assigned encrypted blob upload work.

Fri, Apr 12, 4:58 AM
marcin abandoned D5054: Define data structure for holding multimedia upload process state and method to initialize.

Diff from 2022 what I was assigned encrypted blob upload work.

Fri, Apr 12, 4:58 AM
marcin abandoned D5053: Define tokio runtime.

Diff from 2022 what I was assigned encrypted blob upload work.

Fri, Apr 12, 4:57 AM
marcin abandoned D5052: Expose module with generated tonic blob client code.

Diff from 2022 what I was assigned encrypted blob upload work.

Fri, Apr 12, 4:57 AM
marcin abandoned D5051: rust project for native blob gRPC client.

Diff from 2022 what I was assigned encrypted blob upload work.

Fri, Apr 12, 4:57 AM
marcin added a comment to D4983: Share database worker thread between CommCoreModule and AppDelegate.

GlobalDBSingleton handles that.

Fri, Apr 12, 4:55 AM
marcin added a comment to D4699: Remove database acces upon rescinding.

The only purpose of this diff was to create release that could potentially fix the crash https://linear.app/comm/issue/ENG-1464/ios-build-137-crashes

Fri, Apr 12, 4:55 AM
marcin added a comment to D4650: Throw informative JSError when SQLite query via ORM fails.

It was already done. This diff: https://phab.comm.dev/D8601 confirms it.

Fri, Apr 12, 4:52 AM
marcin added a comment to D4573: Place call to completionHandler outside rescinding callback so that we avoid app being killed by the system.

This diff was only used to create a release that was supposed to fix a crash: https://linear.app/comm/issue/ENG-1464/ios-build-137-crashes. The solution wasn't correct.

Fri, Apr 12, 4:51 AM
marcin added a comment to D4063: Use notification service on ios to store notification in sqlite.

This diff is no longer relevant - abandoning.

Fri, Apr 12, 4:48 AM
marcin abandoned D4983: Share database worker thread between CommCoreModule and AppDelegate.
Fri, Apr 12, 4:46 AM
marcin abandoned D4871: Block thread status update in SQLite.
Fri, Apr 12, 4:45 AM
marcin abandoned D4699: Remove database acces upon rescinding.
Fri, Apr 12, 4:45 AM
marcin abandoned D4654: Conditionally crash the app on getAllMessagesSync failure.
Fri, Apr 12, 4:45 AM
marcin abandoned D4650: Throw informative JSError when SQLite query via ORM fails.
Fri, Apr 12, 4:44 AM
marcin abandoned D4063: Use notification service on ios to store notification in sqlite.
Fri, Apr 12, 4:42 AM
marcin abandoned D4573: Place call to completionHandler outside rescinding callback so that we avoid app being killed by the system.
Fri, Apr 12, 4:41 AM

Thu, Apr 11

marcin requested review of D11638: Persist SIWE backup secrets to SQLite after succesfull registration process.
Thu, Apr 11, 9:57 AM
marcin requested review of D11636: Implement screen to create backup mesage and its signature.
Thu, Apr 11, 9:40 AM
marcin requested review of D11637: Implement JSI getter and setter for siwe backup secrets.
Thu, Apr 11, 9:34 AM
marcin requested review of D11635: Handle backup message type with different user texts in siwe.reac.js.
Thu, Apr 11, 9:21 AM
marcin requested review of D11633: Introduce SIWE message types.
Thu, Apr 11, 9:13 AM
marcin requested review of D11634: Introduce user texts for siwe backup message creation.
Thu, Apr 11, 9:12 AM
marcin accepted D11596: [lib] handle race condition when creating `olm` session.
Thu, Apr 11, 1:00 AM
marcin accepted D11595: [web/native] make `overwrite` param for inbound session mandatory and unify web & native.
Thu, Apr 11, 12:57 AM
marcin added a comment to D11577: [SQLite] add version column to session table & rename to `target_device`.

We should implement it for notifs while working on DMs - now there is no need to I guess.

Is there a task for this?

Thu, Apr 11, 12:55 AM