- Put SIWE backup secrets persistence to step 1.
- Put clearing cached selections to step 2.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Today
- Update the comment
- Use method to get badge only content for notif.
Add finally statements to set gurd refs to false eventually.
It wasn't easy to introduce new step here. If this solution is not accepted I will just introduce new step that clears cached Selections in the same promise as sqlite persistence and leave avatar upload unchanged.
Introduce two new steps: SQLite data persistence and clearing cached selections
Encrypt with Ethereum Wallet -> Encrypt with Ethereum signature
- Remove needsSilentBadgeUpdate function and replace it with inline checks.
- Bring back useful comment.
Yesterday
Persist directly to SQLite when forcing user to create backup message signature.
REbase to reflect changes from parent diff
Move siwe secrets persistence and cached selections clearing to registration server call.
If we go back from registration terms screen then siwe backup message creation screen looks like this:
Handle existing siwe backup secrets in cached selections.
Wed, Apr 17
In D11666#335421, @tomek wrote:Should we regenerate a wasm file?
Tue, Apr 16
Are we able to cache it, such that if the user goes back to before this screen, and then advances to this screen again, the SIWE flow does not need to be re-entered?
- Clear all cached selections at once after user becomes logged in. Persist siweBackupSecrets in SQLite beforehand.
Use backup icon from MaterialIcons
Use backup icon from MaterialIcons
Add icon to enchance user experience.
Mon, Apr 15
Bring back deleted condition that is actually necessary.
Simplify condition
Memoize CreateSIWEBackupMessageBase
Use cachedSelections to keep siweBackupSecrets
- Update user texts
In D11635#334580, @ashoat wrote:Would be good to include screenshots of what the various screens look like from mobile. (You can omit the original screen if it's unchanged.)
Video with the registration flow:
In D11637#334446, @atul wrote:Looks good. (There shouldn't be any WASM stuff that needs to be generated for the non-DB code here right?)
Rebase before landing.
One additional questions:
Is it possible that due to some internal keyserver error the cookie will change and the keyserver will request the client to create new notifs session but new notifications session creation will execute before the effect is executed? In such case the old session would overwrite new one.
I would amend to the test plan some steps that try to recreate race condition when we log in multiple pages at the same time. We should expect that after logging in to all pages we can see multiple notifs sessions in IndexedDB but when the notifs is received we can decrypt it and it removes all but one notif session.
Sun, Apr 14
Fri, Apr 12
Simplify hook
Diff from 2022 what I was assigned encrypted blob upload work.
Diff from 2022 what I was assigned encrypted blob upload work.
Diff from 2022 what I was assigned encrypted blob upload work.
Diff from 2022 what I was assigned encrypted blob upload work.
Diff from 2022 what I was assigned encrypted blob upload work.
Diff from 2022 what I was assigned encrypted blob upload work.
Diff from 2022 what I was assigned encrypted blob upload work.
Diff from 2022 what I was assigned encrypted blob upload work.
GlobalDBSingleton handles that.
The only purpose of this diff was to create release that could potentially fix the crash https://linear.app/comm/issue/ENG-1464/ios-build-137-crashes
It was already done. This diff: https://phab.comm.dev/D8601 confirms it.
This diff was only used to create a release that was supposed to fix a crash: https://linear.app/comm/issue/ENG-1464/ios-build-137-crashes. The solution wasn't correct.
This diff is no longer relevant - abandoning.
Thu, Apr 11
In D11577#333862, @ashoat wrote:We should implement it for notifs while working on DMs - now there is no need to I guess.
Is there a task for this?